From: Aaron Schulz <aschulz@wikimedia.org>
Date: Tue, 1 Dec 2015 00:55:43 +0000 (-0800)
Subject: Make HTMLCacheUpdate callers more consistent
X-Git-Tag: 1.31.0-rc.0~8844^2
X-Git-Url: https://git.cyclocoop.org//%22?a=commitdiff_plain;h=27f5abac5456c63812dfc35c001cb1a49fcd7a75;p=lhc%2Fweb%2Fwiklou.git

Make HTMLCacheUpdate callers more consistent

A few random callers were calling doUpdate() themselves
instead of using DeferredUpdates

Change-Id: If121e6afab9899dae92f0bf831b0b0c9967deeb5
---

diff --git a/includes/deferred/LinksUpdate.php b/includes/deferred/LinksUpdate.php
index a6290ed9da..c253e74403 100644
--- a/includes/deferred/LinksUpdate.php
+++ b/includes/deferred/LinksUpdate.php
@@ -948,8 +948,7 @@ class LinksUpdate extends SqlDataUpdate implements EnqueueableDataUpdate {
 					$inv = array( $inv );
 				}
 				foreach ( $inv as $table ) {
-					$update = new HTMLCacheUpdate( $this->mTitle, $table );
-					$update->doUpdate();
+					DeferredUpdates::addUpdate( new HTMLCacheUpdate( $this->mTitle, $table ) );
 				}
 			}
 		}
diff --git a/includes/specials/SpecialUndelete.php b/includes/specials/SpecialUndelete.php
index 447c3ef1c6..664205aa20 100644
--- a/includes/specials/SpecialUndelete.php
+++ b/includes/specials/SpecialUndelete.php
@@ -636,8 +636,7 @@ class PageArchive {
 		Hooks::run( 'ArticleUndelete', array( &$this->title, $created, $comment, $oldPageId ) );
 
 		if ( $this->title->getNamespace() == NS_FILE ) {
-			$update = new HTMLCacheUpdate( $this->title, 'imagelinks' );
-			$update->doUpdate();
+			DeferredUpdates::addUpdate( new HTMLCacheUpdate( $this->title, 'imagelinks' ) );
 		}
 
 		return Status::newGood( $restored );