From: Timo Tijhof <krinklemail@gmail.com>
Date: Mon, 6 May 2013 18:55:04 +0000 (+0200)
Subject: qunit: Use jQuery.getScript instead of document.write
X-Git-Tag: 1.31.0-rc.0~19752
X-Git-Url: https://git.cyclocoop.org//%22?a=commitdiff_plain;h=05f6edc903f81993c9862e7cd2e2e92fbefc63e7;p=lhc%2Fweb%2Fwiklou.git

qunit: Use jQuery.getScript instead of document.write

TestSwarm jobs were breaking because this runs after the
document is ready, thus causing the page to be blanked by
document.write.

Change-Id: I5e1c331d72ac364c9cd970a9b085f0b986b26a14
---

diff --git a/tests/qunit/data/testrunner.js b/tests/qunit/data/testrunner.js
index 3f3c8992ee..1a2bfa102d 100644
--- a/tests/qunit/data/testrunner.js
+++ b/tests/qunit/data/testrunner.js
@@ -50,7 +50,7 @@
 	// of MediaWiki has actually been configured with the required url to that inject.js
 	// script. By default it is false.
 	if ( QUnit.urlParams.swarmURL && mw.config.get( 'QUnitTestSwarmInjectJSPath' ) ) {
-		document.write( '<scr' + 'ipt src="' + QUnit.fixurl( mw.config.get( 'QUnitTestSwarmInjectJSPath' ) ) + '"></scr' + 'ipt>' );
+		jQuery.getScript( QUnit.fixurl( mw.config.get( 'QUnitTestSwarmInjectJSPath' ) ) );
 	}
 
 	/**