Improved on r74282 and r74333 in response to CR comments.

diff --git a/resources/jquery/jquery.placeholder.js b/resources/jquery/jquery.placeholder.js
index 407b1a9..f445224 100644 (file)
--- a/resources/jquery/jquery.placeholder.js
+++ b/resources/jquery/jquery.placeholder.js
@@ -16,7 +16,7 @@ jQuery.fn.placeholder = function( text ) {
        // Otherwise, use a combination of blur and focus event handlers and a placeholder class
        else {
                jQuery(this).each( function() {
-                       $input = jQuery(this);
+                       var $input = jQuery(this);
                        $input
                                // Show on blur if empty
                                .bind( 'blur', function() {

diff --git a/resources/mediawiki/mediawiki.specials.preferences.js b/resources/mediawiki/mediawiki.specials.preferences.js
index 9122a11..e6760fc 100644 (file)
--- a/resources/mediawiki/mediawiki.specials.preferences.js
+++ b/resources/mediawiki/mediawiki.specials.preferences.js
@@ -2,14 +2,14 @@
  * JavaScript for Special:Preferences
  */
 
-$( '#prefsubmit' ).attr( 'id', 'prefcontrol' ).end()
+$( '#prefsubmit' ).attr( 'id', 'prefcontrol' );
 $( '#preferences' )
        .addClass( 'jsprefs' )
        .before( $( '<ul id="preftoc"></ul>' ) )
-       .find( '> fieldset' )
+       .children( 'fieldset' )
        .hide()
        .addClass( 'prefsection' )
-       .find( '> legend' )
+       .children( 'legend' )
        .addClass( 'mainLegend' )
        .each( function( i ) {
                $(this).parent().attr( 'id', 'prefsection-' + i );