(bug 13630) allow_call_time_pass_reference warnings in Special:Revisiondelete

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index dfb4b2c..395ec3e 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -156,6 +156,8 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * (bug 13431) Show true message source in Special:Allmessages&ot=php / xml
 * (bug 13616) Replace underscores in search terms by spaces
 * (bug 13463) Login successful page doesn't use user's preferred interface language
+* (bug 13630) Fixed warnings for pass by reference at call time in
+  Special:Revisiondelete when generating the log entry.
 
 === API changes in 1.13 ===
 

diff --git a/includes/SpecialRevisiondelete.php b/includes/SpecialRevisiondelete.php
index 125cec8..1a01b76 100644 (file)
--- a/includes/SpecialRevisiondelete.php
+++ b/includes/SpecialRevisiondelete.php
@@ -1344,7 +1344,7 @@ class RevisionDeleter {
         * @param int $diff The xor of the old and new bitfields.
         * @param array $arr The array to update.
         */
-       function checkItem ( $desc, $field, $diff, $new, $arr ) {
+       function checkItem ( $desc, $field, $diff, $new, &$arr ) {
                if ( $diff & $field ) {
                        $arr [ ( $new & $field ) ? 0 : 1 ][] = $desc;
                }
@@ -1366,9 +1366,9 @@ class RevisionDeleter {
                $diff = $n ^ $o;
                $ret = array ( 0 => array(), 1 => array(), 2 => array() );
 
-               $this->checkItem ( wfMsgForContent ( 'revdelete-content' ), 1, $diff, $n, &$ret );
-               $this->checkItem ( wfMsgForContent ( 'revdelete-summary' ), 2, $diff, $n, &$ret );
-               $this->checkItem ( wfMsgForContent ( 'revdelete-uname' ),   4, $diff, $n, &$ret );
+               $this->checkItem ( wfMsgForContent ( 'revdelete-content' ), 1, $diff, $n, $ret );
+               $this->checkItem ( wfMsgForContent ( 'revdelete-summary' ), 2, $diff, $n, $ret );
+               $this->checkItem ( wfMsgForContent ( 'revdelete-uname' ),   4, $diff, $n, $ret );
 
                // Restriction application to sysops
                if ( $diff & Revision::DELETED_RESTRICTED ) {