From: Derick Alangi <alangiderick@gmail.com>
Date: Thu, 11 Apr 2019 22:03:57 +0000 (+0100)
Subject: dao: Correct return type doc for getLoadBalancer()
X-Git-Tag: 1.34.0-rc.0~2029^2
X-Git-Url: https://git.cyclocoop.org//%22%7B%7Blocalurle:Project:Pol%C3%ADtica_de_imagens%7D%7D/%22?a=commitdiff_plain;h=e1f5364f562d729a5f33eb9bbc85c6ad0f049361;p=lhc%2Fweb%2Fwiklou.git

dao: Correct return type doc for getLoadBalancer()

This method creates a load balancer object using services and calls
getMainLB() which returns an instance of ILoadBalancer and not an
instance of LoadBalancer, hence, getLoadBalancer() should return an
instance of ILoadBalancer instead.

Change-Id: I8859f293985d256d02ddc6f90e2aea813ebfc955
---

diff --git a/includes/dao/DBAccessBase.php b/includes/dao/DBAccessBase.php
index 8900962225..e099b38f09 100644
--- a/includes/dao/DBAccessBase.php
+++ b/includes/dao/DBAccessBase.php
@@ -2,7 +2,7 @@
 
 use MediaWiki\MediaWikiServices;
 use Wikimedia\Rdbms\IDatabase;
-use Wikimedia\Rdbms\LoadBalancer;
+use Wikimedia\Rdbms\ILoadBalancer;
 
 /**
  * Base class for objects that allow access to other wiki's databases using
@@ -88,7 +88,7 @@ abstract class DBAccessBase implements IDBAccessObject {
 	 *
 	 * @since 1.21
 	 *
-	 * @return LoadBalancer The database load balancer object
+	 * @return ILoadBalancer The database load balancer object
 	 */
 	public function getLoadBalancer() {
 		$lbFactory = MediaWikiServices::getInstance()->getDBLoadBalancerFactory();