From 7f5a204e427a42c8ea48ae4a74cafd1e517dc245 Mon Sep 17 00:00:00 2001 From: Derick Alangi Date: Mon, 25 Mar 2019 00:55:42 +0100 Subject: [PATCH] diff: Wrap condition around brackets for more readability Also, as I'm touching this line, fixing the is_null() check to finally clean this entire line up once and for all. Change-Id: I573972519796f3eedaf950fa953b9df6b6824379 --- includes/diff/DifferenceEngine.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/includes/diff/DifferenceEngine.php b/includes/diff/DifferenceEngine.php index 833bc6950d..1ab1246ba0 100644 --- a/includes/diff/DifferenceEngine.php +++ b/includes/diff/DifferenceEngine.php @@ -1733,16 +1733,16 @@ class DifferenceEngine extends ContextSource { * by the request context); if oldid is 0, then compare the revision in newid to the * immediately previous one. * - * If oldid is false, leave the corresponding revision object set - * to false. This can happen with 'diff=prev' pointing to a non-existent revision, - * and is also used directly by the API. + * If oldid is false, leave the corresponding revision object set to false. This can + * happen with 'diff=prev' pointing to a non-existent revision, and is also used directly + * by the API. * * @return bool Whether both revisions were loaded successfully. Setting mOldRev * to false counts as successful loading. */ public function loadRevisionData() { if ( $this->mRevisionsLoaded ) { - return $this->isContentOverridden || $this->mNewRev && !is_null( $this->mOldRev ); + return $this->isContentOverridden || ( $this->mOldRev !== null && $this->mNewRev !== null ); } // Whether it succeeds or fails, we don't want to try again -- 2.20.1