From 548e0da3278ae1cac8f5a5caed632e0f5eefb942 Mon Sep 17 00:00:00 2001 From: Max Semenik Date: Wed, 20 Sep 2017 13:39:49 -0700 Subject: [PATCH] Fix ip_changes insert counting Change-Id: I02b457d9dcaadc97eead623e42a5a1ccf8335724 --- maintenance/populateIpChanges.php | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/maintenance/populateIpChanges.php b/maintenance/populateIpChanges.php index 2b2a2b433d..40a596c8f2 100644 --- a/maintenance/populateIpChanges.php +++ b/maintenance/populateIpChanges.php @@ -110,14 +110,11 @@ TEXT } } - $dbw->insert( - 'ip_changes', - $insertRows, - __METHOD__, - 'IGNORE' - ); + if ( $insertRows ) { + $dbw->insert( 'ip_changes', $insertRows, __METHOD__, 'IGNORE' ); - $inserted += $dbw->affectedRows(); + $inserted += $dbw->affectedRows(); + } $lbFactory->waitForReplication(); usleep( $throttle * 1000 ); -- 2.20.1