jenkins-bot [Mon, 26 Sep 2016 17:14:52 +0000 (17:14 +0000)]
Merge "HTMLForm: Add HTMLDateTimeField"
Brad Jorsch [Thu, 22 Sep 2016 17:28:29 +0000 (13:28 -0400)]
HTMLForm: Add HTMLDateTimeField
And to do that, an OOUI PHP widget for
mw.widgets.datetime.DateTimeInputWidget too.
Bug: T146340
Change-Id: Iaa8b5892b6c3a1f3698cef59684cc3cdc9d483ea
jenkins-bot [Mon, 26 Sep 2016 15:30:54 +0000 (15:30 +0000)]
Merge "Avoid DB_MASTER use on password checks and defer password upgrades"
jenkins-bot [Mon, 26 Sep 2016 09:59:12 +0000 (09:59 +0000)]
Merge "Fix IDEA warning in FSFileBackend"
jenkins-bot [Mon, 26 Sep 2016 09:58:08 +0000 (09:58 +0000)]
Merge "Fix IDEA warnings in FileBackendStore"
jenkins-bot [Mon, 26 Sep 2016 09:58:05 +0000 (09:58 +0000)]
Merge "Use @lang tags for Lua scripts"
Translation updater bot [Sun, 25 Sep 2016 19:55:34 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Iee88cf7ca866040931ab75e85c27c6efa73aa1ff
Aaron Schulz [Sun, 25 Sep 2016 18:50:16 +0000 (11:50 -0700)]
Use @lang tags for Lua scripts
Change-Id: Ifdbff687539078b375330ebe3a1493b281e5c518
jenkins-bot [Sat, 24 Sep 2016 22:17:10 +0000 (22:17 +0000)]
Merge "Move RedisBagOStuff to /libs"
Aaron Schulz [Wed, 21 Sep 2016 23:13:14 +0000 (16:13 -0700)]
Move SwiftFileBackend to /libs
Change-Id: Ied0be9891d70930caf415d75cb3b89043347f47e
jenkins-bot [Sat, 24 Sep 2016 22:02:42 +0000 (22:02 +0000)]
Merge "Depedencency cleanups to SwiftFileBackend"
Translation updater bot [Sat, 24 Sep 2016 19:57:01 +0000 (21:57 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I8e5eec2c2187060941e25a6b7388beccda6ee562
Aaron Schulz [Sat, 24 Sep 2016 10:55:38 +0000 (03:55 -0700)]
Fix IDEA warnings in FileBackendStore
Change-Id: Icd0fa697645c9a315f49f22216b669c5288c1176
Aaron Schulz [Sat, 24 Sep 2016 10:34:14 +0000 (03:34 -0700)]
Fix IDEA warning in FSFileBackend
Change-Id: Ia46bffabde91fb22df11cf953c0199995a41cb91
Aaron Schulz [Sat, 24 Sep 2016 04:17:32 +0000 (21:17 -0700)]
Rename getSlavePos() => getReplicaPos()
All callers updated
Change-Id: Ieb87df1bd134e6b0d8b01be581288e98fe3543ee
Aaron Schulz [Fri, 23 Sep 2016 03:11:18 +0000 (20:11 -0700)]
Remove unused Database::isView()/clearViewsCache() methods
Also make getLazyMasterHandle() protected.
Change-Id: Id6b48ff976a800052c22e90b572695ab3b8beb7e
Aaron Schulz [Sat, 24 Sep 2016 03:13:36 +0000 (20:13 -0700)]
Move RedisBagOStuff to /libs
Change-Id: Ia49fb044aacb44e53d36c80277783cd806aca439
Aaron Schulz [Wed, 21 Sep 2016 23:12:27 +0000 (16:12 -0700)]
Depedencency cleanups to SwiftFileBackend
* Avoid wf* function MediaWiki dependencies.
* Don't bother with getLocalClusterInstance() caching for the CLI case.
* Give FileBackend a default 'resetOutputBuffer' callback.
Change-Id: I359da1ad77c62880ea799b65cd3a16ad673a64eb
jenkins-bot [Sat, 24 Sep 2016 01:33:14 +0000 (01:33 +0000)]
Merge "Move FSFilebackend and MemoryFileBackend to /libs"
jenkins-bot [Sat, 24 Sep 2016 01:13:44 +0000 (01:13 +0000)]
Merge "Make LoadBalancer return docs more specific about types"
Aaron Schulz [Fri, 23 Sep 2016 23:31:56 +0000 (16:31 -0700)]
Make LoadBalancer return docs more specific about types
Change-Id: Iab671b66a4a4da33c780b6d78752c484ec329254
jenkins-bot [Sat, 24 Sep 2016 00:23:05 +0000 (00:23 +0000)]
Merge "Clean up misuse of wfTimestampOrNull()"
Aaron Schulz [Wed, 21 Sep 2016 22:36:16 +0000 (15:36 -0700)]
Move FSFilebackend and MemoryFileBackend to /libs
Change-Id: Id38a2ef9e0e22537d0267b536f8a4dfd60c5b41d
Timo Tijhof [Fri, 23 Sep 2016 23:59:56 +0000 (00:59 +0100)]
Clean up misuse of wfTimestampOrNull()
It's primarily meant for nullable timestamps in the database.
And for the mere purpose of an is_null() check, it's more confusion
than useful to cause this function since in these two cases its return
value is not used as-is but further conditionalized.
* Also fix fragile link between getRegistration()'s false return
value never being passed to wfTimestamp (to mean "now") because
of the isLoggedIn() guard. The ternary would now make those
follow the 'else' branch toward null.
Change-Id: I9a1ee2a56e1767bfb750e27b1f37bdaeb5e6378d
jenkins-bot [Sat, 24 Sep 2016 00:01:13 +0000 (00:01 +0000)]
Merge "Remove wf* function usage from FSFileBackend"
jenkins-bot [Fri, 23 Sep 2016 23:41:20 +0000 (23:41 +0000)]
Merge "Avoid DatabaseBase type errors in setupDatabaseWithTestPrefix()"
Aaron Schulz [Fri, 23 Sep 2016 22:59:22 +0000 (15:59 -0700)]
Avoid DatabaseBase type errors in setupDatabaseWithTestPrefix()
Change-Id: I94cc0672a487d547a09c27997fe36274d7d62977
jenkins-bot [Fri, 23 Sep 2016 23:14:32 +0000 (23:14 +0000)]
Merge "Add transaction ticket to LinksUpdateComplete hook"
Aaron Schulz [Wed, 21 Sep 2016 22:34:46 +0000 (15:34 -0700)]
Remove wf* function usage from FSFileBackend
Change-Id: Iad6471724f8cdc596c755e6194da7556158e9203
jenkins-bot [Fri, 23 Sep 2016 22:52:46 +0000 (22:52 +0000)]
Merge "Move FileBackendStore and FileOp classes to /libs"
jenkins-bot [Fri, 23 Sep 2016 22:46:47 +0000 (22:46 +0000)]
Merge "SpecialRecentChanges: Allow tagfilter=tag as "subpage""
jenkins-bot [Fri, 23 Sep 2016 22:09:31 +0000 (22:09 +0000)]
Merge "Move RedisLockManager to /libs"
jenkins-bot [Fri, 23 Sep 2016 21:57:36 +0000 (21:57 +0000)]
Merge "Move RedisConnectionPool to /libs/redis"
Aaron Schulz [Sun, 18 Sep 2016 23:25:41 +0000 (16:25 -0700)]
Move FileBackendStore and FileOp classes to /libs
Change-Id: If490f64bec282e5dfcdaf7feb1cbf46d3dce1064
Aaron Schulz [Sun, 18 Sep 2016 23:07:34 +0000 (16:07 -0700)]
Remove wfDebugLog() dependency from FileOp classes
Change-Id: Ib8ab9edd1afdb28f7444f5e13cf34a696a066234
jenkins-bot [Fri, 23 Sep 2016 21:28:52 +0000 (21:28 +0000)]
Merge "Add HTTPFileStreamer class"
Aaron Schulz [Sun, 18 Sep 2016 22:49:34 +0000 (15:49 -0700)]
Add HTTPFileStreamer class
* Move most StreamFile code to this new class
* Remove StreamFile depedency from FileBackendStore
Change-Id: I4a272ef49497b589114fc2b37ba800bc26d9161f
jenkins-bot [Fri, 23 Sep 2016 21:08:57 +0000 (21:08 +0000)]
Merge "Move FileBackendMultiWrite to /libs"
jenkins-bot [Fri, 23 Sep 2016 20:58:20 +0000 (20:58 +0000)]
Merge "Revert "resourceloader: Make cache-eval in mw.loader.work asynchronous""
jenkins-bot [Fri, 23 Sep 2016 20:56:28 +0000 (20:56 +0000)]
Merge "mediawiki.js: Refactor definition of mw.log singleton"
jenkins-bot [Fri, 23 Sep 2016 20:49:36 +0000 (20:49 +0000)]
Merge "mw.loader: Use native Set where possible instead of string keys"
Krinkle [Wed, 21 Sep 2016 18:39:25 +0000 (18:39 +0000)]
Revert "resourceloader: Make cache-eval in mw.loader.work asynchronous"
This reverts commit
482ad8d9fb2e8273cefc4a5a557604b093944c8b.
Change-Id: Ic31463313b5a6d9720f0a5e036bb7200d3340021
jenkins-bot [Fri, 23 Sep 2016 20:37:59 +0000 (20:37 +0000)]
Merge "Add IMaintainableDatabase for non-OLTP type methods"
jenkins-bot [Fri, 23 Sep 2016 20:36:37 +0000 (20:36 +0000)]
Merge "Add ILBFactory interface for completeness"
Timo Tijhof [Fri, 23 Sep 2016 19:40:10 +0000 (20:40 +0100)]
mediawiki.js: Refactor definition of mw.log singleton
Move this out of the large plain object that defines 'mw' itself
because right now none of the mw object initialisation is able
to call mw.log.
In a future commit, a call to mw.log is introduced in the mw.Map()
constructor, which is also used to set the mw.messages, mw.templates
and mw.user.options fields.
* Rename the other log() function to avoid clashing.
* Update outdated comment about not using mw.log() which was
there about confusion between log() and mw.log(). However,
this code was updated long ago to use mw.track() instead of
log() directly, and log() has now been renamed.
Change-Id: I7d6bd4e3c9753e30278752c59d6cbd4d2fd10d96
jenkins-bot [Fri, 23 Sep 2016 20:32:15 +0000 (20:32 +0000)]
Merge "Add DBO_* class constants and defines.php alias the class constants"
Aaron Schulz [Fri, 23 Sep 2016 04:54:49 +0000 (21:54 -0700)]
Move FileBackendMultiWrite to /libs
Change-Id: I8079693a62db390028cd9f72b2bd7a81ae1164c3
L10n-bot [Fri, 23 Sep 2016 20:03:51 +0000 (20:03 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Translation updater bot [Fri, 23 Sep 2016 19:59:24 +0000 (21:59 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Iff900bc05ff000bd0c290d77ad20be6808b12fb0
Aaron Schulz [Fri, 23 Sep 2016 19:41:22 +0000 (12:41 -0700)]
Add DBO_* class constants and defines.php alias the class constants
Change-Id: If13b23ef849d4cf4c711b0ec2bf2e8a795f90738
Aaron Schulz [Sun, 18 Sep 2016 21:40:38 +0000 (14:40 -0700)]
Dependency cleanups to FileBackendStore
* Inject a PSR logger in place of wf* logging methods.
* Replace wfTimestamp() call with ConvertableTimestamp.
* Inject the Profiler object.
* Rename $wiki => $domain to avoid "wiki" mentions.
* Remove stray FSFile::extractImageSizeInfo() method.
Change-Id: I3e3a43d36506bec341dc5727b52f5f5a5d32bff5
Florian [Sat, 13 Aug 2016 18:23:40 +0000 (20:23 +0200)]
SpecialRecentChanges: Allow tagfilter=tag as "subpage"
This allows an url like example.com/wiki/Special:RecentChanges/tagfilter=visualeditor
to only show changes made with the VisualEditor (instead of using the long version
like index.php?title=Special:RecentChanges&tagfilter=visualeditor).
This also allows the transclusion of the Special:RecentChanges page with a tagfilter.
Bug: T142878
Change-Id: Iaa749a556ccc422e79fbb2bac709fab45b3cc83d
jenkins-bot [Fri, 23 Sep 2016 19:20:43 +0000 (19:20 +0000)]
Merge "Add alternative DB_* class constants to ILoadBalancer"
Aaron Schulz [Fri, 23 Sep 2016 06:10:20 +0000 (23:10 -0700)]
Add ILBFactory interface for completeness
Also fixed comment indentation.
Change-Id: I535d320b63477302b06fd634b3ab47eef6868ffc
jenkins-bot [Fri, 23 Sep 2016 18:58:51 +0000 (18:58 +0000)]
Merge "Make newExternalLB() public to match newMainLB()"
Aaron Schulz [Fri, 23 Sep 2016 18:54:28 +0000 (11:54 -0700)]
Avoid DB_MASTER use on password checks and defer password upgrades
Change-Id: Iceaafa31a5d8efcd9881b8a4a5c0e2aca1b1447c
Aaron Schulz [Fri, 23 Sep 2016 18:36:43 +0000 (11:36 -0700)]
Add alternative DB_* class constants to ILoadBalancer
Change-Id: I5d7e6d9f0f5bd4275e240a94b996f3740ef46330
jenkins-bot [Fri, 23 Sep 2016 15:25:11 +0000 (15:25 +0000)]
Merge "Add HTMLFormField class for MWRestrictions and use it for bot passwords"
jenkins-bot [Fri, 23 Sep 2016 15:18:12 +0000 (15:18 +0000)]
Merge "Log when Message::__toString has an unexpected format"
jenkins-bot [Fri, 23 Sep 2016 08:55:15 +0000 (08:55 +0000)]
Merge "ScopedCallback: Fix a typo in a comment"
Niklas Laxström [Fri, 23 Sep 2016 08:41:30 +0000 (10:41 +0200)]
ScopedCallback: Fix a typo in a comment
Change-Id: I6179f3b97fdf787c7175e8d7edf06cb2d84f7403
jenkins-bot [Fri, 23 Sep 2016 08:19:46 +0000 (08:19 +0000)]
Merge "Handle links with multiple pipes correctly in edit summaries"
Aaron Schulz [Mon, 19 Sep 2016 09:28:04 +0000 (02:28 -0700)]
Code comment and style cleanups to MysqlLockManager
Change-Id: Idf05c0c44f5f6fbb373625c0aebe015e385700ce
jenkins-bot [Fri, 23 Sep 2016 07:46:04 +0000 (07:46 +0000)]
Merge "Move tagging of API deletions to RC save"
Aaron Schulz [Fri, 23 Sep 2016 07:30:31 +0000 (00:30 -0700)]
Move RedisLockManager to /libs
Change-Id: Ia476f117243cf0f6984e373d460b24db18584704
Aaron Schulz [Fri, 23 Sep 2016 07:20:19 +0000 (00:20 -0700)]
Move RedisConnectionPool to /libs/redis
Change-Id: Ied4a85d7172ab76b90f6d9ce4d47a83c3fd7d111
jenkins-bot [Fri, 23 Sep 2016 06:16:11 +0000 (06:16 +0000)]
Merge "Ensure users are able to edit the page after changing the content model"
Aaron Schulz [Fri, 23 Sep 2016 05:24:08 +0000 (22:24 -0700)]
Make newExternalLB() public to match newMainLB()
Change-Id: I7e46c947882c5de6e4d25a7110c2a2558df7ad76
Aaron Schulz [Mon, 19 Sep 2016 08:06:45 +0000 (01:06 -0700)]
Move more LockManager classes to /libs
Change-Id: I4bfa79f430827b8717a57bb61cb7c36bc7fcb489
Kunal Mehta [Sun, 11 Sep 2016 05:14:04 +0000 (22:14 -0700)]
Ensure users are able to edit the page after changing the content model
It is possible for page restrictions to be dependent upon the content
model a page. The best example of this is user JavaScript and CSS
subpages. This adds a Title::setContentModel() function which allows
mocking a Title's content model for the purpose of permission checks.
EditPage and Special:ChangeContentModel were updated to ensure the user
can edit the page with the newly proposed content model before making
the change.
Title::$mContentModel was made private to make sure nothing else mucks
around with it. There were no uses outside of Title anyways.
Bug: T145316
Change-Id: I28c46f408cadf65ed1868401cd00dc15e5acd2fe
jenkins-bot [Fri, 23 Sep 2016 05:13:48 +0000 (05:13 +0000)]
Merge "Inject "srvCache" and local DB connections into LockManagerDB"
Aaron Schulz [Fri, 23 Sep 2016 03:46:16 +0000 (20:46 -0700)]
Add IMaintainableDatabase for non-OLTP type methods
Change-Id: I4cbdfd7a40af17269c527df6e1c3c5644672b8a7
jenkins-bot [Fri, 23 Sep 2016 03:55:04 +0000 (03:55 +0000)]
Merge "Call setTransactionTicket() on DeferredUpdates sub-queue items too"
Aaron Schulz [Fri, 23 Sep 2016 02:53:58 +0000 (19:53 -0700)]
Reduce queries in CategoryViewer via addGoodLinkObjFromRow()
Change-Id: Id782b50f166efbee6c9f8b9b263f09fc5fb5e3f2
Aaron Schulz [Fri, 23 Sep 2016 02:15:22 +0000 (19:15 -0700)]
Add transaction ticket to LinksUpdateComplete hook
This lets callers use commitAndWaitForReplication() more easily.
Change-Id: I743bd1f989b8fb3b7ba3e5cc8ce1bb44c00f99af
jenkins-bot [Fri, 23 Sep 2016 02:09:42 +0000 (02:09 +0000)]
Merge "Remove see comment"
jenkins-bot [Fri, 23 Sep 2016 00:36:40 +0000 (00:36 +0000)]
Merge "Rename includes/Services to includes/services for consistency"
jenkins-bot [Fri, 23 Sep 2016 00:35:47 +0000 (00:35 +0000)]
Merge "Revert "Move wfEscapeWikiText() to Parser::escapeWikitext()""
Legoktm [Fri, 23 Sep 2016 00:29:21 +0000 (00:29 +0000)]
Revert "Move wfEscapeWikiText() to Parser::escapeWikitext()"
Apparently it is possible for Parser::mParserOptions
to not be set in some cases. I'll try again later.
This reverts commit
bda74bff6e180b5a6bb2cc68e12ae391d53789a3.
Bug: T146433
Change-Id: Idb6d1b20995d5f86b712abb386ab987356c4f560
Reedy [Fri, 23 Sep 2016 00:20:50 +0000 (01:20 +0100)]
Remove see comment
Change-Id: I58fcd682dba6c778c0975baf67a6b87f36b1aff2
Reedy [Thu, 22 Sep 2016 23:35:52 +0000 (00:35 +0100)]
Rename includes/Services to includes/services for consistency
Change-Id: I900fab26a7cf5a339233f55c31168f8c2963bc8c
Aaron Schulz [Fri, 23 Sep 2016 00:03:51 +0000 (17:03 -0700)]
Call setTransactionTicket() on DeferredUpdates sub-queue items too
This should lower the rate of "does not have outer scope" log
warnings in DBPerformance.
Also add traces to such logs.
Change-Id: I7d21ea745cae07e0fbbe4cd8de82e93f1d10e0a5
jenkins-bot [Thu, 22 Sep 2016 23:14:34 +0000 (23:14 +0000)]
Merge "Support multiple limits and arbitrary periods in account creation throttle"
Timo Tijhof [Thu, 22 Sep 2016 23:07:54 +0000 (00:07 +0100)]
mw.loader: Use native Set where possible instead of string keys
Total time spent in sortDependencies
(Chrome Canary, unthrottled, MacBook Pro, MediaWiki-Vagrant)
* Before: 0.53ms
* After: 0.3ms
Bug: T146432
Change-Id: I65e2b0efbd080adab003b5c9605405ea0ae5380d
jenkins-bot [Thu, 22 Sep 2016 22:58:26 +0000 (22:58 +0000)]
Merge "Fix doc typo for wasConnectionError()"
jenkins-bot [Thu, 22 Sep 2016 22:54:02 +0000 (22:54 +0000)]
Merge "Split out new ObjectCache::newWANCacheFromParams() method"
jenkins-bot [Thu, 22 Sep 2016 22:35:16 +0000 (22:35 +0000)]
Merge "Simplify and clean up FileBackend exceptions"
Aaron Schulz [Wed, 21 Sep 2016 04:44:29 +0000 (21:44 -0700)]
Simplify and clean up FileBackend exceptions
Use standard exceptions for unexpected errors and remove
FileBackendException class, leaving FileBackendError. The
later is actually intended to be caught in some cases.
Change-Id: I735a525e0b14e518b2da5f18762e0f293064dfc2
Aaron Schulz [Thu, 22 Sep 2016 22:19:17 +0000 (15:19 -0700)]
Add DBConnRef sanity check to LoadBalancer::reuseConnection()
Change-Id: I6b079b994f29c5f7953efe73982ef9e6946a21f8
Aaron Schulz [Thu, 22 Sep 2016 22:09:55 +0000 (15:09 -0700)]
Fix doc typo for wasConnectionError()
Change-Id: I70eaeb630e2a4bb8f2940c2dcc938f7305014d48
jenkins-bot [Thu, 22 Sep 2016 22:05:25 +0000 (22:05 +0000)]
Merge "Make MigrateFileRepoLayout use getErrors()"
jenkins-bot [Thu, 22 Sep 2016 22:02:36 +0000 (22:02 +0000)]
Merge "Move wfEscapeWikiText() to Parser::escapeWikitext()"
Aaron Schulz [Wed, 21 Sep 2016 20:06:05 +0000 (13:06 -0700)]
Generalize core schema docs in DatabasePostgres
Change-Id: I52e64867c1533c50406623d5bc121c1e4da2459a
Gergő Tisza [Thu, 22 Sep 2016 19:44:07 +0000 (19:44 +0000)]
Log when Message::__toString has an unexpected format
Message formatting methods have a side effect on how string conversion
will work, which is a security problem waiting to happen:
$msg = new Message( 'foo' );
echo $msg; // parsed
echo $msg->plain();
echo $msg; // not parsed
This change logs Message -> string transformations which are
affected by a prior call in this way. The behavior will be removed
in a later patch (possibly replaced by something more explicit
if it turns out that something depends on it).
Bug: T146416
Change-Id: Id51cf6a5a937bc41a914f317e980ef42e4d385fb
jenkins-bot [Thu, 22 Sep 2016 21:29:44 +0000 (21:29 +0000)]
Merge "Break long lines and generalize some comments in /rdbms"
jenkins-bot [Thu, 22 Sep 2016 21:19:17 +0000 (21:19 +0000)]
Merge "Inject schema vars into DatabaseMysql"
Bartosz Dziewoński [Thu, 22 Sep 2016 21:14:29 +0000 (21:14 +0000)]
Merge "IcuCollation: Update comments on $tailoringFirstLetters"
Bartosz Dziewoński [Thu, 22 Sep 2016 21:14:23 +0000 (21:14 +0000)]
Merge "Correct error handling for exceptions in 'user' module"
Aaron Schulz [Wed, 21 Sep 2016 20:39:00 +0000 (13:39 -0700)]
Inject schema vars into DatabaseMysql
Also fix broken patchSql.php maintenance script
Change-Id: I45bccb0e2e10bd06651a551fa08ed0c66d11eb6a
jenkins-bot [Thu, 22 Sep 2016 21:05:56 +0000 (21:05 +0000)]
Merge "Remove old remapping hacks from Database::indexName()"