From: Daimona Eaytoy <daimona.wiki@gmail.com>
Date: Fri, 12 Apr 2019 09:17:57 +0000 (+0200)
Subject: DifferenceEngine: Use quickUserCan for display of rollback link
X-Git-Tag: 1.34.0-rc.0~310^2
X-Git-Url: https://git.cyclocoop.org/%20%27.%28%24debut%20%20%20%24par_page%29.%27?a=commitdiff_plain;h=cbf0404caa43b18059abe91c74c2d536286a83b6;p=lhc%2Fweb%2Fwiklou.git

DifferenceEngine: Use quickUserCan for display of rollback link

Title::userCan is too expensive for this, as it queries the master DB
just to decide whether a link should be shown.
The DBPerformance warning for this is seen roughly 8000 times per day on
logstash.

Bug: T232258
Change-Id: I33eab493273ed4790645e338c83993043e76e1d7
---

diff --git a/includes/diff/DifferenceEngine.php b/includes/diff/DifferenceEngine.php
index 7fcda4c728..8a5caa2dce 100644
--- a/includes/diff/DifferenceEngine.php
+++ b/includes/diff/DifferenceEngine.php
@@ -544,7 +544,7 @@ class DifferenceEngine extends ContextSource {
 			if ( $samePage && $this->mNewPage && $permissionManager->quickUserCan(
 				'edit', $user, $this->mNewPage
 			) ) {
-				if ( $this->mNewRev->isCurrent() && $permissionManager->userCan(
+				if ( $this->mNewRev->isCurrent() && $permissionManager->quickUserCan(
 					'rollback', $user, $this->mNewPage
 				) ) {
 					$rollbackLink = Linker::generateRollback( $this->mNewRev, $this->getContext(),