From: Ed Sanders <esanders@wikimedia.org>
Date: Fri, 14 Dec 2018 14:22:26 +0000 (+0000)
Subject: eslint: Turn on reportUnusedDisableDirectives
X-Git-Tag: 1.34.0-rc.0~3250^2
X-Git-Url: https://git.cyclocoop.org/%20%27.%28%24debut%20%20%20%24par_page%29.%27?a=commitdiff_plain;h=b61faa75a9359267828c59e13e18babee8bc1a5d;p=lhc%2Fweb%2Fwiklou.git

eslint: Turn on reportUnusedDisableDirectives

Change-Id: I3fb88324ba5a46e44041c13eb6447c8e33f4e79b
---

diff --git a/Gruntfile.js b/Gruntfile.js
index 6be908e087..707a1fb095 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -21,6 +21,9 @@ module.exports = function ( grunt ) {
 
 	grunt.initConfig( {
 		eslint: {
+			options: {
+				reportUnusedDisableDirectives: true
+			},
 			all: [
 				'**/*.js',
 				'!docs/**',
diff --git a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FilterGroup.js b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FilterGroup.js
index 9264a397f8..df2079e899 100644
--- a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FilterGroup.js
+++ b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FilterGroup.js
@@ -116,7 +116,7 @@
 
 				subsetNames = [];
 
-				filter.subset.forEach( function ( subsetFilterName ) { // eslint-disable-line no-loop-func
+				filter.subset.forEach( function ( subsetFilterName ) {
 					// Subsets (unlike conflicts) are always inside the same group
 					// We can re-map the names of the filters we are getting from
 					// the subsets with the group prefix
diff --git a/resources/src/startup/mediawiki.js b/resources/src/startup/mediawiki.js
index fee69c07bf..03f02b45af 100644
--- a/resources/src/startup/mediawiki.js
+++ b/resources/src/startup/mediawiki.js
@@ -99,7 +99,6 @@
 	 * @param {string} [data.module] Name of module which caused the error
 	 */
 	function logError( topic, data ) {
-		/* eslint-disable no-console */
 		var msg,
 			e = data.exception,
 			source = data.source,
@@ -120,7 +119,6 @@
 				console.warn( e );
 			}
 		}
-		/* eslint-enable no-console */
 	}
 
 	/**