From: Brad Jorsch <bjorsch@wikimedia.org>
Date: Fri, 16 Aug 2019 17:57:51 +0000 (-0400)
Subject: ActiveUsersPager: Fix outer GROUP BY
X-Git-Tag: 1.34.0-rc.0~697
X-Git-Url: https://git.cyclocoop.org/%20%27.%28%24debut%20%20%20%24par_page%29.%27?a=commitdiff_plain;h=8103d35f08e7ca27bae5e013fdf6cd21c3147e18;hp=94048ef7b6ac6ba4c6c7203a40976204cda2436b;p=lhc%2Fweb%2Fwiklou.git

ActiveUsersPager: Fix outer GROUP BY

MySQL doesn't care, but PG actually enforces rules about GROUP BY
columns.

Bug: T230618
Change-Id: If769db525bf53c906ad3e0e1d1a6e92194f622a8
---

diff --git a/includes/specials/pagers/ActiveUsersPager.php b/includes/specials/pagers/ActiveUsersPager.php
index 368c6d1828..7703e206fa 100644
--- a/includes/specials/pagers/ActiveUsersPager.php
+++ b/includes/specials/pagers/ActiveUsersPager.php
@@ -155,7 +155,7 @@ class ActiveUsersPager extends UsersPager {
 				'user_id' => 'user_id',
 				'recentedits' => 'COUNT(rc_id)'
 			],
-			'options' => [ 'GROUP BY' => [ 'qcc_title' ] ],
+			'options' => [ 'GROUP BY' => [ 'qcc_title', 'user_id' ] ],
 			'conds' => $conds,
 			'join_conds' => $jconds,
 		];