From: jenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Date: Sun, 3 Feb 2019 20:28:49 +0000 (+0000)
Subject: Merge "Add @coversNothing for left over tests and enable sniff"
X-Git-Tag: 1.34.0-rc.0~2954
X-Git-Url: https://git.cyclocoop.org/%20%27.%28%24debut%20%20%20%24par_page%29.%27?a=commitdiff_plain;h=800be73dc1bdde7809579dfb24c988e62a61c550;hp=-c;p=lhc%2Fweb%2Fwiklou.git

Merge "Add @coversNothing for left over tests and enable sniff"
---

800be73dc1bdde7809579dfb24c988e62a61c550
diff --combined .phpcs.xml
index 61307aa894,0940e7fa96..7548bdabf1
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@@ -11,7 -11,6 +11,6 @@@
  		<exclude name="MediaWiki.Commenting.IllegalSingleLineComment.IllegalSingleLineCommentStart" />
  		<exclude name="MediaWiki.Commenting.IllegalSingleLineComment.IllegalSingleLineCommentEnd" />
  		<exclude name="MediaWiki.ControlStructures.AssignmentInControlStructures.AssignmentInControlStructures" />
- 		<exclude name="MediaWiki.Commenting.MissingCovers.MissingCovers" />
  		<exclude name="MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName" />
  		<exclude name="MediaWiki.Usage.DbrQueryUsage.DbrQueryFound" />
  		<exclude name="MediaWiki.Usage.ForbiddenFunctions.passthru" />
@@@ -78,10 -77,13 +77,10 @@@
  			Whitelist existing violations, but enable the sniff to prevent
  			any new occurrences.
  		-->
 -		<exclude-pattern>*/includes/media/XCF\.php</exclude-pattern>
  		<exclude-pattern>*/includes/Feed\.php</exclude-pattern>
 -		<exclude-pattern>*/includes/libs/xmp/XMP\.php</exclude-pattern>
  		<exclude-pattern>*/includes/jobqueue/JobSpecification\.php</exclude-pattern>
  		<exclude-pattern>*/includes/RevisionList\.php</exclude-pattern>
  		<exclude-pattern>*/includes/installer/PhpBugTests\.php</exclude-pattern>
 -		<exclude-pattern>*/includes/exception/LocalizedException\.php</exclude-pattern>
  		<exclude-pattern>*/includes/specials/SpecialMostinterwikis\.php</exclude-pattern>
  		<exclude-pattern>*/includes/cache/CacheDependency\.php</exclude-pattern>
  		<exclude-pattern>*/includes/cache/CacheHelper\.php</exclude-pattern>
@@@ -173,12 -175,8 +172,12 @@@
  		<exclude-pattern>*/profileinfo\.php</exclude-pattern>
  		<!-- Language converters use the pattern of 2 classes in one file -->
  		<exclude-pattern>*/languages/*\.php</exclude-pattern>
 -		<!-- We don't care that much about violations in tests -->
 -		<exclude-pattern>*/tests/*\.php</exclude-pattern>
 +		<!-- Skip violations in some tests for now -->
 +		<exclude-pattern>*/tests/parser/*\.php</exclude-pattern>
 +		<exclude-pattern>*/tests/phan/*\.php</exclude-pattern>
 +		<exclude-pattern>*/tests/phpunit/maintenance/*\.php</exclude-pattern>
 +		<exclude-pattern>*/tests/phpunit/bootstrap\.php</exclude-pattern>
 +		<exclude-pattern>*/tests/phpunit/phpunit\.php</exclude-pattern>
  	</rule>
  	<rule ref="MediaWiki.Files.ClassMatchesFilename.WrongCase">
  		<!--
@@@ -209,9 -207,8 +208,9 @@@
  		<exclude-pattern>*/maintenance/storage/checkStorage\.php</exclude-pattern>
  		<exclude-pattern>*/maintenance/storage/recompressTracked\.php</exclude-pattern>
  		<exclude-pattern>*/maintenance/storage/trackBlobs\.php</exclude-pattern>
 -		<!-- We don't care that much about violations in tests -->
 -		<exclude-pattern>*/tests/*\.php</exclude-pattern>
 +		<!-- Skip violations in some tests for now -->
 +		<exclude-pattern>*/tests/phpunit/includes/GlobalFunctions/*\.php</exclude-pattern>
 +		<exclude-pattern>*/tests/phpunit/maintenance/*\.php</exclude-pattern>
  	</rule>
  
  	<rule ref="Generic.Files.OneObjectStructurePerFile.MultipleFound">
@@@ -225,6 -222,7 +224,6 @@@
  		<exclude-pattern>*/includes/api/ApiMessage\.php</exclude-pattern>
  		<exclude-pattern>*/includes/api/ApiOpenSearch\.php</exclude-pattern>
  		<exclude-pattern>*/includes/api/ApiRsd\.php</exclude-pattern>
 -		<exclude-pattern>*/includes/api/ApiUsageException\.php</exclude-pattern>
  		<exclude-pattern>*/includes/AuthPlugin\.php</exclude-pattern>
  		<exclude-pattern>*/includes/cache/CacheDependency\.php</exclude-pattern>
  		<exclude-pattern>*/includes/cache/CacheHelper\.php</exclude-pattern>
@@@ -232,6 -230,7 +231,6 @@@
  		<exclude-pattern>*/includes/deferred/CdnCacheUpdate\.php</exclude-pattern>
  		<exclude-pattern>*/includes/diff/DairikiDiff\.php</exclude-pattern>
  		<exclude-pattern>*/includes/diff/DiffEngine\.php</exclude-pattern>
 -		<exclude-pattern>*/includes/exception/LocalizedException\.php</exclude-pattern>
  		<exclude-pattern>*/includes/Feed\.php</exclude-pattern>
  		<exclude-pattern>*/includes/filerepo/file/LocalFile\.php</exclude-pattern>
  		<exclude-pattern>*/includes/gallery/PackedOverlayImageGallery\.php</exclude-pattern>
@@@ -296,6 -295,14 +295,6 @@@
  		<exclude-pattern>*/includes/libs/filebackend/FSFileBackend\.php</exclude-pattern>
  		<exclude-pattern>*/includes/shell/Command\.php</exclude-pattern>
  		<exclude-pattern>*/includes/shell/Shell\.php</exclude-pattern>
 -		<exclude-pattern>*/tests/phpunit/structure/StructureTest\.php</exclude-pattern>
 -	</rule>
 -	<rule ref="MediaWiki.Usage.ForbiddenFunctions.exec">
 -		<!--
 -			Whitelist existing violations, but enable the sniff to prevent
 -			any new occurrences.
 -		-->
 -		<exclude-pattern>*/tests/phpunit/structure/StructureTest\.php</exclude-pattern>
  	</rule>
  	<rule ref="MediaWiki.Usage.ForbiddenFunctions.popen">
  		<!--