Merge "skins: Skin::getSkinNameMessages() method is now deprecated"

diff --git a/RELEASE-NOTES-1.34 b/RELEASE-NOTES-1.34
index 932122d..f7790cb 100644 (file)
--- a/RELEASE-NOTES-1.34
+++ b/RELEASE-NOTES-1.34
@@ -476,6 +476,7 @@ because of Phabricator reports.
   SearchResult::newFromTitle(). This class is being refactored into an abstract
   class. If you extend this class please be sure to override all its methods
   or extend RevisionSearchResult.
+* Skin::getSkinNameMessages() is deprecated and no longer used.
 
 === Other changes in 1.34 ===
 * …

diff --git a/includes/skins/Skin.php b/includes/skins/Skin.php
index 6ec7cb2..212ac47 100644 (file)
--- a/includes/skins/Skin.php
+++ b/includes/skins/Skin.php
@@ -61,9 +61,11 @@ abstract class Skin extends ContextSource {
 
        /**
         * Fetch the skinname messages for available skins.
+        * @deprecated since 1.34, no longer used.
         * @return string[]
         */
        static function getSkinNameMessages() {
+               wfDeprecated( __METHOD__, '1.34' );
                $messages = [];
                foreach ( self::getSkinNames() as $skinKey => $skinName ) {
                        $messages[] = "skinname-$skinKey";