Merge "resourceloader: Improve coverage of SkinModule"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Fri, 4 May 2018 17:41:17 +0000 (17:41 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Fri, 4 May 2018 17:41:17 +0000 (17:41 +0000)
includes/resourceloader/ResourceLoaderSkinModule.php
tests/phpunit/includes/resourceloader/ResourceLoaderSkinModuleTest.php

index fbd0a24..de25d32 100644 (file)
@@ -93,6 +93,9 @@ class ResourceLoaderSkinModule extends ResourceLoaderFileModule {
        }
 
        /**
+        * Non-static proxy to ::getLogo (for overloading in sub classes or tests).
+        *
+        * @codeCoverageIgnore
         * @since 1.31
         * @param Config $conf
         * @return string|array
index a1b1422..61ab8a5 100644 (file)
@@ -71,8 +71,7 @@ CSS
 
        /**
         * @dataProvider provideGetStyles
-        * @covers ResourceLoaderSkinModule::normalizeStyles
-        * @covers ResourceLoaderSkinModule::getStyles
+        * @covers ResourceLoaderSkinModule
         */
        public function testGetStyles( $parent, $logo, $expected ) {
                $module = $this->getMockBuilder( ResourceLoaderSkinModule::class )