Merge "SpecialNewpages: Preserve values of show/hide links on form submission"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Wed, 1 Aug 2018 20:09:07 +0000 (20:09 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Wed, 1 Aug 2018 20:09:07 +0000 (20:09 +0000)
1  2 
includes/specials/SpecialNewpages.php

@@@ -189,13 -189,6 +189,13 @@@ class SpecialNewpages extends Includabl
                $changed = $this->opts->getChangedValues();
                unset( $changed['offset'] ); // Reset offset if query type changes
  
 +              // wfArrayToCgi(), called from LinkRenderer/Title, will not output null and false values
 +              // to the URL, which would omit some options (T158504). Fix it by explicitly setting them
 +              // to 0 or 1.
 +              $changed = array_map( function ( $value ) {
 +                      return $value ? '1' : '0';
 +              }, $changed );
 +
                $self = $this->getPageTitle();
                $linkRenderer = $this->getLinkRenderer();
                foreach ( $filters as $key => $msg ) {
                                'div',
                                null,
                                $this->filterLinks()
-                       ) )
+                       ) . $hidden )
                        ->show();
                $out->addModuleStyles( 'mediawiki.special' );
        }