Merge "RCFilters: HTML-escape tag names in filter capsules"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Wed, 1 Nov 2017 15:53:41 +0000 (15:53 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Wed, 1 Nov 2017 15:53:41 +0000 (15:53 +0000)
resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.ItemModel.js

index d940321..2b5d020 100644 (file)
         * Get a prefixed label
         *
         * @param {boolean} inverted This item should be considered inverted
-        * @return {string} Prefixed label
+        * @return {string} Prefixed label (HTML)
         */
        mw.rcfilters.dm.ItemModel.prototype.getPrefixedLabel = function ( inverted ) {
+               var escapedLabel = mw.html.escape( this.getLabel() );
                if ( this.labelPrefixKey ) {
                        if ( typeof this.labelPrefixKey === 'string' ) {
-                               return mw.message( this.labelPrefixKey, this.getLabel() ).parse();
+                               return mw.message( this.labelPrefixKey, escapedLabel ).parse();
                        } else {
                                return mw.message(
                                        this.labelPrefixKey[
                                                inverted && this.isSelected() ?
                                                        'inverted' : 'default'
                                        ],
-                                       this.getLabel()
+                                       escapedLabel
                                ).parse();
                        }
                } else {
-                       return this.getLabel();
+                       return escapedLabel;
                }
        };