These don't add any knowledge to what is already obvious from the
code, I find.
Change-Id: Ia613b6a059f78dbeefdfd020899bd1a6e239a731
12 files changed:
$lbFactory->rollbackMasterChanges( __METHOD__ );
}
} else {
$lbFactory->rollbackMasterChanges( __METHOD__ );
}
} else {
- // Done; nothing changed
$dbw->endAtomic( __METHOD__ );
}
}
$dbw->endAtomic( __METHOD__ );
}
}
// TODO: move to storage service
$newid = $wikiPage->insertOn( $dbw );
if ( $newid === false ) {
// TODO: move to storage service
$newid = $wikiPage->insertOn( $dbw );
if ( $newid === false ) {
- $dbw->endAtomic( __METHOD__ ); // nothing inserted
+ $dbw->endAtomic( __METHOD__ );
$status->fatal( 'edit-already-exists' );
$status->fatal( 'edit-already-exists' );
- return $status; // nothing done
}
// At this point we are now comitted to returning an OK
}
// At this point we are now comitted to returning an OK
if ( empty( $restrictionsToRemove ) ) {
continue;
}
if ( empty( $restrictionsToRemove ) ) {
continue;
}
return self::intermediateEditsMsg( $nEdits, $numUsers, $limit );
}
return self::intermediateEditsMsg( $nEdits, $numUsers, $limit );
}
*/
public function addRelations( $field, $values, $logid ) {
if ( !strlen( $field ) || empty( $values ) ) {
*/
public function addRelations( $field, $values, $logid ) {
if ( !strlen( $field ) || empty( $values ) ) {
- return false; // nothing
$this->output( "done.\n" );
}
$this->output( "done.\n" );
}
$this->commitTransaction( $dbw, __METHOD__ );
}
$this->commitTransaction( $dbw, __METHOD__ );
}
]
);
if ( !$rows || $rows->numRows() <= 0 ) {
]
);
if ( !$rows || $rows->numRows() <= 0 ) {
]
);
if ( !$rows || $rows->numRows() <= 0 ) {
]
);
if ( !$rows || $rows->numRows() <= 0 ) {
break;
}
foreach ( $rows as $row ) {
break;
}
foreach ( $rows as $row ) {
$numRows = $res->numRows();
$total += $numRows;
if ( $res->numRows() <= 0 ) {
$numRows = $res->numRows();
$total += $numRows;
if ( $res->numRows() <= 0 ) {
$this->output( "DONE! (handled $total entries)\n" );
break;
}
$this->output( "DONE! (handled $total entries)\n" );
break;
}
$this->output( "done.\n" );
}
$this->output( "done.\n" );
}
# Purge redundant text records
$this->commitTransaction( $dbw, __METHOD__ );
if ( $delete ) {
# Purge redundant text records
$this->commitTransaction( $dbw, __METHOD__ );
if ( $delete ) {
$props,
$timestamp
)->isOK() ) {
$props,
$timestamp
)->isOK() ) {
$this->output( "done.\n" );
$doProtect = false;
$this->output( "done.\n" );
$doProtect = false;
$this->assertEquals( false, $this->backend->fileExists( [ 'src' => $dest ] ),
"Destination file $dest does not exist ($backendName)." );
$this->assertEquals( false, $this->backend->fileExists( [ 'src' => $dest ] ),
"Destination file $dest does not exist ($backendName)." );
}
$status = $this->backend->doOperation(
}
$status = $this->backend->doOperation(
$this->assertEquals( false, $this->backend->fileExists( [ 'src' => $dest ] ),
"Destination file $dest does not exist ($backendName)." );
$this->assertEquals( false, $this->backend->fileExists( [ 'src' => $dest ] ),
"Destination file $dest does not exist ($backendName)." );
}
$status = $this->backend->doOperation(
}
$status = $this->backend->doOperation(