From dc889b93340fe5c4e4b35f1360cb38d9261cc371 Mon Sep 17 00:00:00 2001 From: Yuri Astrakhan Date: Thu, 7 Mar 2013 15:31:43 -0500 Subject: [PATCH] Two typo-bugs, credits update * ApiMain::addFormat() had a missed bug for custom formatters. * ApiPageSet used incorrect variable * Marked Roan as leading until 2009 (per IRC discussion) * Updated my involvement to present Change-Id: I5964bcdd3f82fedad06732df39f420796abe972b --- includes/api/ApiMain.php | 6 +++--- includes/api/ApiPageSet.php | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/includes/api/ApiMain.php b/includes/api/ApiMain.php index 7053ef37f0..215bdac96f 100644 --- a/includes/api/ApiMain.php +++ b/includes/api/ApiMain.php @@ -1118,11 +1118,11 @@ class ApiMain extends ApiBase { protected function getCredits() { return array( 'API developers:', - ' Roan Kattouw ".@gmail.com" (lead developer Sep 2007-present)', + ' Roan Kattouw ".@gmail.com" (lead developer Sep 2007-2009)', ' Victor Vasiliev - vasilvv at gee mail dot com', ' Bryan Tong Minh - bryan . tongminh @ gmail . com', ' Sam Reed - sam @ reedyboy . net', - ' Yuri Astrakhan "@gmail.com" (creator, lead developer Sep 2006-Sep 2007, 2012)', + ' Yuri Astrakhan "@gmail.com" (creator, lead developer Sep 2006-Sep 2007, 2012-present)', '', 'Please send your comments, suggestions and questions to mediawiki-api@lists.wikimedia.org', 'or file a bug report at https://bugzilla.wikimedia.org/' @@ -1276,7 +1276,7 @@ class ApiMain extends ApiBase { * @param $class ApiFormatBase The class implementing this format. */ protected function addFormat( $name, $class ) { - $this->getModuleManager->addModule( $name, 'format', $class ); + $this->getModuleManager()->addModule( $name, 'format', $class ); } /** diff --git a/includes/api/ApiPageSet.php b/includes/api/ApiPageSet.php index acf0b0c583..2cc90744ae 100644 --- a/includes/api/ApiPageSet.php +++ b/includes/api/ApiPageSet.php @@ -897,7 +897,7 @@ class ApiPageSet extends ApiBase { } if ( !$titleObj ) { // Handle invalid titles gracefully - $this->mAllpages[0][$title] = $this->mFakePageId; + $this->mAllPages[0][$title] = $this->mFakePageId; $this->mInvalidTitles[$this->mFakePageId] = $title; $this->mFakePageId--; continue; // There's nothing else we can do -- 2.20.1