From 970e9e3b5c94fa7082cabd4e421db2a55ecc2d7d Mon Sep 17 00:00:00 2001 From: Brion Vibber Date: Wed, 21 Dec 2011 19:17:39 +0000 Subject: [PATCH] Code style: move a couple htmlspecialchars() down to usage so it's clear where escaping happens --- includes/specials/SpecialUndelete.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/includes/specials/SpecialUndelete.php b/includes/specials/SpecialUndelete.php index 62f32454fb..9ed20f33cd 100644 --- a/includes/specials/SpecialUndelete.php +++ b/includes/specials/SpecialUndelete.php @@ -1267,14 +1267,14 @@ class SpecialUndelete extends SpecialPage { */ function getPageLink( $rev, $titleObj, $ts ) { $user = $this->getUser(); - $time = htmlspecialchars( $this->getLanguage()->userTimeAndDate( $ts, $user ) ); + $time = $this->getLanguage()->userTimeAndDate( $ts, $user ); if( !$rev->userCan( Revision::DELETED_TEXT, $user ) ) { return '' . $time . ''; } else { $link = Linker::linkKnown( $titleObj, - $time, + htmlspecialchars( $time ), array(), array( 'target' => $this->mTargetObj->getPrefixedText(), @@ -1296,14 +1296,14 @@ class SpecialUndelete extends SpecialPage { */ function getFileLink( $file, $titleObj, $ts, $key ) { $user = $this->getUser(); - $time = htmlspecialchars( $this->getLanguage()->userTimeAndDate( $ts, $user ) ); + $time = $this->getLanguage()->userTimeAndDate( $ts, $user ); if( !$file->userCan( File::DELETED_FILE, $user ) ) { return '' . $time . ''; } else { $link = Linker::linkKnown( $titleObj, - $time, + htmlspecialchars( $time ), array(), array( 'target' => $this->mTargetObj->getPrefixedText(), -- 2.20.1