From 8a604b68b0496e5c31acacc7f44d02bb322e5d96 Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Fri, 2 Feb 2018 19:30:48 -0800 Subject: [PATCH] rdbms: turn LoadBalancer waitTimeout default into a class constant Change-Id: Icd1e1aba1c45cb79a8249a9e16dce16f1c8183d2 --- includes/libs/rdbms/loadbalancer/LoadBalancer.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/includes/libs/rdbms/loadbalancer/LoadBalancer.php b/includes/libs/rdbms/loadbalancer/LoadBalancer.php index 864e6f0a3c..a3361cd9b7 100644 --- a/includes/libs/rdbms/loadbalancer/LoadBalancer.php +++ b/includes/libs/rdbms/loadbalancer/LoadBalancer.php @@ -122,6 +122,8 @@ class LoadBalancer implements ILoadBalancer { /** @var int Default 'maxLag' when unspecified */ const MAX_LAG_DEFAULT = 10; + /** @var int Default 'waitTimeout' when unspecified */ + const MAX_WAIT_DEFAULT = 10; /** @var int Seconds to cache master server read-only status */ const TTL_CACHE_READONLY = 5; @@ -151,7 +153,9 @@ class LoadBalancer implements ILoadBalancer { : DatabaseDomain::newUnspecified(); $this->setLocalDomain( $localDomain ); - $this->mWaitTimeout = isset( $params['waitTimeout'] ) ? $params['waitTimeout'] : 10; + $this->mWaitTimeout = isset( $params['waitTimeout'] ) + ? $params['waitTimeout'] + : self::MAX_WAIT_DEFAULT; $this->mReadIndex = -1; $this->mConns = [ -- 2.20.1