From 32deedecf359bd0ad38e37c8c7e89bf1d0189028 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Wed, 18 May 2016 20:54:49 +0100 Subject: [PATCH] tests: Remove duplicate unit tests in HtmlTest.php Follows-up ee4d5c6ee ("Remove support for $wgWellFormedXml = false") Remove now-redundant duplicate tests that were previously there to test the same thing again with $wgWellFormedXml set to false. Change-Id: I91623a8c10e5108ffae13f67328aece2cf33c719 --- tests/phpunit/includes/HtmlTest.php | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/tests/phpunit/includes/HtmlTest.php b/tests/phpunit/includes/HtmlTest.php index a01f2f5c5b..47217939bf 100644 --- a/tests/phpunit/includes/HtmlTest.php +++ b/tests/phpunit/includes/HtmlTest.php @@ -46,7 +46,7 @@ class HtmlTest extends MediaWikiTestCase { $this->assertEquals( '', Html::element( 'img', null, '' ), - 'No close tag for short-tag elements' + 'Self-closing tag for short-tag elements' ); $this->assertEquals( @@ -60,12 +60,6 @@ class HtmlTest extends MediaWikiTestCase { Html::element( 'element', [], '' ), 'Close tag for empty element (array, string)' ); - - $this->assertEquals( - '', - Html::element( 'img', null, '' ), - 'Self-closing tag for short-tag elements' - ); } public function dataXmlMimeType() { @@ -140,12 +134,6 @@ class HtmlTest extends MediaWikiTestCase { Html::expandAttributes( [ 'selected' ] ), 'Boolean attributes have no value when value is true (passed as numerical array)' ); - - $this->assertEquals( - ' selected=""', - Html::expandAttributes( [ 'selected' => true ] ), - 'Boolean attributes have empty string value when value is true' - ); } /** -- 2.20.1