From 279281b94a4cab497318d5a41ae6e248ed93b329 Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Wed, 13 Jan 2016 13:50:18 -0800 Subject: [PATCH] Avoid races on null revision insertion Bug: T51581 Change-Id: I7bfa9a4b20458e76ab3c4659e7041cd68aac13a4 --- includes/Revision.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/includes/Revision.php b/includes/Revision.php index 1d7ac72542..9373e4009a 100644 --- a/includes/Revision.php +++ b/includes/Revision.php @@ -1628,8 +1628,10 @@ class Revision implements IDBAccessObject { array( 'page_id' => $pageId, 'page_latest=rev_id', - ), - __METHOD__ ); + ), + __METHOD__, + array( 'FOR UPDATE' ) // T51581 + ); if ( $current ) { if ( !$user ) { -- 2.20.1