Aaron Schulz [Tue, 6 Oct 2015 18:10:33 +0000 (11:10 -0700)]
Remove begin/commit from recordOldUpload()
* The only caller already has has transaction via lock/unlock
and does the file operations first (avoiding contention)
* Also made recordOldUpload() protected
Change-Id: Ib03ca76895a181ed513a289e2b44f6b97e4a1bc0
jenkins-bot [Wed, 7 Oct 2015 02:18:43 +0000 (02:18 +0000)]
Merge "Fix AssembleUploadChunksJob/PublishStashedFileJob IDEA errors"
jenkins-bot [Wed, 7 Oct 2015 02:01:34 +0000 (02:01 +0000)]
Merge "Lower CDN cache TTL when slave lag is high"
Aaron Schulz [Tue, 6 Oct 2015 05:39:37 +0000 (22:39 -0700)]
Update more docs and type hints to use IDatabase
Change-Id: I8c8d85b32a8aba21e14d2a2dde4c25eb509186c1
Aaron Schulz [Thu, 1 Oct 2015 07:24:18 +0000 (00:24 -0700)]
Lower CDN cache TTL when slave lag is high
* $wgCdnMaxageLagged controls exactly what that TTL is
and the usual "max lag" settings determine what "high"
is for lag (which already makes the site read-only).
* This helps avoids stale content getting stuck in CDN
for a month just because a slave was lagged for a minute.
Of course race conditions with normal slave lag and WAN
cache relay purges can still lead to this problem, though
the scope of it is reduced.
Bug: T113204
Change-Id: I7ff0a8d88665f4e557566e7b412e75edee2627fe
jenkins-bot [Wed, 7 Oct 2015 01:40:34 +0000 (01:40 +0000)]
Merge "Enforce lagged-slave read-only mode on the DB layer"
Ori Livneh [Mon, 5 Oct 2015 23:10:56 +0000 (16:10 -0700)]
Add MemoizedCallable for APC-backed function memoization
Add a simple class to `libs/` for memoizing functions by caching return values
in APC. I decided not to make this an external library just yet because I see
this as potentially a part of a larger functional programming library.
Doesn't use APCBagOStuff for two reasons: (1) avoid dependency on MediaWiki
code; (2) ability to pass third &$success parameter to apc_store, to
distinguish between cache misses and cached false values.
Use this in ResourceLoaderFileModule to cache CSSMin::remap.
Change-Id: I00a47983a2583655d4631ecc9c6ba17597e36b5f
jenkins-bot [Tue, 6 Oct 2015 23:15:58 +0000 (23:15 +0000)]
Merge "Restore "userAgent" MultiHttpClient constructor override"
Aaron Schulz [Tue, 6 Oct 2015 22:26:59 +0000 (15:26 -0700)]
Restore "userAgent" MultiHttpClient constructor override
This is more convenient than needing to set it on each
HTTP request. Also, it is still documented as being there.
Change-Id: I246c9c3861d72701c844200b82d1a38a0c301795
jenkins-bot [Tue, 6 Oct 2015 22:12:16 +0000 (22:12 +0000)]
Merge "Fix duplicate automatic file backend bug"
Aaron Schulz [Tue, 6 Oct 2015 21:43:12 +0000 (14:43 -0700)]
Fix duplicate automatic file backend bug
Follow-up
8a3816529a
Bug: T114810
Change-Id: I2706c90077627b3df35fe530e0a919cfd0a75d78
jenkins-bot [Tue, 6 Oct 2015 21:29:25 +0000 (21:29 +0000)]
Merge "Change getCacheSetOptions() callers to use "Database""
jenkins-bot [Tue, 6 Oct 2015 21:09:51 +0000 (21:09 +0000)]
Merge "Add UserMailerTransformX and UserMailerSplitTo hooks"
jenkins-bot [Tue, 6 Oct 2015 21:00:37 +0000 (21:00 +0000)]
Merge "Defer execution of HTMLCacheUpdate instances"
Aaron Schulz [Tue, 6 Oct 2015 20:50:04 +0000 (13:50 -0700)]
Fix AssembleUploadChunksJob/PublishStashedFileJob IDEA errors
* Use getMessage() on the Exception objects
* Use a dummy WebRequestUpload to pass to continueChunks()
instead of an object of a completely wrong type
Change-Id: I01ec5c141a6f37ee425af3236d728b9128b98522
jenkins-bot [Tue, 6 Oct 2015 20:35:26 +0000 (20:35 +0000)]
Merge "Remove ORM use from DBSiteStore"
Aaron Schulz [Tue, 6 Oct 2015 20:31:31 +0000 (13:31 -0700)]
Defer execution of HTMLCacheUpdate instances
None of these places need it to happen right now,
so for performance and consistent style, defer
them too.
Change-Id: Id0a2a352bfc04a783c3ebc54b059b241bb6a6f7e
Gergő Tisza [Thu, 1 Oct 2015 03:05:23 +0000 (03:05 +0000)]
Add UserMailerTransformX and UserMailerSplitTo hooks
UserMailerTransformContent allows extensions to change the body of
an email sent via UserMailer::send(). This is applied before
low-level transformations such as multipart or content encoding.
UserMailerTransformMessage is similar but it is run after those
transformations.
UserMailerSplitTo allows extensions to request that a certain
user should always be emailed separately (so when UserMailer::send()
is called with an array of target addresses, that user will be split
out into a separate call). This is intended for content
transformations which need to be different per user, such as
encryption.
A side effect is that while before a call to UserMailer::send() was
either fully succeeded or fully failed, now the message might be
delivered to some targets but not others. send() will return a failed
Status object in those cases.
Bug: T12453
Change-Id: I4c3a018110173c3b5d52a753fdcbec397b590ced
Brad Jorsch [Tue, 6 Oct 2015 17:08:56 +0000 (13:08 -0400)]
Remove ORM use from DBSiteStore
This loses something of the genericity of the former DBSiteStore (i.e.
it's now tied to MediaWiki's database and sites table, and subclasses
and users can't easily override that), but nothing in core or extensions
in Gerrit was using that genericity so it's probably no big loss.
Further, T113034 (an RFC to actually use this 'site' stuff for its
original purpose) proposes getting rid of SiteStore anyway.
Bug: T114538
Change-Id: I7e7ca257451e6307a7e5bb11fd393283d0d19e77
jenkins-bot [Tue, 6 Oct 2015 20:15:32 +0000 (20:15 +0000)]
Merge "MultiHttpClient: Don't use "MW" in User-Agent"
Timo Tijhof [Tue, 6 Oct 2015 19:45:03 +0000 (12:45 -0700)]
MultiHttpClient: Don't use "MW" in User-Agent
Follows-up
6f51037d680ce.
Change-Id: I5e404c3a6ab9c3d1126676ee5fc22149422aa51f
jenkins-bot [Tue, 6 Oct 2015 19:51:05 +0000 (19:51 +0000)]
Merge "Remove double load of mediawiki.action.view.filepage"
Translation updater bot [Tue, 6 Oct 2015 19:45:39 +0000 (21:45 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I2ea395b34db5dde21a7c7024fe8dd3b410350a44
umherirrender [Fri, 4 Sep 2015 15:30:17 +0000 (17:30 +0200)]
Remove double load of mediawiki.action.view.filepage
To be merged 30 days after I8a0f0fecc53967bf2b0241ce92bbbd10b8fc704a is
deployed (should be 1.26wmf22)
Change-Id: I61d53080beceff2d8aac06c617035135557e4c47
jenkins-bot [Tue, 6 Oct 2015 19:20:45 +0000 (19:20 +0000)]
Merge "Revert "Remove mismatched COMMIT from FileDeleteForm""
Aaron Schulz [Tue, 6 Oct 2015 19:06:26 +0000 (19:06 +0000)]
Revert "Remove mismatched COMMIT from FileDeleteForm"
The doDeleteArticleReal() call does BEGIN but not COMMIT
and the LocalFile::delete() does no trx commands because
trxLevel() > 0, so the COMMIT here is needed as things are.
This reverts commit
985a8f721459ebea1dc5a0daa178295eec8cf444.
Change-Id: I72529965ae9fe41641f22af12a40ec13ff65a2c1
jenkins-bot [Tue, 6 Oct 2015 18:29:31 +0000 (18:29 +0000)]
Merge "Add more test cases to OldChangesListTest"
umherirrender [Sat, 3 Oct 2015 18:52:31 +0000 (20:52 +0200)]
Enable PSR2.Methods.MethodDeclaration.Underscore
Whitelist StubObject because the underscore is for internal use.
Change-Id: I4beeee8df8cde079b810a372539e3c169e80f2d3
jenkins-bot [Tue, 6 Oct 2015 16:20:57 +0000 (16:20 +0000)]
Merge "Sort MWNamespace::getValidNamespaces list numerically"
aude [Mon, 1 Sep 2014 10:23:15 +0000 (12:23 +0200)]
Add more test cases to OldChangesListTest
* test for watchlist css class
* test for number of watching users
Change-Id: I6aea1f5b8479ac3656f0ba27ebfa3800d9bffb4c
Amir E. Aharoni [Sun, 27 Sep 2015 07:27:49 +0000 (10:27 +0300)]
Reenable LineLength phpcs check
Bug: T102614
Change-Id: If853510b55d787765a84bac22b2dbff2e6c526c0
Amir E. Aharoni [Tue, 6 Oct 2015 13:04:32 +0000 (16:04 +0300)]
Fix long line to make phpcs pass
Bug: T102614
Change-Id: I2b14938366a8cc0e911f98ebb0d3e31f0fd31899
Aaron Schulz [Tue, 6 Oct 2015 05:41:05 +0000 (22:41 -0700)]
Added @since to Database
Change-Id: Ia4396317bb3c78ab6b60ecbf0e1825e44ed08589
Aaron Schulz [Tue, 6 Oct 2015 05:06:46 +0000 (22:06 -0700)]
Change getCacheSetOptions() callers to use "Database"
* This is less verbose that DatabaseBase
* Also add a few WAN cache doc comments
Change-Id: I5b6de6d0ffa06753ea96c50b63db7dae796475dc
Tim Starling [Tue, 6 Oct 2015 01:07:29 +0000 (12:07 +1100)]
Add User-Agent support to MultiHttpClient requests
Because it is polite to send a User-Agent (and as part of T114558
investigation).
Change-Id: I5096896d0891c0c9674ff8b4284aaa3ac7293c67
Bryan Davis [Tue, 6 Oct 2015 04:12:32 +0000 (22:12 -0600)]
Sort MWNamespace::getValidNamespaces list numerically
Bug: T109137
Change-Id: Ic6b7635884628c8c3cf1cdfb01dad49bab292d6c
jenkins-bot [Tue, 6 Oct 2015 00:36:13 +0000 (00:36 +0000)]
Merge "objectcache: Add BagOStuff::getWithSetCallback() convenience method"
Aaron Schulz [Sat, 3 Oct 2015 19:37:28 +0000 (12:37 -0700)]
objectcache: Add BagOStuff::getWithSetCallback() convenience method
Change-Id: I9cc162ff1cc48c1c500f2999327bd18ba235bfd0
Aaron Schulz [Sun, 4 Oct 2015 19:22:19 +0000 (12:22 -0700)]
Break numerous long lines in InfoAction
Change-Id: Ia873dce8aeab3c7ce93610a70fe78034addd39d7
jenkins-bot [Tue, 6 Oct 2015 00:11:22 +0000 (00:11 +0000)]
Merge "Make WANObjectCache sets account for slave lag"
jenkins-bot [Tue, 6 Oct 2015 00:00:23 +0000 (00:00 +0000)]
Merge "Remove return value from FormSpecialPage::checkExecutePermissions"
jenkins-bot [Tue, 6 Oct 2015 00:00:20 +0000 (00:00 +0000)]
Merge "Remove setting of $wgReadOnly in LBFactoryMulti"
jenkins-bot [Mon, 5 Oct 2015 23:50:57 +0000 (23:50 +0000)]
Merge "Clean up Special:Undelete read-only checks"
jenkins-bot [Mon, 5 Oct 2015 23:50:38 +0000 (23:50 +0000)]
Merge "Cleanups to MigrateFileRepoLayout"
jenkins-bot [Mon, 5 Oct 2015 23:45:36 +0000 (23:45 +0000)]
Merge "Start rename of DatabaseBase => Database"
Aaron Schulz [Thu, 1 Oct 2015 02:40:09 +0000 (19:40 -0700)]
Make WANObjectCache sets account for slave lag
* This gets lag information that is useful when
the calling code is about to run queries that
will have their results cached.
* This is now used in place of trxTimestamp() for
WANObjectCache set() and getWithSetCallback().
* The WAN cache will use a low TTL if the lag is
too high to avoid caching stale data for weeks.
* Bumped MAX_COMMIT_DELAY as nothing enforces it.
Bug: T113204
Change-Id: I2a95b4088cff42d6e980351555f81a4b13519e24
jenkins-bot [Mon, 5 Oct 2015 23:24:54 +0000 (23:24 +0000)]
Merge "Remove mismatched COMMIT from FileDeleteForm"
jenkins-bot [Mon, 5 Oct 2015 23:21:37 +0000 (23:21 +0000)]
Merge "Remove ?maxlag check in index.php"
jenkins-bot [Mon, 5 Oct 2015 23:13:24 +0000 (23:13 +0000)]
Merge "objectcache: Add BagOStuff::READ_VERIFIED flag to get()"
Aaron Schulz [Sat, 3 Oct 2015 07:43:40 +0000 (00:43 -0700)]
objectcache: Add BagOStuff::READ_VERIFIED flag to get()
* This lets multiwrite backends upgrade cached items
to higher tiers using UPGRADE_TTL.
* This is useful for memcached/sql tiers or apc/memcached.
Change-Id: I34b30ce8b54f8de36429d48c80f6768aed310272
Timo Tijhof [Mon, 5 Oct 2015 21:39:07 +0000 (14:39 -0700)]
Title: Fix @param for TS_MW to be string instead of int
Follows-up
6b0163391.
Change-Id: I7c45e1968b6ba8db0e5b19b8ca819e6ecc5764c9
jenkins-bot [Mon, 5 Oct 2015 21:36:47 +0000 (21:36 +0000)]
Merge "mediawiki.jqueryMsg: Always parse messages with '&'"
jenkins-bot [Mon, 5 Oct 2015 21:03:39 +0000 (21:03 +0000)]
Merge "Fix DatabaseSqlite::__toString"
Marius Hoch [Mon, 5 Oct 2015 20:42:28 +0000 (22:42 +0200)]
Fix DatabaseSqlite::__toString
Failed with "Catchable fatal error: Object of class
PDO could not be converted to string in".
The message I used was a rather arbitrary choice, but
I think it makes sense.
Bug: T114709
Change-Id: I0023fae3fa2a0c2b37cb3c34751706fe0d481d19
jenkins-bot [Mon, 5 Oct 2015 20:51:30 +0000 (20:51 +0000)]
Merge "mediawiki.jqueryMsg: Refactor handling of replacements/parameters in links"
jenkins-bot [Mon, 5 Oct 2015 20:20:17 +0000 (20:20 +0000)]
Merge "Fix DatabaseMysqlBase.php IDEA errors"
Translation updater bot [Mon, 5 Oct 2015 20:03:08 +0000 (20:03 +0000)]
Merge "Localisation updates from https://translatewiki.net."
jenkins-bot [Mon, 5 Oct 2015 19:59:21 +0000 (19:59 +0000)]
Merge "Update various @params from DatabaseBase to IDatabase"
jenkins-bot [Mon, 5 Oct 2015 19:57:45 +0000 (19:57 +0000)]
Merge "Database debug log cleanup (remove wgDebugDumpSqlLength/wgDebugDBTransactions)"
jenkins-bot [Mon, 5 Oct 2015 19:53:03 +0000 (19:53 +0000)]
Merge "Make generalizeSQL() protected"
Translation updater bot [Mon, 5 Oct 2015 19:50:30 +0000 (21:50 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ic61a81aba3e8c28526a5428ff73ac41f6e1a7d34
Aaron Schulz [Sun, 4 Oct 2015 18:39:58 +0000 (11:39 -0700)]
Database debug log cleanup (remove wgDebugDumpSqlLength/wgDebugDBTransactions)
* Simplify the debug log call and use queries group
* Remove $wgDebugDumpSqlLength, as profiler output
already has shortened query strings (one can use
profiling without DBO_DEBUG)
* Removed $wgDebugDBTransactions as BEGIN/COMMIT already show
* Removed PostgresTransactionState as it was only used for
$wgDebugDBTransactions handling
* This cuts down on lots of global variable usage
Change-Id: I185adb1694441d074dea965960429b4910727620
Aaron Schulz [Sat, 3 Oct 2015 01:04:45 +0000 (18:04 -0700)]
Remove mismatched COMMIT from FileDeleteForm
* Rely on the main DBO_TRX to commit at request end
Change-Id: Iad545db3603335baddc4156128f1dd756dbe99b4
Ori Livneh [Mon, 5 Oct 2015 18:39:13 +0000 (11:39 -0700)]
resourceloader: Tiny optimization to ResourceLoader::isValidModuleName()
This is a micro-optimization, but ResourceLoader is so well-optimized at this
point that the call to PCRE accounts for 1.25% of all load.php CPU time. So
might as well making it a tiny bit faster.
Change-Id: Iefab804a6ca6d54ce230958513a3bea44f4e7c62
jenkins-bot [Mon, 5 Oct 2015 19:17:27 +0000 (19:17 +0000)]
Merge "mw.widgets: Split CategorySelector widget to its own module"
Florian [Mon, 5 Oct 2015 17:41:40 +0000 (19:41 +0200)]
mw.widgets: Split CategorySelector widget to its own module
It's currently used by ForeignStructuredUpload only, so it's easy to split
it now and make mw.widgets as small as possible (you need to load only the
module of the widget(s) you want to use).
Bug: T108733
Change-Id: I147892eccdd5f7e0f53f824ea4d47e02984047f5
jenkins-bot [Mon, 5 Oct 2015 17:56:00 +0000 (17:56 +0000)]
Merge "Add null to @return tags if a method can return null"
Thiemo Mättig [Mon, 5 Oct 2015 15:53:13 +0000 (17:53 +0200)]
Add null to @return tags if a method can return null
Change-Id: I420998351663d92c4a101f61842e40591eebcd5f
Bartosz Dziewoński [Mon, 5 Oct 2015 12:50:29 +0000 (14:50 +0200)]
mediawiki.jqueryMsg: Always parse messages with '&'
To give consistent output for messages containing HTML entities.
Turns out that we're also inconsistent about escaping in HTML tag
attributes vs. escaping in text (see tests for 'jquerymsg-entities2'
and 'jquerymsg-entities-attr2'). This patch does not try to fix this.
Bug: T55576
Change-Id: I08cf9d552d1f0243a160babb8c3cf9f257be1be3
Bartosz Dziewoński [Mon, 5 Oct 2015 09:45:08 +0000 (11:45 +0200)]
mediawiki.jqueryMsg: Refactor handling of replacements/parameters in links
You should now be able to use replacements/parameters (such as '$1')
anywhere inside both link text and link target, in both external links
('[http://foo/ Bar]') and wikilinks ('[[Foo|Bar]]').
As a side effect of various cleanups, HTML in link text is now preserved
in all cases and is never wrapped in <span class="mediaWiki_htmlEmitter">.
Added test cases for it all.
Bug: T49395
Bug: T50064
Change-Id: I56d8f7ec03a70f5c2360d9c5099496ecb2f668ad
jenkins-bot [Mon, 5 Oct 2015 12:39:24 +0000 (12:39 +0000)]
Merge "Fix the last Generic.Files.LineLength phpcs failures"
Aaron Schulz [Mon, 5 Oct 2015 05:15:33 +0000 (22:15 -0700)]
Enforce lagged-slave read-only mode on the DB layer
* Most callers gracefully check wfReadOnly(),
but fail in case they dont. This also catches
foreign DBs which might slip through the cracks.
* Also remove useless wfDebug() call around
mDoneWrites check as write queries show in
the logs anyway.
Change-Id: I560ebd19c4eb2b3a040d4331702346440617cfaa
Aaron Schulz [Sun, 4 Oct 2015 09:07:25 +0000 (02:07 -0700)]
Update various @params from DatabaseBase to IDatabase
Change-Id: I98e44cdffb0fc0d729f69f702799139afb988c20
Aaron Schulz [Mon, 5 Oct 2015 05:16:38 +0000 (22:16 -0700)]
Remove setting of $wgReadOnly in LBFactoryMulti
wfReadOnly() already pulls in this information
Change-Id: I7c4693f0e69decefcc0cf52168fa2b71152eb99b
Aaron Schulz [Mon, 5 Oct 2015 04:45:25 +0000 (21:45 -0700)]
Cleanups to MigrateFileRepoLayout
* Use "bypassReadOnly" as other file backend maintenance
scripts do. One may want to run this while site traffic
is off via $wgReadOnly.
* Fixed handling for when img_sha1 is not set.
* Fixed some IDEA errors.
Change-Id: I95c426c5f2082576fc9ea40282d2869750a9f3d8
Aaron Schulz [Sun, 4 Oct 2015 20:35:16 +0000 (13:35 -0700)]
Clean up Special:Undelete read-only checks
* Use the standard SpecialPage method
* Show the error when trying to view the form for a page
Change-Id: I60a939e7d1a1164db2dc90525a750573be75fbcc
Aaron Schulz [Sun, 4 Oct 2015 20:22:01 +0000 (13:22 -0700)]
Remove return value from FormSpecialPage::checkExecutePermissions
It is unused and few callers comply with it
Change-Id: I3ac02ca996b57bf2222006712cc988a064dc38e5
Translation updater bot [Sun, 4 Oct 2015 20:02:58 +0000 (22:02 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I2c6d6bb15910feb1b8da5565bc27bfe7878bc0e4
Aaron Schulz [Sun, 4 Oct 2015 19:17:57 +0000 (12:17 -0700)]
Start rename of DatabaseBase => Database
This gives static method callers the option
to use methods like Database::factory() instead
of having to use the uglier DatabaseBase::factory().
Change-Id: I61800626b71ad2803a897df060059dbaf8778679
Aaron Schulz [Sun, 4 Oct 2015 09:48:55 +0000 (02:48 -0700)]
Make generalizeSQL() protected
Change-Id: Ib1317576b82993adf5ae454f9ecd8bd148a58cc9
Aaron Schulz [Sat, 3 Oct 2015 23:36:55 +0000 (16:36 -0700)]
Fix DatabaseMysqlBase.php IDEA errors
* Declare base mysqlRealEscapeString()
* Fix MySQLField::tableName() return value
Change-Id: I1277166e741e69cb1c045b3baa6ed8de664e9255
Aaron Schulz [Sat, 3 Oct 2015 23:30:13 +0000 (16:30 -0700)]
Converted DatabaseBase::mTrxAtomicLevels to an array
* This simplifies the code and cleans up __construct()
a bit while also making it less likely to cause
trouble with unit testing mocks.
* Also add a sanity mTrxLevel check around usage
of mTrxAtomicLevels in the one place it was missing
Change-Id: Ia0a7f22f5c27b3d4d8b51e04629f42a1ed9c3993
Ori Livneh [Thu, 1 Oct 2015 18:05:08 +0000 (11:05 -0700)]
resourceloader: cache minified user and site modules
* Add support for a '/* @nomin */' annotation in ResourceLoader. If present in
JavaScript or CSS, the code will not be minified or cached. This allows
modules like the ResourceLoaderUserTokensModule to declare themselves unfit
for minification / caching without requiring a complicated refactor.
* Make ResourceLoader::filter() static, at the cost of not having minifier
errors in the ResourceLoader log bucket. (They will continue to be logged as
exceptions, however).
Change-Id: Ic1d802ee20565e61046bfbd8fd209bc56a4cbd6c
Aaron Schulz [Sat, 3 Oct 2015 20:16:03 +0000 (13:16 -0700)]
Remove ?maxlag check in index.php
Any "good citizen" bots should be using the API
anyway and less good bots will probably not bother
sending the parameter
Change-Id: I38f45b397d29b4709a932afc6319a1323e8d1200
Translation updater bot [Sat, 3 Oct 2015 19:55:56 +0000 (19:55 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Translation updater bot [Sat, 3 Oct 2015 19:49:52 +0000 (21:49 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ie3f19a2b5cea902108126c528fb4c8f489a4d551
jenkins-bot [Sat, 3 Oct 2015 19:48:07 +0000 (19:48 +0000)]
Merge "Rename ObjectFactoryTest_Fixture to camel case name"
umherirrender [Sat, 3 Oct 2015 19:29:17 +0000 (21:29 +0200)]
Rename ObjectFactoryTest_Fixture to camel case name
Change-Id: Ib909c4f694b9774a0983abbb23bfd38ed8c05d5b
umherirrender [Sat, 3 Oct 2015 18:25:06 +0000 (20:25 +0200)]
Enable MediaWiki.NamingConventions.PrefixedGlobalFunctions.wfPrefix
Should work after Ie094f78781b2d6f7af1a0f1eea1f7ea4d0b9c69c
Bug: T104501
Change-Id: I1e3e8a1480b822272c762f2771d8554980c32c1b
umherirrender [Sat, 3 Oct 2015 18:10:53 +0000 (20:10 +0200)]
Enable Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
All remaining lines should be fixed now
Bug: T113854
Change-Id: I85269d4c84ae3a676a773e24b0a96a4e7a89ac38
jenkins-bot [Sat, 3 Oct 2015 18:18:07 +0000 (18:18 +0000)]
Merge "Fix ObjectCache::newAccelerator with string fallback in PHP 5.3"
Amir E. Aharoni [Sat, 3 Oct 2015 18:02:55 +0000 (21:02 +0300)]
Fix the last Generic.Files.LineLength phpcs failures
In both cases the long lines are inside method documentation,
and because @codingStandardsIgnoreStart comments only
work with // and not /*, they have to be outside the method comment.
Bug: T102614
Bug: T114213
Change-Id: I7343e1cf662c5bf12a5e4385646c5c2c4a798260
Amir E. Aharoni [Sat, 3 Oct 2015 13:44:47 +0000 (16:44 +0300)]
Fix remaining Generic.Files.LineLength failures
Except the ones for which there is no clear way to fix
because of T114213.
Bug: T102614
Change-Id: I94a1fc7c890c82a36f0b51e42d311585c275775c
Amir E. Aharoni [Sat, 3 Oct 2015 13:44:13 +0000 (16:44 +0300)]
Fix Generic.Files.LineLength phpcs check under phpunit/includes/api
Bug: T102614
Change-Id: Ic0b3d9b58fee8dc20a976ae65dcb7072a3afc3b1
Marius Hoch [Sat, 3 Oct 2015 17:15:33 +0000 (19:15 +0200)]
Fix ObjectCache::newAccelerator with string fallback in PHP 5.3
Because in PHP5.3:
php > $a = "hash";
php > echo isset( $a['fallback'] );
1
php > echo $a['fallback'];
h
This will fix using MediaWiki with MySQL on PHP5.3
if neither APC, xcache nor wincache are available.
Change-Id: Iebf034be75b282e2654cd298713455caf062eda4
Amir E. Aharoni [Sat, 3 Oct 2015 13:04:51 +0000 (16:04 +0300)]
Fix Generic.Files.LineLength phpcs check in files under phpunit/includes
Bug: T102614
Change-Id: Iee3df5f064f595ecebe8210cc936bc3d20a122c9
Amir E. Aharoni [Sat, 3 Oct 2015 12:52:08 +0000 (15:52 +0300)]
Fix Generic.Files.LineLength phpcs failure in 11 files under includes/
Bug: T102614
Change-Id: I0d759be6ef568c2c6f28606d3002484ad77a1830
jenkins-bot [Sat, 3 Oct 2015 16:47:29 +0000 (16:47 +0000)]
Merge "Fix spelling of "fragment" in test descriptions"
jenkins-bot [Sat, 3 Oct 2015 16:47:24 +0000 (16:47 +0000)]
Merge "Make lines short to pass phpcs in WikiReferenceTest.php"
jenkins-bot [Sat, 3 Oct 2015 16:39:50 +0000 (16:39 +0000)]
Merge "Make lines short to pass phpcs in WikitextContentTest.php"