Translation updater bot [Fri, 22 Apr 2016 20:08:03 +0000 (20:08 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Translation updater bot [Fri, 22 Apr 2016 20:05:45 +0000 (22:05 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Idcbc72b595213f1c7637525cfe72eaa88053dd80
jenkins-bot [Fri, 22 Apr 2016 20:05:24 +0000 (20:05 +0000)]
Merge "Fix EventRelayerKafka IDEA errors"
Aaron Schulz [Fri, 22 Apr 2016 19:12:29 +0000 (12:12 -0700)]
Fix EventRelayerKafka IDEA errors
Change-Id: I2808cb3cefb4d97f5ae2650554076c92b0d877d9
jenkins-bot [Fri, 22 Apr 2016 18:50:48 +0000 (18:50 +0000)]
Merge "HTMLForm: Don't render 'mw-htmlform-submit-buttons' if there aren't any buttons"
Fomafix [Fri, 22 Apr 2016 11:52:12 +0000 (11:52 +0000)]
Names.php: Replace remaining tabs and double spaces
Follow-up to
a3552004
Change-Id: I6a76de73fcfc21516fab7415057260e27e924696
matejsuchanek [Sun, 10 Apr 2016 18:41:57 +0000 (20:41 +0200)]
Fix GENDER support in logentry-rights-rights
Introduced in
70f0b0e588e40a18ce53c56a59efcc740f2766d2.
Got to core by my +1, sorry
Bug: T52583
Change-Id: I328fadacf7e5e3b7b250b76556ed585eeba424ca
jenkins-bot [Fri, 22 Apr 2016 16:50:10 +0000 (16:50 +0000)]
Merge "BagOStuff: Optionally log duplicate key lookups"
Bartosz Dziewoński [Fri, 22 Apr 2016 13:32:53 +0000 (15:32 +0200)]
HTMLForm: Don't render 'mw-htmlform-submit-buttons' if there aren't any buttons
Visually, this only affects OOUIHTMLForm, in other kinds of forms
the element has no height anyway.
Change-Id: I90e73c49fbefec23532368848bb30b2e7b69075c
jenkins-bot [Fri, 22 Apr 2016 11:46:16 +0000 (11:46 +0000)]
Merge "Have Linker::linkUrl() accept LinkTarget"
jenkins-bot [Fri, 22 Apr 2016 11:46:12 +0000 (11:46 +0000)]
Merge "Add LinkTarget::createFragmentTarget() function"
jenkins-bot [Fri, 22 Apr 2016 06:54:02 +0000 (06:54 +0000)]
Merge "RELNOTES for Skin::__call unroll & removal"
jenkins-bot [Fri, 22 Apr 2016 06:53:58 +0000 (06:53 +0000)]
Merge "Remove unused Skin -> Linker deprecated methods"
Martin Urbanec [Thu, 21 Apr 2016 18:49:46 +0000 (20:49 +0200)]
Set an alias for TrackingCategories page in Czech
Change-Id: I0c97cf6ce6aa342a50b667b06dc2e78175d9fbc1
Amire80 [Mon, 18 Apr 2016 08:48:26 +0000 (14:18 +0530)]
Unify the spaces before the comment in Names.php
Change everything from a varying number of tabs
to a single space.
The tabs don't really help make it more readable.
Change-Id: Ie84ee675ce4a50f78ec67d3840edc1a19f2c7884
Bryan Davis [Wed, 2 Mar 2016 02:25:55 +0000 (19:25 -0700)]
BagOStuff: Optionally log duplicate key lookups
Add new 'reportDupes' parameter to BagOStuff. This parameter enables scheduling
of a callback after the current web request ends. This callback will emit warning
log messages for all keys that were requested more than once.
The default ObjectCache factory for MediaWiki enables this option by default.
Not by default for plain BagOStuff instances, however. E.g. `new HashBagOStuff()`.
It also set 'asyncHandler' for all classes now (not just MultiWriteBagOStuff).
Bug: T128125
Co-Authored-By: Timo Tijhof <krinklemail@gmail.com>
Change-Id: I8a2b06cf54d2acf5950eed71756ecdf50e224be1
jenkins-bot [Fri, 22 Apr 2016 01:49:11 +0000 (01:49 +0000)]
Merge "Add missing tests for some edge cases in WatchedItem::getNotificationTimestamp"
jenkins-bot [Fri, 22 Apr 2016 01:49:07 +0000 (01:49 +0000)]
Merge "Remove unused JobQueueRedis vars"
Kunal Mehta [Wed, 20 Apr 2016 08:12:28 +0000 (01:12 -0700)]
Have Linker::linkUrl() accept LinkTarget
This is a private function so it doesn't really make much of a
difference, but will allow further refactoring.
Change-Id: Idacad7b1bd4776c04659ed9af64540d6ce4b2f28
Kunal Mehta [Wed, 20 Apr 2016 08:09:23 +0000 (01:09 -0700)]
Add LinkTarget::createFragmentTarget() function
The createFragmentTarget function allows for switching the fragment on a
target in an easier way. TitleValue already had a now-renamed
createFragmentTitle function (no uses outside of tests), and an
implementation was added for Title.
This will also help with reducing the amount of public usage of
Title::setFragment(), which is deprecated.
Change-Id: I1e8ba2f85e748b1b4394fb2f2a1ccce69cf6e3c5
jenkins-bot [Thu, 21 Apr 2016 21:37:40 +0000 (21:37 +0000)]
Merge "TableDiffFormatter: Don't repeatedly call array_shift()"
jenkins-bot [Thu, 21 Apr 2016 21:25:39 +0000 (21:25 +0000)]
Merge "Improve getErrorsByType() docs"
Translation updater bot [Thu, 21 Apr 2016 20:37:42 +0000 (22:37 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: If37acfa27b8f6648209998996ebef2e8bbe83622
James D. Forrester [Thu, 21 Apr 2016 17:36:29 +0000 (10:36 -0700)]
OOjs UI: Correct display of MenuToolGroup checkmarks
Pulling I6b2eeffd forward from next week's release.
Bug: T133227
Change-Id: Ic7adcb78c50ec89071f1efb4e35f42a3809f874b
Aaron Schulz [Tue, 19 Apr 2016 18:31:22 +0000 (11:31 -0700)]
Remove unused JobQueueRedis vars
Change-Id: I953df3daa2ec6b667971a8acd69ff59259d7ab55
jenkins-bot [Thu, 21 Apr 2016 15:49:17 +0000 (15:49 +0000)]
Merge "mediawiki.api.upload: Unbreak finishing stash uploads"
jenkins-bot [Thu, 21 Apr 2016 15:39:07 +0000 (15:39 +0000)]
Merge "Catch JobQueue errors in SiteStats::jobs"
Bartosz Dziewoński [Thu, 21 Apr 2016 15:32:05 +0000 (17:32 +0200)]
mediawiki.api.upload: Unbreak finishing stash uploads
The upload would complete successfully, but the upload
dialog would just hang for the user.
Follow-up to
11a2791668260211f1b82ec4954082533ff3adee.
Bug: T133295
Change-Id: I92724c6356d7dbf5c4cb87c05366bb7ed1ec8587
jenkins-bot [Thu, 21 Apr 2016 14:03:45 +0000 (14:03 +0000)]
Merge "Add getStatsdDataFactory to MediawikiServices"
Leszek Manicki [Wed, 20 Apr 2016 09:57:02 +0000 (11:57 +0200)]
Add missing tests for some edge cases in WatchedItem::getNotificationTimestamp
Change-Id: I18dd5976cc0f44f9dca8ee420ace226e49ab6288
Aaron Schulz [Wed, 20 Apr 2016 19:37:00 +0000 (12:37 -0700)]
Make MessageCache handle lock timeouts better
* Timeouts happen when memcached is cleared or on DC-switchover likewise
* Disable the sidebar cache when the MessageCache is disabled
* Also lower any output expiry for CDN and set a custom header
when the MessageCache is disabled
* Log when this happens to a dedicated "MessageCacheError" channel
Bug: T133069
Bug: T7092
Change-Id: I1b80e250532033c52680246279e1e8f56350ae83
jenkins-bot [Thu, 21 Apr 2016 10:25:43 +0000 (10:25 +0000)]
Merge "SessionManager: Ignore Session object destruction during global shutdown"
jenkins-bot [Thu, 21 Apr 2016 08:29:48 +0000 (08:29 +0000)]
Merge "Add LinkTarget::hasFragment() helper function"
jenkins-bot [Thu, 21 Apr 2016 05:31:47 +0000 (05:31 +0000)]
Merge "Remove unused wfGetDB() in SiteStats::jobs"
Kunal Mehta [Wed, 20 Apr 2016 08:07:58 +0000 (01:07 -0700)]
Add LinkTarget::hasFragment() helper function
LinkTarget::hasFragment() is a helper function which returns a boolean
of whether the target has a fragment. Title already had such a function,
and one was added to TitleValue.
Co-Authored-By: addshore <addshorewiki@gmail.com>
Change-Id: I49e607ae5a58c3aef96d0246297740e7d88ac816
Translation updater bot [Wed, 20 Apr 2016 20:41:38 +0000 (22:41 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I910ce04ca2372c9b7ac534664464b4edca6f759f
jenkins-bot [Wed, 20 Apr 2016 19:18:31 +0000 (19:18 +0000)]
Merge "Add missing visualClear on search result page"
jenkins-bot [Wed, 20 Apr 2016 18:47:17 +0000 (18:47 +0000)]
Merge "Create Kafka event relayer"
Stanislav Malyshev [Fri, 15 Apr 2016 21:01:23 +0000 (14:01 -0700)]
Create Kafka event relayer
Bug: T125138
Change-Id: I9d7705cb164bc975c3a0ddf4a33ac54fe7de931c
Aaron Schulz [Wed, 20 Apr 2016 16:46:29 +0000 (09:46 -0700)]
Fix ExternalStoreDB IDEA errors
Change-Id: I6200173fd1cba4bdf03b61659a48016107672fad
Aaron Schulz [Wed, 20 Apr 2016 16:55:08 +0000 (09:55 -0700)]
Catch errors in pushLazyJobs() and log them
This happens post-send anyway, so throwing errors is not
very useful and the other post-send updates are independent.
Change-Id: Ife8f9825da9592be1a38cf4c757550213838463b
Brad Jorsch [Wed, 20 Apr 2016 16:27:26 +0000 (12:27 -0400)]
SessionManager: Ignore Session object destruction during global shutdown
We already save all open SessionBackends when shutdown handlers are run,
which *should* make the Session object destructors that run during
global shutdown not have anything to save. But it can get fooled if the
Session data contains other objects that have already gotten destroyed
during the global shutdown, leading to spurious warnings and errors as
it tries to access partically-destroyed objects.
The solution is to set a flag when we do the shutdown handlers and just
ignore the last gasps from Session::__destruct() that might come after.
Change-Id: Ic3eb0bac2d29a30488c84b6525ad796a7f1c9ce9
Aaron Schulz [Wed, 20 Apr 2016 15:34:55 +0000 (08:34 -0700)]
Avoid ack() race condition in JobQueueRedis
The race would cause jobs to be be unclaimed but have
no actual job data, causing pop() to return false for
them.
Bug: T133089
Change-Id: Icc60388d4431ab7fa2ca2e46bbb0d212b2b94201
jenkins-bot [Wed, 20 Apr 2016 16:08:57 +0000 (16:08 +0000)]
Merge "Remove stray variable in processLogin()"
addshore [Wed, 20 Apr 2016 10:07:40 +0000 (11:07 +0100)]
Catch JobQueue errors in SiteStats::jobs
Bug: T133045
Change-Id: I68a9334a63c04609227f4c4e9ae510633543c3d5
jenkins-bot [Wed, 20 Apr 2016 08:24:15 +0000 (08:24 +0000)]
Merge "Deprecated 3 methods in DummyLinker"
jenkins-bot [Wed, 20 Apr 2016 08:22:41 +0000 (08:22 +0000)]
Merge "Unroll DummyLinker::__call"
addshore [Wed, 20 Apr 2016 08:08:25 +0000 (09:08 +0100)]
Deprecated 3 methods in DummyLinker
These methods are already deprecated in
Linker but they should also warn with the
method in DummyLinker
Change-Id: I41f0ee5b37f8a92711d1396b8b40d5235b643238
jenkins-bot [Wed, 20 Apr 2016 08:04:34 +0000 (08:04 +0000)]
Merge "Move DummyLinker to own file"
addshore [Wed, 20 Apr 2016 07:54:42 +0000 (08:54 +0100)]
Unroll DummyLinker::__call
Change-Id: Ie1325c2b8f06f9936e7b7ad10780c4b0cf702d18
addshore [Wed, 20 Apr 2016 07:48:48 +0000 (08:48 +0100)]
Move DummyLinker to own file
Change-Id: I1808a6b77af2597b4dd2c9f1e0c8604c2bc8c801
addshore [Tue, 19 Apr 2016 12:52:01 +0000 (13:52 +0100)]
RELNOTES for Skin::__call unroll & removal
Change-Id: I3d03338cbb48fe00f2beeb0dc7f5a1c2ff25d77d
addshore [Tue, 19 Apr 2016 12:41:43 +0000 (13:41 +0100)]
Remove unused Skin -> Linker deprecated methods
This also creates full pass through methods for
the remaining methods that are used by extensions
and skins in gerrit still.
Release notes will be added in a followup
Change-Id: I31c3b754cd70b1c60310add0de9d29a76f713cad
addshore [Wed, 20 Apr 2016 07:33:47 +0000 (08:33 +0100)]
Re add wfDeprecated calls after Skin::__call unroll
Change-Id: I0418d88e0fe355b7efff6e923d3144db3a294cea
Kunal Mehta [Wed, 20 Apr 2016 05:21:09 +0000 (22:21 -0700)]
Specially handle Title objects in Title::newFromLinkTarget()
Every single caller of Title::newFromLinkTarget() already special cases
when the LinkTarget object is already a Title, so move that logic into
one function.
Change-Id: Iba5432ae01c87850e5b34893092427c5b1629188
Marc A. Pelletier [Sun, 3 Apr 2016 07:46:06 +0000 (10:46 +0300)]
Add root title class to <body>
This adds a class to the body node of output pages in the form:
rootpage-X
Where X is the root title of the page.
This provides for the use cases in the linked tasks, and allows the
numerous existing cases of expensive css selectors using class*='page-X'
that are otherwise needed to apply a style to a page and or its subpages.
Bug: T123156
Bug: T17075
Change-Id: Ib16e380d97bd7bb55c5b5044a084fefbd039d599
jenkins-bot [Wed, 20 Apr 2016 00:02:47 +0000 (00:02 +0000)]
Merge "RebuildRecentchanges improvements"
James D. Forrester [Tue, 19 Apr 2016 22:00:12 +0000 (15:00 -0700)]
Update OOjs UI to v0.16.6
Release notes:
https://git.wikimedia.org/blob/oojs%2Fui.git/v0.16.6/History.md
Change-Id: Ib9bb35d87633d06211dd75e237d7b105947f8df1
Aaron Schulz [Tue, 19 Apr 2016 20:40:38 +0000 (13:40 -0700)]
RebuildRecentchanges improvements
* Always delete entries in the time range
* Batch queries and wait for slaves
* Optimized size-fetching query (pass 2)
* Set with rc_type with the actual constants (pass 2)
* Avoid flagging non-bot accounts as 'bot edits
* Use more modern DB layer coding style
Bug: T133053
Change-Id: I55cc099bf40977fa9e0a365da104c208441eec00
jenkins-bot [Tue, 19 Apr 2016 20:25:53 +0000 (20:25 +0000)]
Merge "Unroll __call in Skin"
Translation updater bot [Tue, 19 Apr 2016 19:59:09 +0000 (21:59 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I945074db5ba068c8e6b49b0cef3990938e766f16
jenkins-bot [Tue, 19 Apr 2016 19:43:55 +0000 (19:43 +0000)]
Merge "Improve HTMLSubmitField return value"
jenkins-bot [Tue, 19 Apr 2016 18:44:10 +0000 (18:44 +0000)]
Merge "rebuildrecentchanges: Allow rebuilding specified time range only"
Bartosz Dziewoński [Tue, 19 Apr 2016 17:58:22 +0000 (19:58 +0200)]
rebuildrecentchanges: Allow rebuilding specified time range only
Bug: T133053
Change-Id: I8eef6e72f1105352116248548ab077fef818a8f9
Florian [Tue, 19 Apr 2016 17:24:04 +0000 (19:24 +0200)]
Add missing visualClear on search result page
I'm not sure, when this was removed or why it broke, but without
the visualClear (clear:both), the text match section is near the
title match section, instead of after it.
Bug: T133071
Change-Id: I68028a8658ba0aa526ce1a6ef6401f9fd79533f8
Aaron Schulz [Tue, 19 Apr 2016 16:52:27 +0000 (09:52 -0700)]
Remove stray variable in processLogin()
Change-Id: Ife23555755e69d1d40b0c37259f53f3df78468aa
addshore [Tue, 19 Apr 2016 16:07:50 +0000 (17:07 +0100)]
Remove unused wfGetDB() in SiteStats::jobs
Change-Id: Id818a71a75e4d4cb8397df5b1ff3dfdd3b155ea7
jenkins-bot [Tue, 19 Apr 2016 15:19:43 +0000 (15:19 +0000)]
Merge "Convert Special:WithoutInterwiki to HTMLForm"
addshore [Tue, 19 Apr 2016 12:37:04 +0000 (13:37 +0100)]
Unroll __call in Skin
Change-Id: Ia07a6099fed42bddcf2d6135de9c06f744b2f309
jenkins-bot [Tue, 19 Apr 2016 12:12:34 +0000 (12:12 +0000)]
Merge "Fix wrong @return type hints in Language::tsTo… methods"
addshore [Mon, 11 Apr 2016 18:28:17 +0000 (19:28 +0100)]
Add getStatsdDataFactory to MediawikiServices
Change-Id: Iaf89d5d7887f766064266874ea7ba73362531ed2
Thiemo Mättig [Tue, 19 Apr 2016 10:18:20 +0000 (12:18 +0200)]
Fix wrong @return type hints in Language::tsTo… methods
Change-Id: Ic4dec8e8612021f010734037b6c3527bef2fe04a
jenkins-bot [Tue, 19 Apr 2016 07:34:52 +0000 (07:34 +0000)]
Merge "Hide hiddencat catwatch changes in special changelists"
tonythomas01 [Sun, 17 Apr 2016 09:06:07 +0000 (14:36 +0530)]
Convert Special:WithoutInterwiki to HTMLForm
TODO: Should be eventually converted to OOUI
Bug: T117721
Change-Id: I56b6b78b53d2531ebdb9cd0f903a4ce475dbc56b
jenkins-bot [Tue, 19 Apr 2016 01:43:27 +0000 (01:43 +0000)]
Merge "Segment stash edit cache stats by basis for hit/miss"
Ori Livneh [Tue, 19 Apr 2016 01:13:08 +0000 (18:13 -0700)]
Segment stash edit cache stats by basis for hit/miss
Instead of just counting cache hits and misses, segment the counts by reason,
so we can differentiate (for example) timestamp-based cache hits from
staleness-check-survivor cache hits. I want this data so I can determine
whether increasing the cutoff for timestamp-based hits from 3 to 5 seconds has
a substantial enough impact to warrant the slightly weaker consistency.
Also changed 'cache-hit' to 'cache_hit'. MediaWiki normalizes the dash to an
underscore anyway, but the normalization is there for dynamically-constructed
key names (or name segments). In the case of hard-coded values, it is desirable
for the code to be as close as possible to the final form of the metric name,
to simplify metric lookup.
Change-Id: I0cd61da9746e3ca3695e23200f698b8b1371798c
James D. Forrester [Tue, 19 Apr 2016 01:13:18 +0000 (18:13 -0700)]
registration: Support skipFunction module definitions
Change-Id: I9c5cea3e8df1fae001d4d98c0782a04dec803776
jenkins-bot [Mon, 18 Apr 2016 23:30:23 +0000 (23:30 +0000)]
Merge "Reject usernames with namespace or interwiki prefixes"
jenkins-bot [Mon, 18 Apr 2016 22:41:50 +0000 (22:41 +0000)]
Merge "Enforce $wgReadOnly for job queues"
Aaron Schulz [Mon, 18 Apr 2016 19:09:54 +0000 (12:09 -0700)]
Allow tag names for SqlBagOStuff consistent hashing
This is needed to avoid poor hit rates in multi-DC setups
Change-Id: I8830bd6bffa4619e31609676527282ef9af0c76c
jenkins-bot [Mon, 18 Apr 2016 21:36:16 +0000 (21:36 +0000)]
Merge "DateTimeInputWidget: Set type before calling parent constructor"
Aaron Schulz [Fri, 25 Mar 2016 19:52:39 +0000 (12:52 -0700)]
Enforce $wgReadOnly for job queues
Bug: T130795
Change-Id: I9d8cf919de80dbe855086b9c590c0a0f20dc33b9
Timo Tijhof [Sat, 20 Feb 2016 15:22:22 +0000 (15:22 +0000)]
resourceloader: Use feature test instead of UA sniffing
Converting to a feature test reduces complexity of the startup module, and
makes the blacklist more meaningful - allowing us to safely remove some
unnecessary feature guards and polyfills.
It'll also provide unsupported browsers a much better experience. Previously,
unsupported browsers got the payload for Grade A runtime. Many of which would
likely fatal due to unimplemented DOM and JS methods. With the capability
filter in this commit, the client will only initialise the environment if the
browser is capable - falling back to Grade C otherwise.
The feature-test that replaces the user-agent filter in this commit is 99.96%
effectively the same - based on a 7 day analytics campaign on all Wikimedia
wikis (see T102318 for details).
Bug: T102318
Change-Id: I847b3f5f80f1eef3f57bbe7518768468e271082b
Translation updater bot [Mon, 18 Apr 2016 19:59:44 +0000 (21:59 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I3777ce409669883f0d7ac20ce834bf8526b6dfea
Brad Jorsch [Mon, 18 Apr 2016 18:45:27 +0000 (14:45 -0400)]
DateTimeInputWidget: Set type before calling parent constructor
This way when the parent calls setValue() which calls cleanUpValue(), it
cleans up the value correctly.
Change-Id: I9dcfa74ca03f6aded1dd0f9593d24b0986596b41
jenkins-bot [Mon, 18 Apr 2016 16:55:11 +0000 (16:55 +0000)]
Merge "Use new TWN template for log-action-filter-* qqq messages"
Aaron Schulz [Mon, 18 Apr 2016 16:08:26 +0000 (09:08 -0700)]
Improve getErrorsByType() docs
Change-Id: I235a82ee1036d59a0f4929fc2170f261280f9b4d
jenkins-bot [Mon, 18 Apr 2016 15:17:07 +0000 (15:17 +0000)]
Merge "Test coverage WatchedItemStore::duplicateAllAssociatedEntries to 100%"
jenkins-bot [Mon, 18 Apr 2016 15:17:03 +0000 (15:17 +0000)]
Merge "Test coverage WatchedItemStore::addWatchBatchForUser to 100%"
jenkins-bot [Mon, 18 Apr 2016 15:16:58 +0000 (15:16 +0000)]
Merge "Reject usernames with # as user-type API parameters"
Gergő Tisza [Sat, 16 Apr 2016 17:36:33 +0000 (17:36 +0000)]
Reject usernames with namespace or interwiki prefixes
User::getCanonicalName silently stripped namepace/iw prefixes,
resulting in weird behavior (e.g. entering 'Template:Foo' in the
registration form username field was accepted, but user 'Foo' was
created). Explicitly reject such names instead.
Also remove leading whitespace from test cases testing for something
else.
Bug: T94656
Change-Id: Idfb22f998cb069fca24abcf5809afd6e0324b0ae
WMDE-Fisch [Wed, 13 Apr 2016 15:52:48 +0000 (17:52 +0200)]
Hide hiddencat catwatch changes in special changelists
If a hidden category has a member added or removed
this will only be shown to users that have the user
preference "display hidden categories".
Also added method to WikiCategoryPage to check
for hidden status.
Added unit tests for both.
Bug: T127944
Change-Id: Ic53d51391fa29d5e18fef4c42b8a275816c7ba4a
Gergő Tisza [Fri, 1 Apr 2016 12:12:06 +0000 (15:12 +0300)]
Improve HTMLSubmitField return value
- do not return anything when the button was not clicked
- return boolean true (instead of the button text) when it was clicked
Unbreaks submit fields which currently don't return anything so there is
no easy way to tell whether they have been clicked.
Change-Id: If4e0dfb6ee6674f0dace80a01850e2d0cbbdb47a
jenkins-bot [Mon, 18 Apr 2016 12:25:30 +0000 (12:25 +0000)]
Merge "Fix RecentChange::parseParams @return docs"
addshore [Mon, 18 Apr 2016 11:32:46 +0000 (12:32 +0100)]
Test coverage WatchedItemStore::duplicateAllAssociatedEntries to 100%
Change-Id: I3d686fda1175a9ae5e4244b9ba8cfdb416950ebd
addshore [Mon, 18 Apr 2016 11:25:54 +0000 (12:25 +0100)]
Test coverage WatchedItemStore::addWatchBatchForUser to 100%
Change-Id: I6ff916519af87a40187d86149b0b72c2ab5a5f26
addshore [Mon, 18 Apr 2016 10:06:09 +0000 (11:06 +0100)]
Fix RecentChange::parseParams @return docs
Per the docs of unserialize:
In case the passed string is not unserializeable, false is returned.
Also as we can not guarentee an array was serialized in
rc_params we cant say it will always be an array...
Quite often this is just an empty string which will
result in: "s:0:"";" (not an array)....
Change-Id: Ib22f9f7468a23ce3d4f145d47f8514d08be6c957
jenkins-bot [Mon, 18 Apr 2016 08:05:41 +0000 (08:05 +0000)]
Merge "HTMLForm code style fixes"
jenkins-bot [Mon, 18 Apr 2016 08:05:34 +0000 (08:05 +0000)]
Merge "mediawiki.special.upload: Use formatversion=2 for API requests"
jenkins-bot [Mon, 18 Apr 2016 07:45:39 +0000 (07:45 +0000)]
Merge "parserTests.php: fix three bitrot bugs with --record"