Bartosz Dziewoński [Sun, 13 Oct 2013 13:58:52 +0000 (13:58 +0000)]
FormOptions: Document getValueReal(), consistency fixes
I missed it in my previous doco commit, good opportunity
to try out the fancy new tool.
Change-Id: I52005b243042c3d66250d1cfecfceabbd370ea5c
umherirrender [Sat, 12 Oct 2013 20:48:26 +0000 (22:48 +0200)]
Pass Context to User::resetOptions
Change-Id: I0444777697ed9a8b8afdd0e5a96841848b162a7a
jenkins-bot [Sat, 12 Oct 2013 19:26:46 +0000 (19:26 +0000)]
Merge "Add bot to createAndPromote.php groups"
Translation updater bot [Sat, 12 Oct 2013 18:42:51 +0000 (18:42 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I018c32bec9b2b04590657afd96606ed473cdfed6
jenkins-bot [Sat, 12 Oct 2013 17:20:38 +0000 (17:20 +0000)]
Merge "Revert visibility change to HTMLForm $typeMappings"
Siebrand Mazeland [Sat, 12 Oct 2013 15:35:26 +0000 (17:35 +0200)]
Update formatting
Change-Id: If3dd6a1ac4b16479244a847420f0488ba8c51e2b
Bartosz Dziewoński [Sat, 12 Oct 2013 14:56:41 +0000 (16:56 +0200)]
FormOptions: More documentation!
Change-Id: I088b07c1672426c45d995fdf96ac7fc7bda21307
S Page [Sat, 12 Oct 2013 08:10:24 +0000 (01:10 -0700)]
Revert visibility change to HTMLForm $typeMappings
Change Id5668141835e22e3e1b043109e50d73ccd6b1229 changed the visibility
of static $typeMappings to private. It turns out this breaks
http://www.blue-spice.org/ who want to add their own HTMLForm types and
have no way to extend or override this except by changing it. So set it
to public static.
As https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP says,
"It's generally a good idea to avoid visibility changes unless you're
making changes to the function which would break old uses of it anyway."
That trumps PHP CodeSniffer warnings.
Change-Id: Ife82596e96a4650b977422aae6b32f24a392d5fb
Bryan Davis [Fri, 11 Oct 2013 22:41:59 +0000 (16:41 -0600)]
Modernize SquidUpdate php code
- Update to PHP5 object coding style
- Fix @param comments using wrong argument order
- Add some phpdoc comments
Change-Id: Ia3190a6276e807ebef4f4aaeedc0e39819dc992a
jenkins-bot [Fri, 11 Oct 2013 20:36:06 +0000 (20:36 +0000)]
Merge "Blacklist Nokia's Ovi Browser from ResourceLoader"
Max Semenik [Fri, 11 Oct 2013 15:49:04 +0000 (19:49 +0400)]
Blacklist Nokia's Ovi Browser from ResourceLoader
It runs scripts proxy-side much like Opera Mini does, resulting in nothing
resembling a real JS engine. This causes problems and the browser is popular
enough to warrant a block.
Bug: 55600
Change-Id: I2c1ee78828c2b9cead4f82ef795972a4c28140b4
Translation updater bot [Fri, 11 Oct 2013 19:10:32 +0000 (19:10 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I8f4d44a3917bc7264d7dacc4b1e75641dab845c0
jenkins-bot [Fri, 11 Oct 2013 18:50:51 +0000 (18:50 +0000)]
Merge "exception: Account for $call['file'] and $call['line'] being unset"
Timo Tijhof [Fri, 11 Oct 2013 18:18:07 +0000 (20:18 +0200)]
exception: Account for $call['file'] and $call['line'] being unset
Bug: 55634
Change-Id: I1173216cade73216848816f6bb51e54096abdfde
jenkins-bot [Fri, 11 Oct 2013 18:28:29 +0000 (18:28 +0000)]
Merge "Add script to purge changed files from cache"
jenkins-bot [Fri, 11 Oct 2013 17:27:45 +0000 (17:27 +0000)]
Merge "mw.inspect: decline to report module sizes when in debug mode"
jenkins-bot [Fri, 11 Oct 2013 17:26:03 +0000 (17:26 +0000)]
Merge "FormatJson: minor cleanup"
jenkins-bot [Fri, 11 Oct 2013 16:31:10 +0000 (16:31 +0000)]
Merge "Add an explicit targets declaration for mediawiki.inspect & $.byteLength"
Ori Livneh [Fri, 11 Oct 2013 08:31:00 +0000 (01:31 -0700)]
Add an explicit targets declaration for mediawiki.inspect & $.byteLength
Jon Robson said[1] he'd be interested in making mediawiki.inspect usable on
the mobile site by specifying both mobile & desktop targets explicitly in the
resource declaration. That's what this patch does. The cost to this is very
minimal because the module is never loaded by default. mw.loader.inspect()
wraps the call to the inspector with an mw.loader.using() call that causes the
module to be retrieved. It is not retrieved otherwise.
[1]: http://lists.wikimedia.org/pipermail/wikitech-l/2013-October/072381.html
Change-Id: I7cf292d3b8fb554bd1fc2143ca45399efccb70aa
Ori Livneh [Fri, 11 Oct 2013 10:44:33 +0000 (03:44 -0700)]
mw.inspect: decline to report module sizes when in debug mode
- In debug mode, 1 resource = 1 request, so module size is easier to determine
via the network view of the developer tools in Firefox & WebKit browsers.
- Determining the module size in debug mode in JavaScript would require
modifying core ResourceLoader code or re-fetching each resource with a
separate XHR to measure its size.
- It's not worth it.
Bug: 55553
Change-Id: I73d1bb4141c1b6ed64a72fdc416048937a2e1146
Timo Tijhof [Sun, 6 Oct 2013 22:15:36 +0000 (00:15 +0200)]
mediawiki.page.gallery: Clean up documentation for hook
Follows-up
14b3f87.
Change-Id: Ia917516d985a6e6f6e4bbca9ea8b5437175a6aa8
jenkins-bot [Thu, 10 Oct 2013 22:12:55 +0000 (22:12 +0000)]
Merge "Do not set wgServer in cli install unless explicitly passed"
jenkins-bot [Thu, 10 Oct 2013 20:54:37 +0000 (20:54 +0000)]
Merge "Made JobQueueDB use getConnectionRef()"
Translation updater bot [Thu, 10 Oct 2013 19:03:14 +0000 (19:03 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I6ed3b4bc205bb8b6a09aea841a73aa0d8e317554
jenkins-bot [Thu, 10 Oct 2013 18:08:25 +0000 (18:08 +0000)]
Merge "Handle raw <h#> when calculating $rawtoc"
YuviPanda [Sun, 6 Oct 2013 19:41:18 +0000 (01:11 +0530)]
Do not set wgServer in cli install unless explicitly passed
Currently, if we do not pass a wgServer value (via --server),
the CLI installer sets the value to the default value
specified in DefaultSettings.php - which is to 'guess' by
calling into WebRequest::detectServer. This yields terrible
results, since WebRequest::detectServer expects to be working
in the context of a Web Request - and hence with HTTP Host
header information. Since calling from the CLI does not give
it host header information, it falls back to 'localhost',
which is not the value you usually want.
If we just do not set wgServer when it is not specified,
it is automatically calculated on every request by
WebRequest::detectServer, which does a splendid job.
Bug: 55376
Change-Id: I5436dd8c340604cbb59406a507188e11c8f86e86
Chad Horohoe [Thu, 10 Oct 2013 01:14:42 +0000 (18:14 -0700)]
Remove silly test cases that are likely to fail
Nobody should be giving objects or arrays to addIdentifierQuotes() anyway
Change-Id: Ibebf5d32196ac5b80cd477aedfef982fd2c9a0e6
jenkins-bot [Wed, 9 Oct 2013 23:48:05 +0000 (23:48 +0000)]
Merge "Fixed trx isolation bug that could cause text not to be found"
Aaron Schulz [Mon, 7 Oct 2013 16:18:16 +0000 (09:18 -0700)]
Made JobQueueDB use getConnectionRef()
* Also moved insertFields() function up a bit about DB connection methods
Change-Id: I7a9d9c9bc71038fe280542b13e0c0e94bfc4de1e
jenkins-bot [Wed, 9 Oct 2013 22:21:20 +0000 (22:21 +0000)]
Merge "Made root job de-duplication work without cache setup"
jenkins-bot [Wed, 9 Oct 2013 22:12:26 +0000 (22:12 +0000)]
Merge "Escape backticks when quoting MySQL identifiers"
jenkins-bot [Wed, 9 Oct 2013 22:01:19 +0000 (22:01 +0000)]
Merge "Add mediawiki.inspect module"
Ori Livneh [Tue, 8 Oct 2013 06:08:54 +0000 (23:08 -0700)]
Add mediawiki.inspect module
This patch adds a mediawiki.inspect ResourceLoader module. The module contains
tools for inspecting page composition and performance. It is currently
restricted to a set of static methods for querying the ResourceLoader module
registry, the most useful of which is #inspectLoadedModules, which prints a
list of loaded ResourceLoader modules and their size in kilobytes, ordered from
largest to smallest. This method has a lazy-loading alias: mw.loader.inspect.
Change-Id: I5a007fdf11196664f425cd7800eec7fc3fdb629f
Bryan Davis [Tue, 8 Oct 2013 18:14:52 +0000 (12:14 -0600)]
Escape backticks when quoting MySQL identifiers
Previously mysql_real_escape_string() was improperly used which escapes
for inclusion in a plain string rather than an identifier.
Also adds basic test support for the DatabaseMysqlBase class.
Co-Authored by: Antoine Musso <hashar@free.fr>
Bug: 55427
Change-Id: Ic045e195c89d8d5d0f0edbda0cd1df781de7025c
Translation updater bot [Wed, 9 Oct 2013 19:36:07 +0000 (19:36 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I91e6b1a32aaca18175c97130685a26e9a5704f8d
jenkins-bot [Wed, 9 Oct 2013 19:11:44 +0000 (19:11 +0000)]
Merge "Fix ForeignAPIRepo::fileExistsBatch()"
jenkins-bot [Wed, 9 Oct 2013 18:14:09 +0000 (18:14 +0000)]
Merge "Tests for API section editing"
Kunal Mehta [Sat, 7 Sep 2013 05:56:37 +0000 (22:56 -0700)]
Tests for API section editing
Change-Id: Ibc05c54cd2c9e1775f72dd969e7677b5238e12ad
jenkins-bot [Wed, 9 Oct 2013 18:00:43 +0000 (18:00 +0000)]
Merge "Remove wfDl() and cleanup everything it touched"
jenkins-bot [Wed, 9 Oct 2013 17:58:50 +0000 (17:58 +0000)]
Merge "Fix PHP CodeSniffer warnings and errors"
Chad Horohoe [Wed, 9 Oct 2013 16:46:57 +0000 (09:46 -0700)]
Remove wfDl() and cleanup everything it touched
wfDl() is a wrapper around dl(), which is an evil function and
basically only works from the command line of Zend. Luckily
no extension has ever used this thing, so let's just remove it
outright.
For comparison, here's a list of places it does not work:
- hhvm
- php as apache module
- php compiled with zts support
- safe_mode
- Basically any shared host that cares about security
Most callers are using it to check for extension support and are
actually failing gracefully when wfDl() returns false. In these
places we're just going to use extension_loaded().
While we're at it, clean up some of the test skip logic in the
media tests so we can bail as early as possible if we know we
can't complete the test.
This also immediately removes $wgLoadFileinfoExtension. It's been
enabled by default since 5.3 and falls back gracefully when the
support isn't available.
Change-Id: Ieb430dfc74483731dde51d6e20fa700d641ba1f4
Brad Jorsch [Wed, 9 Oct 2013 15:03:40 +0000 (11:03 -0400)]
Handle raw <h#> when calculating $rawtoc
When the parser is constructing $rawtoc, it needs the sectionIndex
number to be able to calculate the byteoffset. This number is only
available for wikitext headings ("== foo =="), HTML headings
("<h2>foo</h2>") do not have it and the lack makes byteoffset be wrong
for all subsequent headings in the page.
To fix this, we just omit output of byteoffset in this situation.
Bug: 25203
Change-Id: I39e5faa4ac22d915f06125aac36ced11607b94a3
Brad Jorsch [Wed, 26 Dec 2012 16:55:49 +0000 (11:55 -0500)]
Fix ForeignAPIRepo::fileExistsBatch()
ForeignAPIRepo::fileExistsBatch() is extremely broken:
* If passed an array with numeric keys (e.g. as called from
FileRepo::fileExists()), it will cache the fact that the item at index
0 from the first call was found or not found, no matter what the
actual file being queried is!
* But it doesn't even use its cache correctly. Rather than checking the
value cached, it just assumes anything that was cached exists.
* It checks whether the page in the remote repository has a description
page, not whether a file actually exists for the title.
* But it doesn't do that right either, so in the vast majority of cases
it will decide everything exists.
All of this is offset by the fact that I can't find any code path that
would actually call this function.
Change-Id: I421e8892b642f5267b8dd755183ebd711db83152
Aaron Schulz [Wed, 9 Oct 2013 17:03:26 +0000 (10:03 -0700)]
Fixed trx isolation bug that could cause text not to be found
* Also added some logging for when revision text is not found
bug: 53687
Change-Id: I0993e8f49d36771cc526fd4afef67455209b8e3a
Siebrand Mazeland [Tue, 8 Oct 2013 17:11:35 +0000 (19:11 +0200)]
Fix PHP CodeSniffer warnings and errors
Also apply formatting convention.
Change-Id: I792210d0d1c5f9089a71cecba95e17822f6da0e3
jenkins-bot [Wed, 9 Oct 2013 16:21:18 +0000 (16:21 +0000)]
Merge "Remove incorrect span in translation"
Siebrand Mazeland [Tue, 8 Oct 2013 16:46:50 +0000 (18:46 +0200)]
Remove incorrect span in translation
Probably originates from a bugged machine translation API.
Change-Id: I39c7d154ffc085991f683de107deb05d730f065d
Siebrand Mazeland [Tue, 8 Oct 2013 16:08:00 +0000 (18:08 +0200)]
Remove unused local variable
Change-Id: I93ce25fe158f7a82ade102953d6a2453620b7e0e
jenkins-bot [Wed, 9 Oct 2013 15:38:53 +0000 (15:38 +0000)]
Merge "tests: remove date from @author docs statements"
jenkins-bot [Wed, 9 Oct 2013 15:34:21 +0000 (15:34 +0000)]
Merge "Make items in the StringUtilsTest data provider easier to identify by adding names."
jenkins-bot [Wed, 9 Oct 2013 15:17:59 +0000 (15:17 +0000)]
Merge "Fix PHP CodeSniffer errors and warnings"
Jan Zerebecki [Thu, 23 May 2013 09:37:32 +0000 (11:37 +0200)]
Make items in the StringUtilsTest data provider easier to identify by adding names.
Change-Id: I026eff69236187ce3d2ff2fc261a5e1d9cd88b24
Siebrand Mazeland [Tue, 8 Oct 2013 11:43:42 +0000 (13:43 +0200)]
Update formatting
With some manual corrections.
Change-Id: Icd947288c32fdb90a0f35388963ef5a17ffa58e7
Kevin Israel [Tue, 8 Oct 2013 14:52:01 +0000 (10:52 -0400)]
FormatJson: minor cleanup
* Prefer feature detection over version comparison.
* Prefer pre- over post- increment and decrement operators.
* Remove the statement that FormatJson::decode() decodes `true`,
`false`, and `null` case insensitively. Nobody should assume
this is (or is not) the case, even though the PHP manual says so.
* Avoid using the ternary operator with long strings; prior to
PHP 5.4, the operator prevented the copy-on-write optimization.
* Avoid placing comments on the same lines as code.
Change-Id: I8fc88e9b7b49aa0cbd4128216557836a3b2cd011
Mark Holmquist [Tue, 8 Oct 2013 07:01:54 +0000 (00:01 -0700)]
Add some siteinfo to the repo info array
Used for linking to user pages on remote repos in the
MultimediaViewer extension.
Change-Id: Ia703d63e8e02b1e8fbc90b7d7f90a748d9e177ec
Mark Holmquist [Tue, 8 Oct 2013 20:11:54 +0000 (13:11 -0700)]
Quick refactor of the http logic in ForeignAPIRepo
Automatic caching, will enable slightly smaller patches elsewhere.
Resetting after failing at a rebase.
Change-Id: I6849107a3af773687a31155b23a2d7b4d7a60645
jenkins-bot [Tue, 8 Oct 2013 20:36:45 +0000 (20:36 +0000)]
Merge "Fix revision table cleanup on delete"
Bryan Davis [Fri, 4 Oct 2013 22:38:09 +0000 (16:38 -0600)]
Add script to purge changed files from cache
This maintenance script enhances the prior purgeDeletedFiles script to
optionally also process create and modify events that may have left
stale information in front-end caches.
Changes from purgeDeletedFiles:
* `--starttime` & `--endtime` are now required
* `--type` allows selecting 'created' and/or 'modified' events in
addition to 'deleted' events.
* `--dry-run` to list affected files but perform no purges
* `--htcp-dest` option to restrict HTCP broadcast messages
Change-Id: I7181ea461ba9758747bff4fd70530d00dab492cc
Timo Tijhof [Tue, 8 Oct 2013 19:40:00 +0000 (21:40 +0200)]
mediawiki.action.edit.preview: Fix for LiquidThreads hack
LiquidThreads is loading this core module when rendering an
inline edit form. Because the form doesn't have the same ID
as the one in core, this broke after
becd284.
It previously worked because the click event on the button (of
which LQT did duplicate the ID from core) bubbles up to the
document body and thus trigger this private handler of the
core edit preview module.
Change-Id: I9e35d0c48b86e1c9073b68313a8a330c6ea85b86
Translation updater bot [Tue, 8 Oct 2013 19:18:47 +0000 (19:18 +0000)]
Merge "Localisation updates from translatewiki.net."
jenkins-bot [Tue, 8 Oct 2013 19:09:15 +0000 (19:09 +0000)]
Merge "Add file-link "parser" to mw.Title from commons"
Translation updater bot [Tue, 8 Oct 2013 19:00:46 +0000 (19:00 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I331db0fe25638bdab35fbf54d00dd77f93488a7a
Mark Holmquist [Fri, 4 Oct 2013 00:06:53 +0000 (17:06 -0700)]
Add file-link "parser" to mw.Title from commons
Rillke has been amazing and provided us with a first pass at a file URL
parser for MediaWiki:
https://commons.wikimedia.org/wiki/MediaWiki:Gadget-libUtil.js
Hoping to use this for Extension:MultimediaViewer and others in the near
future - potentially replacing patchset Ib69d1ffdfd3b58c2e8e3314940a2cad311b85533
Also tests.
Change-Id: Ie31e6df376bda087e92ec889d54df3374ba96b5e
jenkins-bot [Tue, 8 Oct 2013 18:30:02 +0000 (18:30 +0000)]
Merge "Allow $context->setTitle( null )"
Bryan Davis [Tue, 8 Oct 2013 17:51:32 +0000 (11:51 -0600)]
Add doc comment to Status explaining use
Tim posted a nice explanation of the recommended pattern for using the
Status object to wikitech-l. This change copies that explanation into
the phpdoc comment block of the Status class in an attempt to propagate
the meme.
Change-Id: Ia98543caaa829cad443abf0f0f5038b3de943ef8
Siebrand Mazeland [Tue, 8 Oct 2013 17:32:04 +0000 (19:32 +0200)]
Fix PHP CodeSniffer errors and warnings
Change-Id: I573d73b4cf1dcddfe14e9d565e4f170ad024ea31
jenkins-bot [Tue, 8 Oct 2013 17:31:22 +0000 (17:31 +0000)]
Merge "Fixup parameter type hints"
jenkins-bot [Tue, 8 Oct 2013 17:08:15 +0000 (17:08 +0000)]
Merge "Add method parameter type documentation"
jenkins-bot [Tue, 8 Oct 2013 16:34:13 +0000 (16:34 +0000)]
Merge "Move forceHTTPS check until after wgTitle is setup"
Reedy [Wed, 18 Sep 2013 23:00:47 +0000 (00:00 +0100)]
Added $wgExtensionEntryPointListFiles for use with mergeMessageFileList.php
Going to be used to change target file for labs vs production
Change-Id: Id4b16083435ef7f4fce31861c72889e664d07236
umherirrender [Thu, 2 May 2013 15:28:33 +0000 (17:28 +0200)]
Add list=allfileusages
This allows the client to enumerate through entries of the imagelinks
table.
This can be useful to find images from foreign repos used on the own
wiki.
Change-Id: I2ad0579e3521868d39f7d495ea9c83a2cd9731d6
S Page [Tue, 8 Oct 2013 04:13:19 +0000 (21:13 -0700)]
Fix help string to avoid PHP notice
Escape a $ symbol in help message and rephrase slightly. Without this,
`php maintenance/language/checkDupeMessages.php --help` prints
PHP Notice: Undefined variable: dupeMessages in
language/checkDupeMessages.php on line 56
Change-Id: Ie7c0f07e68cee1f7cd2758f71b09d34e339d4b7b
Aaron Schulz [Tue, 8 Oct 2013 02:30:10 +0000 (19:30 -0700)]
Made root job de-duplication work without cache setup
bug: 55454
Change-Id: I9fbc1e34b4b771a16e567a1a16e2720af4379188
Translation updater bot [Tue, 8 Oct 2013 00:59:50 +0000 (00:59 +0000)]
Merge "Localisation updates from translatewiki.net."
Aaron Schulz [Mon, 7 Oct 2013 16:38:25 +0000 (09:38 -0700)]
Removed RC query UNION
* MySQL is smart enough that this is no longer needed
Change-Id: If173cdc53599cd02068ce2480ab667c5f9e69b76
jenkins-bot [Tue, 8 Oct 2013 00:23:37 +0000 (00:23 +0000)]
Merge "mediawiki.action.edit.preview: Clean up and optimisation"
jenkins-bot [Tue, 8 Oct 2013 00:17:53 +0000 (00:17 +0000)]
Merge "Add script to purge changed pages from cache"
Timo Tijhof [Mon, 7 Oct 2013 23:01:45 +0000 (01:01 +0200)]
Make .transition mixin take only 1 value and fix usage
Follows-up
99c92a87fc which turned
transition: left 250ms;
transition: margin-left 250ms, padding 250ms
into:
transition: 'left 250ms';
transition: margin-left 250ms padding 250ms
> Invalid CSS property value: 'left 250ms'
> Invalid CSS property value: margin-left 250ms padding 250ms
Removed quotes from 'left 250ms' which was producing invalid CSS.
The @arguments operator in Less joins a variadic list of
arguments by space. In the case of .transition this is a problem
because its values are supposed to be separated by a comma
(like background-image and font-family).
Changing the .transition definition to take only 1 argument
instead of multiple (...). There is no point in supporting
multiple arguments. All it does is it take away our ability to
spot these errors at parse time (Less would be able to throw an
error for passing a 2 arguments to a mixin that only takes 1).
Fixed the invocation with 2 arguments to instead pass 1 argument
that has a comma in it. Both "~'a,b'" and "a, b;" would work here
(doesn't matter) choosing ; here because for consistency with calls
that do use mutiple argments:
foo(~'foo, bar', ~'baz, quux')
foo(foo, bar; baz, quux)
Change-Id: I80786c726a412d6b9e04c384112849e9587990b4
Bryan Davis [Tue, 1 Oct 2013 17:29:56 +0000 (11:29 -0600)]
Add script to purge changed pages from cache
This maintenance script could be used to recover from large HTCP
listener outages and/or network partitions. It searches the database for
pages having revisions occurring within a specified time period,
converts them to full URLs and sends squid/varnish purge messages using
SquidUpdate. A command line option allows specifying a specific
IP:port combination for HTCP purge datagrams which can be used to
isolate the purge announcement to a particular varnish server or data
center.
Co-Authored by: Aaron Schulz <aschulz@wikimedia.org>
Bug: 54647
Change-Id: Id0e95290e83333545e6bb0378cc620c35c653bf9
Translation updater bot [Mon, 7 Oct 2013 21:16:52 +0000 (21:16 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Ib6cdd80506e78608d9d8af15088020528fdec256
jenkins-bot [Mon, 7 Oct 2013 21:13:38 +0000 (21:13 +0000)]
Merge "mediawiki.Title: Fix weird <h1> in constructor description"
Timo Tijhof [Fri, 30 Aug 2013 00:31:37 +0000 (17:31 -0700)]
resourceloader: Support hashes as cache invalidation trigger
For now ResourceLoader will still internally deal with timestamps,
especially because they are easier to max() on the client side
(on the server we could make a hash of different hashes, on the
client that's a bit annoying).
However ResourceLoaderModule#getHashMtime will abstract the logic
we already use in ResourceLoaderLanguageDataModule and have
encouraged others to use, which is to put the timestamp and
hash in Memcached, and use that to observer the hash change and
update the timestamp when it does.
Updated ResourceLoaderLanguageDataModule to make use of this.
Change-Id: Ib051ef41ba239084671c30fd275b8d94099d5d52
csteipp [Mon, 7 Oct 2013 19:47:43 +0000 (12:47 -0700)]
Move forceHTTPS check until after wgTitle is setup
Since the forceHTTPS logic checks if the user is logged in, which calls
all sorts of hooks, some that assume that $wgTitle is setup (like
AbuseFilter for preventing autocreation of usernames), move the
logic down a few lines.
Bug: 55435
Bug: 53498
Change-Id: I53c82921595a9014b555e4ec468e5ba10454cd3a
Timo Tijhof [Mon, 7 Oct 2013 19:38:10 +0000 (21:38 +0200)]
mediawiki.Title: Fix weird <h1> in constructor description
The leading '#' was triggering a Markdown heading instead of a
jsduck reference. Working around by moving the line break.
Change-Id: I8bf2719938c3c4a092ce5499bae0c7b88f4544c1
Brad Jorsch [Mon, 7 Oct 2013 18:58:27 +0000 (14:58 -0400)]
Allow $context->setTitle( null )
If something is messing around with $wgTitle before MediaWiki::main()
sets $wgTitle in the first place, it needs to be able to reset it back
to null to avoid a problem like bug 53498. And to do that properly, it
also needs to be able to clear the title in the RequestContext.
Bug: 55435
Change-Id: I6c763b70bbffa0762ca52e61acf7dc200da4075f
Reedy [Mon, 7 Oct 2013 18:46:02 +0000 (19:46 +0100)]
Fix "Unsupported operand types at thumb.php on line 429"
Return type of $handler->parseParamString() wasn't evaluated,
instead $handler value was compared again
Bug: 55437
Change-Id: Iedb940d9f1ad4d137b9732e7e624e55d05bc2c96
jenkins-bot [Mon, 7 Oct 2013 18:23:53 +0000 (18:23 +0000)]
Merge "Accessibility: Don't remove checkbox outline on focus"
Derk-Jan Hartman [Sun, 25 Aug 2013 13:22:39 +0000 (15:22 +0200)]
Accessibility: Don't remove checkbox outline on focus
Native checkboxes and radiobuttons on Mac OS X are not fully
styleable. Don't remove the focus ring for those elements because it
makes them less accessible.
Also the outline was removed outside of the focus selector, which
isn't really needed.
Change-Id: I716c84b34b5adb26691f0d4ecd13739de7b8bdbf
umherirrender [Sat, 5 Oct 2013 08:25:11 +0000 (10:25 +0200)]
Move release note for meta=filerepoinfo into api section
Follow-Up: I1aaed0895d2a0bc224c82e93975ecf6afd8cb6b8
Change-Id: I83e393aca85ae215f515024322942acafa20462b
Timo Tijhof [Sun, 6 Oct 2013 21:27:37 +0000 (23:27 +0200)]
mediawiki.action.edit.preview: Clean up and optimisation
* Remove redundant inline 'position: absolute' on the spinner.
* Remove trailing white space in jquery.spinner.css.
* Cache #editform query result.
* Remove redundant removeSelectors.join(',') logic.
* White space.
* Move delegate click event listener down from body to #editform
(the common ancestor of the #wpDiff and #wpPreview buttons).
* Remove minHeight (was needed because the spinner was positioned
absolute), which gets rid of the weird white gap for #wikiPreview if
you do live diff instead of live preview.
Change-Id: Icdf975f201947ecadb886057131f2531c68791fb
jenkins-bot [Mon, 7 Oct 2013 17:01:40 +0000 (17:01 +0000)]
Merge "Remove placeholder tests"
Siebrand Mazeland [Mon, 7 Oct 2013 08:59:41 +0000 (10:59 +0200)]
Set 'tooltip-iwiki' as optional
Spotted by Beta16 in
https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Tooltip-iwiki/en
Change-Id: Ib60dd6072728238684112865a5ee0b015d1f2f0c
Kunal Mehta [Sun, 6 Oct 2013 23:44:04 +0000 (16:44 -0700)]
Remove redundant parentheses
Change-Id: I848e6a055df748ac758082372fe3b86f6f323cc9
Timo Tijhof [Sun, 6 Oct 2013 23:17:29 +0000 (01:17 +0200)]
Follow-up
d94d29a920: Fix typo in release notes
Change-Id: Ic2cb19df45193b260d785fda5acf2ce956b51dde
Timo Tijhof [Sun, 6 Oct 2013 22:25:15 +0000 (00:25 +0200)]
postEdit: Add documentation for hook so it shows up in the index
Follows-up
011ee683a.
Change-Id: I3ce89a91f6a299516dd8dfb93dd5cc5b784fa471
MatmaRex [Sat, 24 Aug 2013 20:37:58 +0000 (22:37 +0200)]
Special:UserLogin UI improvements when user is logged in
* Show a warning about being already logged in above login form
* Show a button pointing to signup form with suitable explanation
Also changed some internal template stuff (s/createAnother/loggedin/).
Bug: 53306
Change-Id: I1672ee09330c231110c4db310a645d1382cc0b59
MatmaRex [Fri, 30 Aug 2013 20:57:58 +0000 (22:57 +0200)]
mediawiki.special.vforms: Information boxes' styles
Only styles appropriate for errorbox were defined, but they were
applied to all boxes - contrary to the comment above, Vector doesn't
have styles for them (they are shared for all skins, and they are
awful), and they were anyway overriden by these due to selector
specificity.
Added styles for successbox and warningbox with composition on the
color wheel very similar to errorbox one, simply rotated and scaled.
Removed misleading comment.
Change-Id: I68d2c9b98a9166f5781fcded0318cca52ed6f2e6
jenkins-bot [Sat, 5 Oct 2013 14:51:45 +0000 (14:51 +0000)]
Merge "(bug 54980) Remove toolbox UserRights if anon user"
addshore [Sat, 5 Oct 2013 14:20:52 +0000 (16:20 +0200)]
(bug 54980) Remove toolbox UserRights if anon user
Change-Id: Ie489ce327a56cf314c9dc525d6bd3eaa39739260
Ori Livneh [Tue, 1 Oct 2013 23:20:45 +0000 (16:20 -0700)]
Make the format of UDP-logged stats configurable
The format of datagrams generated by StatCounter and ProfilerSimpleUDP is not
described by any standard and appears to have been designed for compatibility
with the logging setup of the Wikimedia Foundation, which limits reusability.
This patch adds two configuration variables, $wgUDPProfilerFormatString and
$wgStatsFormatString, that can be used to specify the precise format that
MediaWiki will use. The default values for these variables causes MediaWiki to
generate the same output as before.
The secret evil plan is to change the defaults so that MediaWiki emits metrics
that are compatible with the popular StatsD format (see
<https://github.com/b/statsd_spec>). This would allow us to replace udpprofiler
with a generic StatsD instance instead.
Change-Id: Iaf00811d3f8d6b89c1c68e84fc1f2c93425d5a2d