From: Alexandre Emsenhuber <ialex@users.mediawiki.org>
Date: Sun, 23 Jan 2011 20:27:26 +0000 (+0000)
Subject: Assignment inside if clause is bad
X-Git-Tag: 1.31.0-rc.0~32400
X-Git-Url: https://git.cyclocoop.org/%28%28?a=commitdiff_plain;h=c4e874e03735ec565a8cc7fb3b362c45111ebcf0;p=lhc%2Fweb%2Fwiklou.git

Assignment inside if clause is bad
---

diff --git a/includes/specials/SpecialVersion.php b/includes/specials/SpecialVersion.php
index 56f543505d..3118f65cb6 100644
--- a/includes/specials/SpecialVersion.php
+++ b/includes/specials/SpecialVersion.php
@@ -315,7 +315,8 @@ class SpecialVersion extends SpecialPage {
 			$out .= '<tr><td colspan="4">' . $this->listToText( $tags ). "</td></tr>\n";
 		}
 
-		if( count( $fhooks = $wgParser->getFunctionHooks() ) ) {
+		$fhooks = $wgParser->getFunctionHooks();
+		if( count( $fhooks ) ) {
 			$out .= $this->openExtType( wfMsg( 'version-parser-function-hooks' ), 'parser-function-hooks' );
 			$out .= '<tr><td colspan="4">' . $this->listToText( $fhooks ) . "</td></tr>\n";
 		}