From: Daniel Friesen <daniel@nadir-seen-fire.com>
Date: Wed, 13 Aug 2014 19:36:28 +0000 (-0700)
Subject: Fix documentation.
X-Git-Tag: 1.31.0-rc.0~14448^2
X-Git-Url: https://git.cyclocoop.org/%28%28?a=commitdiff_plain;h=9f75d9c63c091feed92c82033c116ff6cdeb9829;p=lhc%2Fweb%2Fwiklou.git

Fix documentation.

It's true that right now the internal skin name doesn't have to be all-lowercase,
however not doing so leads to side effects such as the changing of case of i18n message keys,
if the documentation makes programmers aware that something other than all-lowercase can
be used, they should also be aware of the side effects of doing so.

Change-Id: Ib1ed192b1ba83ae864313c34b450a1151485750b
---

diff --git a/includes/skins/SkinFactory.php b/includes/skins/SkinFactory.php
index d5f25463e6..0935e3347e 100644
--- a/includes/skins/SkinFactory.php
+++ b/includes/skins/SkinFactory.php
@@ -66,8 +66,8 @@ class SkinFactory {
 	 *
 	 * Will override if it's already registered.
 	 *
-	 * @param string $name Internal skin name. Should be all-lowercase (but technically doesn't have
-	 *     to be).
+	 * @param string $name Internal skin name. Should be all-lowercase (technically doesn't have
+	 *     to be, but doing so would change the case of i18n message keys).
 	 * @param string $displayName For backwards-compatibility with old skin loading system. This is
 	 *     the text used as skin's human-readable name when the 'skinname-<skin>' message is not
    *     available. It should be the same as the skin name provided in $wgExtensionCredits.