From: Aaron Schulz <aschulz@wikimedia.org>
Date: Wed, 21 Sep 2016 18:20:22 +0000 (-0700)
Subject: Fix IDEA warnings in CloneDatabase
X-Git-Tag: 1.31.0-rc.0~5411^2
X-Git-Url: https://git.cyclocoop.org/%28%28?a=commitdiff_plain;h=86ce9b388a363e533d1fa985959c71d636d81706;p=lhc%2Fweb%2Fwiklou.git

Fix IDEA warnings in CloneDatabase

Change-Id: I45231237dd49dfdd8158a68d8f63d769b762f19c
---

diff --git a/includes/db/CloneDatabase.php b/includes/db/CloneDatabase.php
index 2af742e971..f1ccd2aebd 100644
--- a/includes/db/CloneDatabase.php
+++ b/includes/db/CloneDatabase.php
@@ -23,6 +23,7 @@
  * @file
  * @ingroup Database
  */
+use MediaWiki\MediaWikiServices;
 
 class CloneDatabase {
 	/** @var string Table prefix for cloning */
@@ -40,16 +41,19 @@ class CloneDatabase {
 	/** @var bool Whether to use temporary tables or not */
 	private $useTemporaryTables = true;
 
+	/** @var Database */
+	private $db;
+
 	/**
 	 * Constructor
 	 *
-	 * @param IDatabase $db A database subclass
+	 * @param Database $db A database subclass
 	 * @param array $tablesToClone An array of tables to clone, unprefixed
 	 * @param string $newTablePrefix Prefix to assign to the tables
 	 * @param string $oldTablePrefix Prefix on current tables, if not $wgDBprefix
 	 * @param bool $dropCurrentTables
 	 */
-	public function __construct( IDatabase $db, array $tablesToClone,
+	public function __construct( Database $db, array $tablesToClone,
 		$newTablePrefix, $oldTablePrefix = '', $dropCurrentTables = true
 	) {
 		$this->db = $db;
@@ -130,7 +134,7 @@ class CloneDatabase {
 	public static function changePrefix( $prefix ) {
 		global $wgDBprefix;
 
-		$lbFactory = wfGetLBFactory();
+		$lbFactory = MediaWikiServices::getInstance()->getDBLoadBalancerFactory();
 		$lbFactory->setDomainPrefix( $prefix );
 		$wgDBprefix = $prefix;
 	}