From: James D. Forrester <jforrester@wikimedia.org>
Date: Thu, 19 May 2016 15:06:59 +0000 (+0100)
Subject: build: Enforce stylelints on fonts
X-Git-Tag: 1.31.0-rc.0~6862^2~1
X-Git-Url: https://git.cyclocoop.org/%28%28?a=commitdiff_plain;h=82d6f1d89fb4521ea2355832aff4b4e0f9ba27fa;p=lhc%2Fweb%2Fwiklou.git

build: Enforce stylelints on fonts

* Font families should be quoted unless keywords (''Times'' not 'Times')
* Font weights should be named where possible ('bold' not '700')

Change-Id: I20194c2998efb71db4da5ea79234a81dc90b55ea
---

diff --git a/.stylelintrc b/.stylelintrc
index ca0af95552..e8e156708d 100644
--- a/.stylelintrc
+++ b/.stylelintrc
@@ -9,5 +9,8 @@
 		"declaration-bang-space-before": [ "always" ],
 		"declaration-colon-space-after": [ "always" ],
 		"declaration-colon-space-before": [ "never" ],
+
+		"font-family-name-quotes": [ "single-unless-keyword" ],
+		"font-weight-notation": [ "named-where-possible" ]
 	}
 }
diff --git a/mw-config/config-cc.css b/mw-config/config-cc.css
index 29dc80c67c..f9c61178aa 100644
--- a/mw-config/config-cc.css
+++ b/mw-config/config-cc.css
@@ -5,7 +5,7 @@
 body {
 	margin: 0;
 	background: #eee;
-	font-family: Verdana;
+	font-family: 'Verdana';
 	color: #333;
 }
 
diff --git a/resources/src/mediawiki.skinning/elements.css b/resources/src/mediawiki.skinning/elements.css
index f267784b12..7b0b071f46 100644
--- a/resources/src/mediawiki.skinning/elements.css
+++ b/resources/src/mediawiki.skinning/elements.css
@@ -195,7 +195,7 @@ pre, code, tt, kbd, samp, .mw-code {
 	 * Some browsers will render the monospace text too small, namely Firefox, Chrome and Safari.
 	 * Specifying any valid, second value will trigger correct behavior without forcing a different font.
 	 */
-	font-family: monospace, Courier;
+	font-family: monospace, 'Courier';
 }
 
 code {
diff --git a/resources/src/mediawiki.special/mediawiki.special.userlogin.signup.css b/resources/src/mediawiki.special/mediawiki.special.userlogin.signup.css
index 0998d4cab8..87cdb023cb 100644
--- a/resources/src/mediawiki.special/mediawiki.special.userlogin.signup.css
+++ b/resources/src/mediawiki.special/mediawiki.special.userlogin.signup.css
@@ -45,7 +45,7 @@ div.mw-createacct-benefits-container h2 {
 	margin: 0;
 	padding: 0;
 	color: #252525;
-	font-family: "Linux Libertine", Georgia, Times, serif;
+	font-family: 'Linux Libertine', 'Georgia', 'Times', serif;
 	font-weight: normal;
 	font-size: 2.2em;
 	line-height: 1.2;