From: Alexandre Emsenhuber <ialex.wiki@gmail.com>
Date: Fri, 13 Apr 2012 08:30:57 +0000 (+0200)
Subject: Removed subclassing of PageQueryPage where not needed.
X-Git-Tag: 1.31.0-rc.0~23883^2
X-Git-Url: https://git.cyclocoop.org/%28%28?a=commitdiff_plain;h=78a8aa828e335593003a0caa1c743eca2050ec64;p=lhc%2Fweb%2Fwiklou.git

Removed subclassing of PageQueryPage where not needed.

These three classes (BrokenRedirectsPage, DisambiguationsPage and DoubleRedirectsPage) override formatResult() which is the only method defined in PageQueryPage; they can thus directly subclass QueryPage.
It also confused me when trying to find a page extending PageQueryPage to test my changes in PageQueryPage::formatResult().

Change-Id: Ic0923935b67a09e868367db6a21ef92305b4f8ee
---

diff --git a/includes/specials/SpecialBrokenRedirects.php b/includes/specials/SpecialBrokenRedirects.php
index b8dbe9e862..d6244300dc 100644
--- a/includes/specials/SpecialBrokenRedirects.php
+++ b/includes/specials/SpecialBrokenRedirects.php
@@ -27,7 +27,7 @@
  *
  * @ingroup SpecialPage
  */
-class BrokenRedirectsPage extends PageQueryPage {
+class BrokenRedirectsPage extends QueryPage {
 
 	function __construct( $name = 'BrokenRedirects' ) {
 		parent::__construct( $name );
diff --git a/includes/specials/SpecialDisambiguations.php b/includes/specials/SpecialDisambiguations.php
index 8f780b5890..a5ab3e69f9 100644
--- a/includes/specials/SpecialDisambiguations.php
+++ b/includes/specials/SpecialDisambiguations.php
@@ -26,7 +26,7 @@
  *
  * @ingroup SpecialPage
  */
-class DisambiguationsPage extends PageQueryPage {
+class DisambiguationsPage extends QueryPage {
 
 	function __construct( $name = 'Disambiguations' ) {
 		parent::__construct( $name );
diff --git a/includes/specials/SpecialDoubleRedirects.php b/includes/specials/SpecialDoubleRedirects.php
index a6df66f606..51cb08af6e 100644
--- a/includes/specials/SpecialDoubleRedirects.php
+++ b/includes/specials/SpecialDoubleRedirects.php
@@ -27,7 +27,7 @@
  *
  * @ingroup SpecialPage
  */
-class DoubleRedirectsPage extends PageQueryPage {
+class DoubleRedirectsPage extends QueryPage {
 
 	function __construct( $name = 'DoubleRedirects' ) {
 		parent::__construct( $name );