From: Aaron Schulz <aschulz@wikimedia.org>
Date: Tue, 20 Sep 2016 18:12:26 +0000 (-0700)
Subject: Fix IDEA Ultimate warnings in ChangeTags
X-Git-Tag: 1.31.0-rc.0~5455^2
X-Git-Url: https://git.cyclocoop.org/%28%28?a=commitdiff_plain;h=6d2e348410cd5496dadbca89a7e290c061ef8ff0;p=lhc%2Fweb%2Fwiklou.git

Fix IDEA Ultimate warnings in ChangeTags

Change-Id: Ie0778e5e32be81bda246d231526630db700b8538
---

diff --git a/includes/changetags/ChangeTags.php b/includes/changetags/ChangeTags.php
index 3ef9641d9c..6455a3a980 100644
--- a/includes/changetags/ChangeTags.php
+++ b/includes/changetags/ChangeTags.php
@@ -571,7 +571,7 @@ class ChangeTags {
 			// This function is from revision deletion logic and has nothing to do with
 			// change tags, but it appears to be the only other place in core where we
 			// perform logged actions on log items.
-			$logEntry->setTarget( RevDelLogList::suggestTarget( 0, [ $log_id ] ) );
+			$logEntry->setTarget( RevDelLogList::suggestTarget( null, [ $log_id ] ) );
 		}
 
 		if ( !$logEntry->getTarget() ) {
@@ -1038,7 +1038,7 @@ class ChangeTags {
 		// let's not allow error results, as the actual tag deletion succeeded
 		if ( !$status->isOK() ) {
 			wfDebug( 'ChangeTagAfterDelete error condition downgraded to warning' );
-			$status->ok = true;
+			$status->setOK( true );
 		}
 
 		// clear the memcache of defined tags