From: Sam Reed <reedy@users.mediawiki.org>
Date: Wed, 23 Feb 2011 12:35:41 +0000 (+0000)
Subject: Ununsed variables
X-Git-Tag: 1.31.0-rc.0~31817
X-Git-Url: https://git.cyclocoop.org/%28%28?a=commitdiff_plain;h=64be8c7b26661fd8a56abc5a2156bb388e4d0d95;p=lhc%2Fweb%2Fwiklou.git

Ununsed variables

Documentation and explicit definitions
---

diff --git a/includes/ChangesList.php b/includes/ChangesList.php
index 9e2d43c823..782a229cac 100644
--- a/includes/ChangesList.php
+++ b/includes/ChangesList.php
@@ -115,7 +115,7 @@ class ChangesList {
 				'botedit' => array( 'boteditletter', 'recentchanges-label-bot' ),
 				'unpatrolled' => array( 'unpatrolledletter', 'recentchanges-label-unpatrolled' ), 
 			);
-			foreach( $messages as $key => &$value ) {
+			foreach( $messages as &$value ) {
 				$value[0] = wfMsgExt( $value[0], 'escapenoentities' );
 				$value[1] = wfMsgExt( $value[1], 'escapenoentities' );
 			}
diff --git a/includes/SkinTemplate.php b/includes/SkinTemplate.php
index 4f60d55019..c62bafc68e 100644
--- a/includes/SkinTemplate.php
+++ b/includes/SkinTemplate.php
@@ -1713,7 +1713,7 @@ abstract class BaseTemplate extends QuickTemplate {
 
 		if ( $option == 'icononly' ) {
 			// Unset any icons which don't have an image
-			foreach ( $footericons as $footerIconsKey => &$footerIconsBlock ) {
+			foreach ( $footericons as &$footerIconsBlock ) {
 				foreach ( $footerIconsBlock as $footerIconKey => $footerIcon ) {
 					if ( !is_string( $footerIcon ) && !isset( $footerIcon['src'] ) ) {
 						unset( $footerIconsBlock[$footerIconKey] );
diff --git a/includes/installer/MysqlInstaller.php b/includes/installer/MysqlInstaller.php
index 8e419decb6..c5a01e32e7 100644
--- a/includes/installer/MysqlInstaller.php
+++ b/includes/installer/MysqlInstaller.php
@@ -349,7 +349,7 @@ class MysqlInstaller extends DatabaseInstaller {
 	}
 
 	public function submitSettingsForm() {
-		$newValues = $this->setVarsFromRequest( array( '_MysqlEngine', '_MysqlCharset' ) );
+		$this->setVarsFromRequest( array( '_MysqlEngine', '_MysqlCharset' ) );
 		$status = $this->submitWebUserBox();
 		if ( !$status->isOK() ) {
 			return $status;
diff --git a/includes/installer/PostgresInstaller.php b/includes/installer/PostgresInstaller.php
index 8ebd39453e..1e55737c65 100644
--- a/includes/installer/PostgresInstaller.php
+++ b/includes/installer/PostgresInstaller.php
@@ -162,7 +162,6 @@ class PostgresInstaller extends DatabaseInstaller {
 		}
 
 		// Validate the create checkbox
-		$create = true;
 		$canCreate = $this->canCreateAccounts();
 		if ( $canCreate ) {
 			$this->setVar( '_CreateDBAccount', false );
@@ -314,7 +313,6 @@ class PostgresInstaller extends DatabaseInstaller {
 
 	public function createTables() {
 		$schema = $this->getVar( 'wgDBmwschema' );
-		$user = $this->getVar( 'wgDBuser' );
 
 		$this->db = null;
 		$this->useAdmin = false;
diff --git a/includes/search/SearchPostgres.php b/includes/search/SearchPostgres.php
index f32e898b20..0e5dc9bad6 100644
--- a/includes/search/SearchPostgres.php
+++ b/includes/search/SearchPostgres.php
@@ -139,8 +139,6 @@ class SearchPostgres extends SearchEngine {
 	 * @param $colname
 	 */
 	function searchQuery( $term, $fulltext, $colname ) {
-		$postgresVersion = $this->db->getServerVersion();
-
 		# Get the SQL fragment for the given term
 		$searchstring = $this->parseQuery( $term );
 
diff --git a/includes/specials/SpecialAllmessages.php b/includes/specials/SpecialAllmessages.php
index d475d5fea4..1f39971fab 100644
--- a/includes/specials/SpecialAllmessages.php
+++ b/includes/specials/SpecialAllmessages.php
@@ -29,6 +29,11 @@
  */
 class SpecialAllmessages extends SpecialPage {
 
+	/**
+	 * @var AllmessagesTablePager
+	 */
+	protected $table;
+
 	/**
 	 * Constructor
 	 */
@@ -59,7 +64,7 @@ class SpecialAllmessages extends SpecialPage {
 
 		$this->table = new AllmessagesTablePager(
 			$this,
-			$conds = array(),
+			array(),
 			wfGetLangObj( $wgRequest->getVal( 'lang', $par ) )
 		);
 
@@ -151,6 +156,11 @@ class AllmessagesTablePager extends TablePager {
 
 	public $mLimitsShown;
 
+	/**
+	 * @var Language 
+	 */
+	public $lang;
+
 	function __construct( $page, $conds, $langObj = null ) {
 		parent::__construct();
 		$this->mIndexField = 'am_title';