From: umherirrender Date: Thu, 29 Jan 2015 19:54:06 +0000 (+0100) Subject: Handle invalid grouppage on Special:Statistics X-Git-Tag: 1.31.0-rc.0~12410^2 X-Git-Url: https://git.cyclocoop.org/%28%28?a=commitdiff_plain;h=3eb11888e97b11aeb6dc75a2376db2af28d24050;p=lhc%2Fweb%2Fwiklou.git Handle invalid grouppage on Special:Statistics Passing null to Linker::link gives warning on the side Change-Id: Ibee9eb039e88c23ba38ff6594f449316b22ecba6 --- diff --git a/includes/specials/SpecialStatistics.php b/includes/specials/SpecialStatistics.php index 44290220ef..1f339d1ed0 100644 --- a/includes/specials/SpecialStatistics.php +++ b/includes/specials/SpecialStatistics.php @@ -199,10 +199,16 @@ class SpecialStatistics extends SpecialPage { $grouppageLocalized = $msg->text(); } $linkTarget = Title::newFromText( $grouppageLocalized ); - $grouppage = Linker::link( - $linkTarget, - htmlspecialchars( $groupnameLocalized ) - ); + + if ( $linkTarget ) { + $grouppage = Linker::link( + $linkTarget, + htmlspecialchars( $groupnameLocalized ) + ); + } else { + $grouppage = htmlspecialchars( $groupnameLocalized ); + } + $grouplink = Linker::linkKnown( SpecialPage::getTitleFor( 'Listusers' ), $this->msg( 'listgrouprights-members' )->escaped(),