From: Reedy <reedy@wikimedia.org>
Date: Sat, 28 Apr 2012 01:30:53 +0000 (+0100)
Subject: __clone() is a public method, shouldn't be made protected
X-Git-Tag: 1.31.0-rc.0~23792^2
X-Git-Url: https://git.cyclocoop.org/%28%28?a=commitdiff_plain;h=15e5d99ad873cc60e5367a917195015a7b89a6cb;p=lhc%2Fweb%2Fwiklou.git

__clone() is a public method, shouldn't be made protected

Change-Id: Ib4a716867b12be2cef90f87bc77c22ea2d890261
---

diff --git a/includes/filerepo/backend/FileBackendGroup.php b/includes/filerepo/backend/FileBackendGroup.php
index 73815cfbdd..d705f76057 100644
--- a/includes/filerepo/backend/FileBackendGroup.php
+++ b/includes/filerepo/backend/FileBackendGroup.php
@@ -21,7 +21,6 @@ class FileBackendGroup {
 	protected $backends = array();
 
 	protected function __construct() {}
-	protected function __clone() {}
 
 	/**
 	 * @return FileBackendGroup
diff --git a/includes/filerepo/backend/lockmanager/LockManager.php b/includes/filerepo/backend/lockmanager/LockManager.php
index 506d8504ea..9f29eb3b6f 100644
--- a/includes/filerepo/backend/lockmanager/LockManager.php
+++ b/includes/filerepo/backend/lockmanager/LockManager.php
@@ -139,8 +139,6 @@ class ScopedLock {
 		$this->type = $type;
 	}
 
-	protected function __clone() {}
-
 	/**
 	 * Get a ScopedLock object representing a lock on resource paths.
 	 * Any locks are released once this object goes out of scope.
diff --git a/includes/filerepo/backend/lockmanager/LockManagerGroup.php b/includes/filerepo/backend/lockmanager/LockManagerGroup.php
index 5e533667e7..8465d58bbd 100644
--- a/includes/filerepo/backend/lockmanager/LockManagerGroup.php
+++ b/includes/filerepo/backend/lockmanager/LockManagerGroup.php
@@ -17,8 +17,6 @@ class LockManagerGroup {
 	protected $managers = array();
 
 	protected function __construct() {}
-	protected function __clone() {}
-
 	/**
 	 * @return LockManagerGroup
 	 */