From: Alexandre Emsenhuber <ialex@users.mediawiki.org>
Date: Sun, 14 Dec 2008 18:41:30 +0000 (+0000)
Subject: * removed useless check for $wgAllowUserSkin since we're already checked for it 18... 
X-Git-Tag: 1.31.0-rc.0~43967
X-Git-Url: https://git.cyclocoop.org/%28%28?a=commitdiff_plain;h=02b2f9b66dae231c3d3990d2070dd8f2a868e27b;p=lhc%2Fweb%2Fwiklou.git

* removed useless check for $wgAllowUserSkin since we're already checked for it 18 lines above
* wfHidden() -> Xml::hidden()
---

diff --git a/includes/specials/SpecialPreferences.php b/includes/specials/SpecialPreferences.php
index d82e56525b..06f8a221d5 100644
--- a/includes/specials/SpecialPreferences.php
+++ b/includes/specials/SpecialPreferences.php
@@ -783,7 +783,7 @@ class PreferencesForm {
 		} else {
 			# Need to output a hidden option even if the relevant skin is not in use,
 			# otherwise the preference will get reset to 0 on submit
-			$wgOut->addHTML( wfHidden( 'wpQuickbar', $this->mQuickbar ) );
+			$wgOut->addHTML( Xml::hidden( 'wpQuickbar', $this->mQuickbar ) );
 		}
 
 		# Skin
@@ -807,7 +807,7 @@ class PreferencesForm {
 			foreach ($validSkinNames as $skinkey => $sn ) {
 				$checked = $skinkey == $this->mSkin ? ' checked="checked"' : '';
 				$mplink = htmlspecialchars($mptitle->getLocalURL("useskin=$skinkey"));
-				$previewlink = $wgAllowUserSkin ? "(<a target='_blank' href=\"$mplink\">$previewtext</a>)" : '';
+				$previewlink = "(<a target='_blank' href=\"$mplink\">$previewtext</a>)";
 				if( $skinkey == $wgDefaultSkin )
 					$sn .= ' (' . wfMsg( 'default' ) . ')';
 				$wgOut->addHTML( "<input type='radio' name='wpSkin' id=\"wpSkin$skinkey\" value=\"$skinkey\"$checked /> <label for=\"wpSkin$skinkey\">{$sn}</label> $previewlink<br />\n" );