(bug 43315) Cursor of enhancedchangelist wrong for non-toggle lines

The class mw-enhancedchanges-arrow was also used for non-toggle lines,
which have now the cursor. Now using mw-enhancedchanges-arrow-space for
the space and mw-enhancedchanges-arrow for the cursor.

Also fix bad aligned lines, when javascript is disabled. Here the
problem was, that only the arrows are display:noned, but the placeholder
space of single lines must also be display:noned.

Change-Id: Iba13987ced4c3e327026df2cb96b92a777e2032f

diff --git a/includes/ChangesList.php b/includes/ChangesList.php
index 0bd16f7..3e3f542 100644 (file)
--- a/includes/ChangesList.php
+++ b/includes/ChangesList.php
@@ -933,7 +933,7 @@ class EnhancedChangesList extends ChangesList {
                                implode( $this->message['semicolon-separator'], $users )
                        )->escaped() . '</span>';
 
-               $tl = '<span class="mw-collapsible-toggle mw-enhancedchanges-arrow"></span>';
+               $tl = '<span class="mw-collapsible-toggle mw-enhancedchanges-arrow mw-enhancedchanges-arrow-space"></span>';
                $r .= "<td>$tl</td>";
 
                # Main line
@@ -1187,7 +1187,7 @@ class EnhancedChangesList extends ChangesList {
                $r = Html::openElement( 'table', array( 'class' => $classes ) ) .
                        Html::openElement( 'tr' );
 
-               $r .= '<td class="mw-enhanced-rc"><span class="mw-enhancedchanges-arrow mw-enhancedchanges-arrow-space"></span>';
+               $r .= '<td class="mw-enhanced-rc"><span class="mw-enhancedchanges-arrow-space"></span>';
                # Flag and Timestamp
                if( $type == RC_MOVE || $type == RC_MOVE_OVER_REDIRECT ) {
                        $r .= '&#160;&#160;&#160;&#160;'; // 4 flags -> 4 spaces

diff --git a/resources/mediawiki.special/mediawiki.special.changeslist.css b/resources/mediawiki.special/mediawiki.special.changeslist.css
index 3589ea1..fcdeba1 100644 (file)
--- a/resources/mediawiki.special/mediawiki.special.changeslist.css
+++ b/resources/mediawiki.special/mediawiki.special.changeslist.css
@@ -31,22 +31,22 @@ table.mw-enhanced-rc td.mw-enhanced-rc-nested {
        float: none;
 }
 
-/* If JS is disabled, the arrow shouldn't be shown */
-.client-nojs .mw-enhancedchanges-arrow.mw-collapsible-toggle {
+/* If JS is disabled, the arrows or the placeholder space shouldn't be shown */
+.client-nojs .mw-enhancedchanges-arrow-space {
        display: none;
 }
 
-.mw-enhancedchanges-arrow {
+.mw-enhancedchanges-arrow-space {
        display: inline-block;
        *display: inline; /* IE7 and below */
        zoom: 1;
        width: 15px;
        height: 15px;
-       cursor: pointer;
 }
 
-.mw-enhancedchanges-arrow.mw-enhancedchanges-arrow-space {
-       background: none;
+/* let it look like it is clickable */
+.mw-enhancedchanges-arrow.mw-collapsible-toggle {
+       cursor: pointer;
 }
 
 .mw-enhancedchanges-arrow.mw-collapsible-toggle-collapsed {