Return log id for file deletions
authorBrad Jorsch <bjorsch@wikimedia.org>
Wed, 7 Oct 2015 14:19:36 +0000 (10:19 -0400)
committerBrad Jorsch <bjorsch@wikimedia.org>
Wed, 7 Oct 2015 14:19:36 +0000 (10:19 -0400)
WikiPage::doDeleteArticleReal returns the log id as the value of the
returned Status object, and ApiDelete depends on this. ApiDelete is also
expecting FileDeleteForm::doDelete to do the same, so let's make it
happen.

Bug: T114893
Change-Id: Ia887d88f16378134924d122dad6c17c8a981f0e6

includes/FileDeleteForm.php

index bcd6db2..5e7f5b2 100644 (file)
@@ -180,6 +180,8 @@ class FileDeleteForm {
                                $logEntry->setComment( $logComment );
                                $logid = $logEntry->insert();
                                $logEntry->publish( $logid );
+
+                               $status->value = $logid;
                        }
                } else {
                        $status = Status::newFatal( 'cannotdelete',
@@ -197,6 +199,7 @@ class FileDeleteForm {
                                        $status = $file->delete( $reason, $suppress, $user );
                                        if ( $status->isOK() ) {
                                                $dbw->commit( __METHOD__ );
+                                               $status->value = $deleteStatus->value; // log id
                                        } else {
                                                $dbw->rollback( __METHOD__ );
                                        }