resourceloader: Cut down on file stat time in safeFilemtime()
authorAaron Schulz <aschulz@wikimedia.org>
Tue, 31 Mar 2015 07:59:40 +0000 (00:59 -0700)
committerBryanDavis <bdavis@wikimedia.org>
Tue, 31 Mar 2015 17:10:57 +0000 (17:10 +0000)
* If stat cache is not enabled, this used to do two queries.

Change-Id: Icfed675b27f952ec13b9d0af3e345b1486ea7c8f

includes/resourceloader/ResourceLoaderModule.php

index d689044..572428e 100644 (file)
@@ -636,9 +636,10 @@ abstract class ResourceLoaderModule {
         * @return int UNIX timestamp
         */
        protected static function safeFilemtime( $filename ) {
-               if ( !file_exists( $filename ) ) {
-                       return 1;
-               }
-               return filemtime( $filename );
+               wfSuppressWarnings();
+               $mtime = filemtime( $filename ) ?: 1;
+               wfRestoreWarnings();
+
+               return $mtime;
        }
 }