(bug 27171) Incorrect error message during extension installation. lol @ PHP's scope...
authorMax Semenik <maxsem@users.mediawiki.org>
Fri, 25 Mar 2011 18:24:58 +0000 (18:24 +0000)
committerMax Semenik <maxsem@users.mediawiki.org>
Fri, 25 Mar 2011 18:24:58 +0000 (18:24 +0000)
includes/installer/Installer.php

index ef3f63c..e9f970b 100644 (file)
@@ -1196,7 +1196,7 @@ abstract class Installer {
                 * but we're not opening that can of worms
                 * @see https://bugzilla.wikimedia.org/show_bug.cgi?id=26857
                 */
-               global $wgHooks, $wgAutoloadClasses;
+               global $wgAutoloadClasses;
                require( "$IP/includes/DefaultSettings.php" );
 
                foreach( $exts as $e ) {
@@ -1208,8 +1208,7 @@ abstract class Installer {
 
                // Unset everyone else's hooks. Lord knows what someone might be doing
                // in ParserFirstCallInit (see bug 27171)
-               unset( $wgHooks );
-               $wgHooks = array( 'LoadExtensionSchemaUpdates' => $hooksWeWant );
+               $GLOBALS['wgHooks'] = array( 'LoadExtensionSchemaUpdates' => $hooksWeWant );
 
                return Status::newGood();
        }