[JobQueue] Make sure broken/duplicate job removal counts in stats.
authorAaron Schulz <aschulz@wikimedia.org>
Wed, 31 Oct 2012 03:14:59 +0000 (20:14 -0700)
committerGerrit Code Review <gerrit@wikimedia.org>
Thu, 1 Nov 2012 04:03:21 +0000 (04:03 +0000)
Change-Id: I09b3faa770172ce7aae457ef0af3dd5bafe7319d

includes/job/JobQueueDB.php

index d7d2b19..b850610 100644 (file)
@@ -144,6 +144,7 @@ class JobQueueDB extends JobQueue {
                                $title = Title::makeTitleSafe( $row->job_namespace, $row->job_title );
                                if ( !$title ) {
                                        $dbw->delete( 'job', array( 'job_id' => $row->job_id ), __METHOD__ );
+                                       wfIncrStats( 'job-pop' );
                                        wfDebugLog( 'JobQueueDB', "Row has invalid title '{$row->job_title}'." );
                                        continue; // try again
                                }
@@ -156,6 +157,7 @@ class JobQueueDB extends JobQueue {
                                                        "job_id != {$dbw->addQuotes( $row->job_id )}" ),
                                                __METHOD__
                                        );
+                                       wfIncrStats( 'job-pop', $dbw->affectedRows() );
                                }
                                break; // done
                        } while( true );