X-Git-Url: https://git.cyclocoop.org/%28%28?a=blobdiff_plain;f=tests%2Fphpunit%2Fincludes%2Fconfig%2FGlobalVarConfigTest.php;h=b15ffa721039e1929b8d61ea5cdfa87554be5084;hb=93826089226b2553898b6e094cbe7ba495fe76c6;hp=7080b02335d0dbaf06078b37467c72ccca2f7338;hpb=93405c852cb0a731d31b711c50f527c6aff52664;p=lhc%2Fweb%2Fwiklou.git

diff --git a/tests/phpunit/includes/config/GlobalVarConfigTest.php b/tests/phpunit/includes/config/GlobalVarConfigTest.php
index 7080b02335..b15ffa7210 100644
--- a/tests/phpunit/includes/config/GlobalVarConfigTest.php
+++ b/tests/phpunit/includes/config/GlobalVarConfigTest.php
@@ -2,6 +2,42 @@
 
 class GlobalVarConfigTest extends MediaWikiTestCase {
 
+	/**
+	 * @covers GlobalVarConfig::newInstance
+	 */
+	public function testNewInstance() {
+		$config = GlobalVarConfig::newInstance();
+		$this->assertInstanceOf( 'GlobalVarConfig', $config );
+		$this->maybeStashGlobal( 'wgBaz' );
+		$GLOBALS['wgBaz'] = 'somevalue';
+		// Check prefix is set to 'wg'
+		$this->assertEquals( 'somevalue', $config->get( 'Baz' ) );
+	}
+
+	/**
+	 * @covers GlobalVarConfig::__construct
+	 * @dataProvider provideConstructor
+	 */
+	public function testConstructor( $prefix ) {
+		$var = $prefix . 'GlobalVarConfigTest';
+		$rand = wfRandomString();
+		$this->maybeStashGlobal( $var );
+		$GLOBALS[$var] = $rand;
+		$config = new GlobalVarConfig( $prefix );
+		$this->assertInstanceOf( 'GlobalVarConfig', $config );
+		$this->assertEquals( $rand, $config->get( 'GlobalVarConfigTest' ) );
+	}
+
+	public static function provideConstructor() {
+		return array(
+			array( 'wg' ),
+			array( 'ef' ),
+			array( 'smw' ),
+			array( 'blahblahblahblah' ),
+			array( '' ),
+		);
+	}
+
 	public function provideGet() {
 		$set = array(
 			'wgSomething' => 'default1',
@@ -19,6 +55,7 @@ class GlobalVarConfigTest extends MediaWikiTestCase {
 			array( 'Foo', 'wg', 'default2' ),
 			array( 'Variable', 'ef', 'default3' ),
 			array( 'BAR', '', 'default4' ),
+			array( 'ThisGlobalWasNotSetAbove', 'wg', false )
 		);
 	}
 
@@ -28,9 +65,44 @@ class GlobalVarConfigTest extends MediaWikiTestCase {
 	 * @param string $expected
 	 * @dataProvider provideGet
 	 * @covers GlobalVarConfig::get
+	 * @covers GlobalVarConfig::getWithPrefix
 	 */
 	public function testGet( $name, $prefix, $expected ) {
 		$config = new GlobalVarConfig( $prefix );
+		if ( $expected === false ) {
+			$this->setExpectedException( 'ConfigException', 'GlobalVarConfig::getWithPrefix: undefined variable:' );
+		}
 		$this->assertEquals( $config->get( $name ), $expected );
 	}
+
+	public static function provideSet() {
+		return array(
+			array( 'Foo', 'wg', 'wgFoo' ),
+			array( 'SomethingRandom', 'wg', 'wgSomethingRandom' ),
+			array( 'FromAnExtension', 'eg', 'egFromAnExtension' ),
+			array( 'NoPrefixHere', '', 'NoPrefixHere' ),
+		);
+	}
+
+	private function maybeStashGlobal( $var ) {
+		if ( array_key_exists( $var, $GLOBALS ) ) {
+			// Will be reset after this test is over
+			$this->stashMwGlobals( $var );
+		}
+	}
+
+	/**
+	 * @dataProvider provideSet
+	 * @covers GlobalVarConfig::set
+	 * @covers GlobalVarConfig::setWithPrefix
+	 */
+	public function testSet( $name, $prefix, $var ) {
+		$this->hideDeprecated( 'GlobalVarConfig::set' );
+		$this->maybeStashGlobal( $var );
+		$config = new GlobalVarConfig( $prefix );
+		$random = wfRandomString();
+		$config->set( $name, $random );
+		$this->assertArrayHasKey( $var, $GLOBALS );
+		$this->assertEquals( $random, $GLOBALS[$var] );
+	}
 }