From f6fcb74728311b696caac49576e6b893cc5ebb14 Mon Sep 17 00:00:00 2001 From: Alangi Derick Date: Mon, 3 Dec 2018 12:47:12 +0100 Subject: [PATCH] htmlform: Fix multiple PHPDoc annotations in htmlform module - Add @param annotation for $params variable for __construct() method in the HTMLExpiryField class. - Add @throws annotation for getOptionsOOUI() method that throws a MWException and remove "@return array" as this method only throw an exception now. Change-Id: I292f6ae04b840f6f6f74b7c92f834f056659fbe2 --- includes/htmlform/fields/HTMLExpiryField.php | 1 + includes/htmlform/fields/HTMLMultiSelectField.php | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/includes/htmlform/fields/HTMLExpiryField.php b/includes/htmlform/fields/HTMLExpiryField.php index e7bdb44b85..fb0ca77254 100644 --- a/includes/htmlform/fields/HTMLExpiryField.php +++ b/includes/htmlform/fields/HTMLExpiryField.php @@ -15,6 +15,7 @@ class HTMLExpiryField extends HTMLFormField { /** * Relative Date Time Field. + * @param array $params */ public function __construct( array $params = [] ) { parent::__construct( $params ); diff --git a/includes/htmlform/fields/HTMLMultiSelectField.php b/includes/htmlform/fields/HTMLMultiSelectField.php index 477cc4c1a5..1c4a785fa3 100644 --- a/includes/htmlform/fields/HTMLMultiSelectField.php +++ b/includes/htmlform/fields/HTMLMultiSelectField.php @@ -121,7 +121,7 @@ class HTMLMultiSelectField extends HTMLFormField implements HTMLNestedFilterable /** * Get options and make them into arrays suitable for OOUI. - * @return array Options for inclusion in a select or whatever. + * @throws MWException */ public function getOptionsOOUI() { // Sections make this difficult. See getInputOOUI(). -- 2.20.1