From e8d7b16a8adbc4012102c8b8e3df4c1a31c39715 Mon Sep 17 00:00:00 2001 From: Brion Vibber Date: Fri, 29 Jun 2007 14:42:27 +0000 Subject: [PATCH] * Fix empty message checks for message names containing & This corrects some odd behavior with sidebar items and custom namespaces containing ampersands. --- RELEASE-NOTES | 3 +++ includes/GlobalFunctions.php | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/RELEASE-NOTES b/RELEASE-NOTES index e52d1057fe..44db46ff79 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -243,6 +243,9 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN * Don't use garbled parser cache output when viewing custom CSS or JavaScript pages * (bug 10406) Fix Special:Listusers filter form for non-ASCII localizations +* Fix empty message checks for message names containing & + This corrects some odd behavior with sidebar items and custom namespaces + containing ampersands. == API changes since 1.10 == diff --git a/includes/GlobalFunctions.php b/includes/GlobalFunctions.php index f5bc405d1c..429fd4bf7f 100644 --- a/includes/GlobalFunctions.php +++ b/includes/GlobalFunctions.php @@ -1731,7 +1731,7 @@ function wfAppendToArrayIfNotDefault( $key, $value, $default, &$changed ) { * @return bool */ function wfEmptyMsg( $msg, $wfMsgOut ) { - return $wfMsgOut === "<$msg>"; + return $wfMsgOut === htmlspecialchars( "<$msg>" ); } /** -- 2.20.1