From e65eb02d3e1d5ad49b50f4c95d6f5d21fa40e80a Mon Sep 17 00:00:00 2001 From: Marius Hoch Date: Thu, 18 Oct 2012 05:03:10 +0200 Subject: [PATCH] Unit test for User::getEditCount Rather trivial test for User::getEditCount as suggested by Siebrand in https://gerrit.wikimedia.org/r/26457 This required adding the User in the test to DB, as the data is written to and read from the DB. Change-Id: Ic4e55c01247158315b759654b34fdbdf9a61db01 --- tests/phpunit/includes/UserTest.php | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/tests/phpunit/includes/UserTest.php b/tests/phpunit/includes/UserTest.php index 316e6f5a24..a788253297 100644 --- a/tests/phpunit/includes/UserTest.php +++ b/tests/phpunit/includes/UserTest.php @@ -162,4 +162,28 @@ class UserTest extends MediaWikiTestCase { 'Each user rights (core/extensions) has a corresponding right- message.' ); } + + /** + * Test User::editCount + */ + public function testEditCount() { + $user = User::newFromName( 'UnitTestUser' ); + $user->loadDefaults(); + $user->addToDatabase(); + + // let the user have a few (10) edits + $page = WikiPage::factory( Title::newFromText( 'UserTest_EditCount' ) ); + for( $i = 0; $i < 10; $i++ ) { + $page->doEdit( (string) $i, 'test', 0, false, $user ); + } + + $user->clearInstanceCache(); + $this->assertEquals( 10, $user->getEditCount(), 'After ten edits, the user edit count should be 10' ); + + // increase the edit count and clear the cache + $user->incEditCount(); + + $user->clearInstanceCache(); + $this->assertEquals( 11, $user->getEditCount(), 'After increasing the edit count manually, the user edit count should be 11' ); + } } -- 2.20.1