From bc1532c31c0018578928bbf55d8ea84a21a06e98 Mon Sep 17 00:00:00 2001 From: Krinkle Date: Sat, 3 Sep 2011 00:35:08 +0000 Subject: [PATCH] Html.php: Move html5-validation blacklist check to *AFTER* the check the might continue (and skip this loop entirely) if we're not in HTML5 with an html5-only attribute. * Performance :) --- includes/Html.php | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/includes/Html.php b/includes/Html.php index f4776915cd..70dc186893 100644 --- a/includes/Html.php +++ b/includes/Html.php @@ -389,16 +389,6 @@ class Html { # and we'd like consistency and better compression anyway. $key = strtolower( $key ); - # Bug 23769: Blacklist all form validation attributes for now. Current - # (June 2010) WebKit has no UI, so the form just refuses to submit - # without telling the user why, which is much worse than failing - # server-side validation. Opera is the only other implementation at - # this time, and has ugly UI, so just kill the feature entirely until - # we have at least one good implementation. - if ( in_array( $key, array( 'max', 'min', 'pattern', 'required', 'step' ) ) ) { - continue; - } - # Here we're blacklisting some HTML5-only attributes... if ( !$wgHtml5 && in_array( $key, array( 'autocomplete', @@ -415,6 +405,16 @@ class Html { continue; } + # Bug 23769: Blacklist all form validation attributes for now. Current + # (June 2010) WebKit has no UI, so the form just refuses to submit + # without telling the user why, which is much worse than failing + # server-side validation. Opera is the only other implementation at + # this time, and has ugly UI, so just kill the feature entirely until + # we have at least one good implementation. + if ( in_array( $key, array( 'max', 'min', 'pattern', 'required', 'step' ) ) ) { + continue; + } + # See the "Attributes" section in the HTML syntax part of HTML5, # 9.1.2.3 as of 2009-08-10. Most attributes can have quotation # marks omitted, but not all. (Although a literal " is not -- 2.20.1