From ab357da3c43c93c7809d613da5c60ffc1f1b2392 Mon Sep 17 00:00:00 2001 From: Ed Sanders Date: Thu, 14 Jun 2018 19:41:29 +0100 Subject: [PATCH 1/1] jqueryMsg: Add missing '$' prefix to jQuery collection variables Change-Id: Ic39ca379c373e43d885f6ac9df746e25f744f9d9 --- resources/src/mediawiki.jqueryMsg/mediawiki.jqueryMsg.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/resources/src/mediawiki.jqueryMsg/mediawiki.jqueryMsg.js b/resources/src/mediawiki.jqueryMsg/mediawiki.jqueryMsg.js index d81df65ebb..4f9e43a4cc 100644 --- a/resources/src/mediawiki.jqueryMsg/mediawiki.jqueryMsg.js +++ b/resources/src/mediawiki.jqueryMsg/mediawiki.jqueryMsg.js @@ -237,8 +237,8 @@ * e.g. * * $.fn.msg = mediaWiki.jqueryMsg.getPlugin( options ); - * var userlink = $( '' ).click( function () { alert( "hello!!" ) } ); - * $( 'p#headline' ).msg( 'hello-user', userlink ); + * var $userlink = $( '' ).click( function () { alert( "hello!!" ) } ); + * $( 'p#headline' ).msg( 'hello-user', $userlink ); * * N.B. replacements are variadic arguments or an array in second parameter. In other words: * somefunction( a, b, c, d ) @@ -1379,9 +1379,9 @@ * @return {jQuery} */ mw.Message.prototype.parseDom = ( function () { - var reusableParent = $( '
' ); + var $wrapper = $( '
' ); return function () { - return reusableParent.msg( this.key, this.parameters ).contents().detach(); + return $wrapper.msg( this.key, this.parameters ).contents().detach(); }; }() ); -- 2.20.1