From 6e176bf6c62284cbc5aff2031819154173911c08 Mon Sep 17 00:00:00 2001 From: Platonides Date: Mon, 23 Aug 2010 21:54:45 +0000 Subject: [PATCH] Try to improve the funciton comment of getETag() per r70809 CR. Adaptation of Nikerabbit proposal. --- includes/parser/ParserCache.php | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/includes/parser/ParserCache.php b/includes/parser/ParserCache.php index 614099f38e..043140d425 100644 --- a/includes/parser/ParserCache.php +++ b/includes/parser/ParserCache.php @@ -55,10 +55,14 @@ class ParserCache { } /** - * Provides an E-Tag suitable for the whole page, even if $article is - * just the main wikitext. So it uses the complete set of user options. - * Most importantly, that includes the user language, but other options - * would give problems on some setups, too. + * Provides an E-Tag suitable for the whole page. Note that $article + * is just the main wikitext. The E-Tag has to be unique to the whole + * page, even if the article itself is the same, so it uses the + * complete set of user options. We don't want to use the preference + * of a different user on a message just because it wasn't used in + * $article. For example give a Chinese interface to a user with + * English preferences. That's why we take into account *all* user + * options. (r70809 CR) */ function getETag( $article, $popts ) { return 'W/"' . $this->getParserOutputKey( $article, -- 2.20.1