From 6b998e4c8215c87390014ffa5ae1783184e5118f Mon Sep 17 00:00:00 2001 From: Aryeh Gregor Date: Thu, 24 Jan 2008 20:14:35 +0000 Subject: [PATCH] Avoid relying on isset(). This can cause problems with PHP's (thankfully now uncommon) register_globals setting. Instead, just give the variable a default value in the code. --- includes/Skin.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/Skin.php b/includes/Skin.php index 2d2a4aecc3..ca5ba11a0e 100644 --- a/includes/Skin.php +++ b/includes/Skin.php @@ -1620,6 +1620,7 @@ END; $bar = array(); $lines = explode( "\n", wfMsgForContent( 'sidebar' ) ); + $heading = ''; foreach ($lines as $line) { if (strpos($line, '*') !== 0) continue; @@ -1649,7 +1650,6 @@ END; } } - if( !isset($heading) ) $heading=''; $bar[$heading][] = array( 'text' => $text, 'href' => $href, -- 2.20.1