From 63c149370497045ae6ac3154c3e0c2304fe202d3 Mon Sep 17 00:00:00 2001 From: jrobson Date: Thu, 3 Apr 2014 17:58:56 -0700 Subject: [PATCH] Vector: Simply style external links These external link icons are extremely costly with little gain. During the typography experiment, these were removed, no one raised this as an issue during the 5 months it was live, suggesting that explicit pdf icons etc are not as useful as we like to believe. As a result of these findings posting this patch upstream. Bug: 54604 Change-Id: If985b16c4f682d737683597ed80951c6d6644c8f --- skins/vector/components/externalLinks.less | 72 +---------------- skins/vector/images/audio-icon.png | Bin 185 -> 0 bytes skins/vector/images/audio-icon.svg | 56 ------------- skins/vector/images/document-icon.png | Bin 135 -> 0 bytes skins/vector/images/document-icon.svg | 69 ---------------- skins/vector/images/file-icon.png | Bin 133 -> 0 bytes skins/vector/images/file-icon.svg | 72 ----------------- skins/vector/images/lock-icon.png | Bin 174 -> 0 bytes skins/vector/images/lock-icon.svg | 73 ----------------- skins/vector/images/mail-icon.png | Bin 197 -> 0 bytes skins/vector/images/mail-icon.svg | 69 ---------------- skins/vector/images/news-icon.png | Bin 180 -> 0 bytes skins/vector/images/news-icon.svg | 67 --------------- skins/vector/images/talk-icon.png | Bin 173 -> 0 bytes skins/vector/images/talk-icon.svg | 66 --------------- skins/vector/images/video-icon.png | Bin 162 -> 0 bytes skins/vector/images/video-icon.svg | 90 --------------------- 17 files changed, 3 insertions(+), 631 deletions(-) delete mode 100644 skins/vector/images/audio-icon.png delete mode 100644 skins/vector/images/audio-icon.svg delete mode 100644 skins/vector/images/document-icon.png delete mode 100644 skins/vector/images/document-icon.svg delete mode 100644 skins/vector/images/file-icon.png delete mode 100644 skins/vector/images/file-icon.svg delete mode 100644 skins/vector/images/lock-icon.png delete mode 100644 skins/vector/images/lock-icon.svg delete mode 100644 skins/vector/images/mail-icon.png delete mode 100644 skins/vector/images/mail-icon.svg delete mode 100644 skins/vector/images/news-icon.png delete mode 100644 skins/vector/images/news-icon.svg delete mode 100644 skins/vector/images/talk-icon.png delete mode 100644 skins/vector/images/talk-icon.svg delete mode 100644 skins/vector/images/video-icon.png delete mode 100644 skins/vector/images/video-icon.svg diff --git a/skins/vector/components/externalLinks.less b/skins/vector/components/externalLinks.less index 3e26a223c6..60792d580e 100644 --- a/skins/vector/components/externalLinks.less +++ b/skins/vector/components/externalLinks.less @@ -1,75 +1,9 @@ // FIXME: This size of this CSS is ridiculous. Please refactor (see bug 54604) @import "mediawiki.mixins.less"; - -div#content a.external { +// External links +.external { background-position: center right; background-repeat: no-repeat; - .background-image-svg('images/external-link-ltr-icon.svg', 'images/external-link-ltr-icon.png'); - padding-right: 13px; -} -div#content a.external[href ^="https://"], -.link-https { - background-position: center right; - background-repeat: no-repeat; - .background-image-svg('images/lock-icon.svg', 'images/lock-icon.png'); - padding-right: 13px; -} -div#content a.external[href ^="mailto:"], -.link-mailto { - background-position: center right; - background-repeat: no-repeat; - .background-image-svg('images/mail-icon.svg', 'images/mail-icon.png'); - padding-right: 13px; -} -div#content a.external[href ^="news:"] { - background-position: center right; - background-repeat: no-repeat; - .background-image-svg('images/news-icon.svg', 'images/news-icon.png'); - padding-right: 13px; -} -div#content a.external[href ^="ftp://"], -.link-ftp { - background-position: center right; - background-repeat: no-repeat; - .background-image-svg('images/file-icon.svg', 'images/file-icon.png'); - padding-right: 13px; -} -div#content a.external[href ^="irc://"], -div#content a.external[href ^="ircs://"], -.link-irc { - background-position: center right; - background-repeat: no-repeat; - .background-image-svg('images/talk-icon.svg', 'images/talk-icon.png'); - padding-right: 13px; -} -div#content a.external[href $=".ogg"], div#content a.external[href $=".OGG"], -div#content a.external[href $=".mid"], div#content a.external[href $=".MID"], -div#content a.external[href $=".midi"], div#content a.external[href $=".MIDI"], -div#content a.external[href $=".mp3"], div#content a.external[href $=".MP3"], -div#content a.external[href $=".wav"], div#content a.external[href $=".WAV"], -div#content a.external[href $=".wma"], div#content a.external[href $=".WMA"], -.link-audio { - background-position: center right; - background-repeat: no-repeat; - .background-image-svg('images/audio-icon.svg', 'images/audio-icon.png'); - padding-right: 13px; -} -div#content a.external[href $=".ogm"], div#content a.external[href $=".OGM"], -div#content a.external[href $=".avi"], div#content a.external[href $=".AVI"], -div#content a.external[href $=".mpeg"], div#content a.external[href $=".MPEG"], -div#content a.external[href $=".mpg"], div#content a.external[href $=".MPG"], -.link-video { - background-position: center right; - background-repeat: no-repeat; - .background-image-svg('images/video-icon.svg', 'images/video-icon.png'); - padding-right: 13px; -} -div#content a.external[href $=".pdf"], div#content a.external[href $=".PDF"], -div#content a.external[href *=".pdf#"], div#content a.external[href *=".PDF#"], -div#content a.external[href *=".pdf?"], div#content a.external[href *=".PDF?"], -.link-document { - background-position: center right; - background-repeat: no-repeat; - .background-image-svg('images/document-icon.svg', 'images/document-icon.png'); + .background-image-svg('images/external-link-ltr-icon.svg', 'images/external-link-ltr-icon.png' ); padding-right: 13px; } diff --git a/skins/vector/images/audio-icon.png b/skins/vector/images/audio-icon.png deleted file mode 100644 index 5a1d2f432503576815711c1255fc57173fe81b84..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 185 zcmeAS@N?(olHy`uVBq!ia0vp^AT}2ZGmxy8xzq=w3<7*YT>t<7Us|tq;$n4Wv+ - - - - - - - - - - - - image/svg+xml - - - - - - - - - diff --git a/skins/vector/images/document-icon.png b/skins/vector/images/document-icon.png deleted file mode 100644 index 4d56572b703ab35a12348dea5a448277c48610ea..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 135 zcmeAS@N?(olHy`uVBq!ia0vp^AT}2V3y@T|W;X*;ex5FlAr*0{ryRK&40u>C*8h$> zviXZjSGN*}s9;Rb$wh4$Z8>uBD-32i%u{~6syJb*SoL%9^u<%zL@r%Ab>qg3m;axB jj4kuid)E?}z-L>VKcD4b^{NR#lNmf+{an^LB{Ts5O7AbD diff --git a/skins/vector/images/document-icon.svg b/skins/vector/images/document-icon.svg deleted file mode 100644 index fd05df80cf..0000000000 --- a/skins/vector/images/document-icon.svg +++ /dev/null @@ -1,69 +0,0 @@ - - - - - - - - - - - - - image/svg+xml - - - - - - - - - - - - diff --git a/skins/vector/images/file-icon.png b/skins/vector/images/file-icon.png deleted file mode 100644 index ed246698687733322fe2477ea75a2a23c5913ec2..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 133 zcmeAS@N?(olHy`uVBq!ia0vp^AT}2V3y@T|W;X*;KAtX)Ar*0}=gk*WzvE9Lg&CM&eOx#u>aslMS2@7`UOAD&!Vy>aoOwdM<0q%Inp$;G)HJ9j)K hRYu1)S!9NL9hb|3(5IO - - - - - - - - - - - - image/svg+xml - - - - - - - - - - - - - diff --git a/skins/vector/images/lock-icon.png b/skins/vector/images/lock-icon.png deleted file mode 100644 index a9ba8a72170a8d3e1d889fcbfd2fcc7ffa9499ea..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 174 zcmeAS@N?(olHy`uVBq!ia0vp^AT}2V8<6ZZI=>f4m3q23hDd}b|M>sko|z~A&X$Mu z?%~=p%|8q*d0Z8KU0ofXAQfpCqqvLn#H@#07uUKRSE$^Psh|Jj-~a!5KmY%i->oQd zqOM;5$N#sN=OrAS!DVmO^s)cBVT-8V%rhVVe_mXmrTOQR#iRf2zZL(_kNI{W#G_|D Z{>}OBetE diff --git a/skins/vector/images/lock-icon.svg b/skins/vector/images/lock-icon.svg deleted file mode 100644 index bad5daf0ce..0000000000 --- a/skins/vector/images/lock-icon.svg +++ /dev/null @@ -1,73 +0,0 @@ - - - - - - - - - - - - - image/svg+xml - - - - - - - - - - - - - diff --git a/skins/vector/images/mail-icon.png b/skins/vector/images/mail-icon.png deleted file mode 100644 index 0d93a2f8396fde0ec5cd54b0bc147d1b82b3fbbd..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 197 zcmeAS@N?(olHy`uVBq!ia0vp^AT}2VGmzZ%#=aj&83g!*xc&!&j;_{k-@d(i_44HL z!+ZDce){zB%^O#L|NgOQ)25ftA1z)uXT|cx8`rJ+_~C8H`7A}CUdECjzhDN3XE)M- z9A{4#$B>F!y2p+)9#G(6cF@^*LFn6kv$lfu+L;W2e61W`)}8ya|9Fl3MZu)?iyG!` sT4kuMYv6e^HUCRtR&U5@E4}{=-hGS}6-PZ>fyOa-y85}Sb4q9e0ONyLYybcN diff --git a/skins/vector/images/mail-icon.svg b/skins/vector/images/mail-icon.svg deleted file mode 100644 index cab6304086..0000000000 --- a/skins/vector/images/mail-icon.svg +++ /dev/null @@ -1,69 +0,0 @@ - - - - - - - - - - - - - image/svg+xml - - - - - - - - - - - - - diff --git a/skins/vector/images/news-icon.png b/skins/vector/images/news-icon.png deleted file mode 100644 index 6f27054be792aa3328bb0b6d7cb77526da405afe..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 180 zcmeAS@N?(olHy`uVBq!ia0vp^AT}2V8<6ZZI=>f4ReQQPhE&|@o#4pTpdjFCyWu*= zqF@P;i%N@p-!1yqG|#c%q2{t*2A(NXJ`{YMU(e - - - - - - - - - - - - image/svg+xml - - - - - - - - - - - diff --git a/skins/vector/images/talk-icon.png b/skins/vector/images/talk-icon.png deleted file mode 100644 index 0332054ee18366d44cc49987fdc19f7eb7fb2cb6..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 173 zcmeAS@N?(olHy`uVBq!ia0vp^AT}2V8<6ZZI=>f4m3X>1hE&|Dy>OSSL4k)YAl|Mc zPMd3wW;M@8`90gWl`L4pHs7FZ!pa-pww^itMRJC{DvOCd>yGxQ*Lue!#11heuRXeC zN`%J=%kVwlZPv6Zv>bT9LhtIVwq4=gn(-X&tu20~QzVj4S}H49{JY)3aV - - - - - - - - - - - - image/svg+xml - - - - - - - - - - - - diff --git a/skins/vector/images/video-icon.png b/skins/vector/images/video-icon.png deleted file mode 100644 index ed852322a9ed282f0d2ad048de6dedad759f318f..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 162 zcmeAS@N?(olHy`uVBq!ia0vp^AT}2VkYHF5IUx~9F_i@Q1vC7Qo~X1H$cy%LaSW-r zrQ5ra)4`B~H8yqwU&O8>uh+g|YD#IHU>Wp8{lo6;cYWvHX)UUizqMhGG4E_Q>0=MC zvSqUA+z9d%+rt%6G;!@I`K(>aJ;C$a*!oxRjW|0+`nUMSAIufY-M*K^cx(Y#?&<31 Jvd$@?2>|3&I>rD1 diff --git a/skins/vector/images/video-icon.svg b/skins/vector/images/video-icon.svg deleted file mode 100644 index 0b3d3022e1..0000000000 --- a/skins/vector/images/video-icon.svg +++ /dev/null @@ -1,90 +0,0 @@ - - - - - - - - - - - - - image/svg+xml - - - - - - - - - - - - - - - - - -- 2.20.1