From 62d676f114d9aef45588d51d64d8f6adb6ccf123 Mon Sep 17 00:00:00 2001 From: Antoine Musso Date: Sat, 3 Feb 2007 21:58:37 +0000 Subject: [PATCH] Fix #6684: Improper javascript array iteration causes problems Patch by Dan Li --- RELEASE-NOTES | 1 + skins/common/wikibits.js | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/RELEASE-NOTES b/RELEASE-NOTES index 97d3ff5e71..390ff47d3d 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -169,6 +169,7 @@ lighter making things easier to read. * Fix for paths in 1.4->1.5 special-case updater script * (bug 8789) AJAX search: IE users can now use the return key * (bug 6844) Use and tags to emphase the differences +* (bug 6684) Fix improper javascript array iteration == Languages updated == diff --git a/skins/common/wikibits.js b/skins/common/wikibits.js index cf5369457e..b7762b987f 100644 --- a/skins/common/wikibits.js +++ b/skins/common/wikibits.js @@ -374,10 +374,10 @@ function mwSetupToolbar() { return false; } - for (var i in mwEditButtons) { + for (var i = 0; i < mwEditButtons.length; i++) { mwInsertEditButton(toolbar, mwEditButtons[i]); } - for (i in mwCustomEditButtons) { + for (var i = 0; i < mwCustomEditButtons.length; i++) { mwInsertEditButton(toolbar, mwCustomEditButtons[i]); } return true; -- 2.20.1